Solved

Loaded array sumlookup - can we go faster?

Posted on 2012-03-12
8
405 Views
Last Modified: 2012-03-12
follow on from here a37709867

Public Function SumVlookups(ByVal Lookupvalue As Double, ByVal RangeToSum As Range) As Double
    Dim Found            As Variant
    Dim varData
    Dim varVal
    Dim varValue
    Dim n                As Long

    varData = RangeToSum.Value


    For n = LBound(varData, 1) To UBound(varData, 1)
        ' load array data
        If InStr(varData(n, 1), Lookupvalue & ",") > 0 Then
        Found = Evaluate(varData(n, 1))
        If Not IsError(Found) Then
            ' check for match on lookup value
            varVal = Application.VLookup(Lookupvalue, Found, 1, False)

            If Not IsError(varVal) Then
                ' return relvant value from second column
                varValue = Application.VLookup(Lookupvalue, Found, 2, False)
                ' make sure it's a number
                If IsNumeric(varValue) Then
                    SumVlookups = SumVlookups + varValue
                Else
                    SumVlookups = CVErr(xlErrValue)
                    Exit For
                End If
            End If
        End If
    End If
    Next n

End Function

Open in new window


Is this:

InStr(varData(n, 1), Lookupvalue & ",") > 0

any faster than this:

vlookup(lookupvalue, Evaluate(varData(n, 1)),1)

Ans: ok, I get it, of course it is, it's checking the existence of lookupvalue without having to run the evaluate. ok. clever. because by definition of array constant, the comma is obligatory for a valid lookup, and it has to be much faster than running a lookup on the evaluated result in order to decide whether to run the lookup on col2, because at the least it's running one function instead of two.

I am pondering removal of the error process because it would be much faster to mask everything and then in the event the control totals are out, we can run a more sophisticated UDF to see where/if the errors are. which will be invalid input errors; of course that won't catch wrong valid input errors and I think these invalid input errors are unlikely because there is also a single total being generated from each string at time of input and that would have to be accepted while wrong... and that itself gets check against another control total and as an individual amount in its own right. Conclusion: kill the error trapping to speed up the calcs. mask everything. finally. I can use a separate evaluate to run data check on this, rather than run audit checks inside every calculation for eternity.

this is versus the original code:

Public Function SumVlookups(ByVal Lookupvalue As Single, ByVal RangeToSum As Range) As Single

    Dim ArrayStr As Range
    Dim Found As Variant
           
    For Each ArrayStr In RangeToSum
       
       Found = Evaluate(ArrayStr.Value)
       
       If Not IsError(Application.VLookup(Lookupvalue, Found, 1, False)) Then SumVlookups = SumVlookups + Application.VLookup(Lookupvalue, Found, 2, False)
              
      Next ArrayStr
 
End Function
                            

Open in new window

     

so it's now a speed test, and all errors can be masked.

Anthony
0
Comment
Question by:anthonymellorfca
  • 4
  • 4
8 Comments
 
LVL 85

Expert Comment

by:Rory Archibald
Comment Utility
You might also want to try this version:
Public Function SumVlookups(ByVal Lookupvalue As Double, ByVal RangeToSum As Range) As Double
    Dim varRowData
    Dim varItemData
    Dim varData
    Dim n                As Long
    Dim x As Long
    Dim y As Long
    Dim lngStart As Long
    Dim lngStop As Long

    varData = RangeToSum.Value


    For n = LBound(varData, 1) To UBound(varData, 1)
        ' load array data
        If InStr(varData(n, 1), Lookupvalue & ",") > 0 Then
            varRowData = Split(Mid(varData(n, 1), 2, Len(varData(n, 1)) - 2), ";")
            For x = LBound(varRowData) To UBound(varRowData)
                varItemData = Split(varRowData(x), ",")
                For y = LBound(varItemData) To UBound(varItemData) Step 2
                    If varItemData(y) = Lookupvalue Then
                        SumVlookups = SumVlookups + varItemData(y + 1)
                        Exit For
                    End If
                Next y
            Next x
        End If
    Next n

End Function

Open in new window

0
 
LVL 9

Author Comment

by:anthonymellorfca
Comment Utility
I figured out why I thought the original was calculating faster, the screenfull in view was updating almost instantly, but the remaining approx 950 rows weren't.

So, that's back to speed testing. looking at the above now.. as best I can of course.
0
 
LVL 85

Accepted Solution

by:
Rory Archibald earned 500 total points
Comment Utility
This one is reasonably quick, if a little illegible. ;)

Function SumByCriteria(varCriterion, rngData As Range) As Double
    Dim varData
    Dim varSubData
    Dim n As Long
    With rngData
    varData = Filter(.Worksheet.Evaluate("transpose(if(" & .Address & "="""","""",MID(" & .Address & ",2,len(" & .Address & ")-2)))"), varCriterion & ",")
    End With
    varSubData = Filter(Split(Join(varData, ";"), ";"), varCriterion & ",")
    For n = LBound(varSubData) To UBound(varSubData)
        SumByCriteria = SumByCriteria + CDbl(Split(varSubData(n), ",")(1))
    Next n
End Function

Open in new window

0
 
LVL 9

Author Comment

by:anthonymellorfca
Comment Utility
hmmmmmmm... try the attached for speed....

and note it's not xlsm or even xlsx but xls
SumVLooksEval3rBH-FORMULA.xls
0
Threat Intelligence Starter Resources

Integrating threat intelligence can be challenging, and not all companies are ready. These resources can help you build awareness and prepare for defense.

 
LVL 85

Expert Comment

by:Rory Archibald
Comment Utility
On mobile, so can't view code. Will have a look later.
0
 
LVL 85

Expert Comment

by:Rory Archibald
Comment Utility
I'm going to guess the BH stands for Barry Houdini! If so, I'll buy him a pint on Thursday. :)
0
 
LVL 9

Author Comment

by:anthonymellorfca
Comment Utility
thought you might guess :-)

save you looking:

=SUMPRODUCT((0&MID(LEFT(A$2:A$1000&0,FIND(";",A$2:A$1000&";;",FIND(";"&B2&",",";"&A$2:A$1000&";"&B2&","))-1),FIND(";"&B2&",",";"&A$2:A$1000&";"&B2&",")+LEN(B2)+1,99))+0)

instead of our UDF , entered in the same cells. Amay zing.
0
 
LVL 9

Author Comment

by:anthonymellorfca
Comment Utility
figure I could hide it away in an XLM if it doesn't slow things down, easier to maintain one complex formula than many.
0

Featured Post

Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

Join & Write a Comment

How to quickly and accurately populate Word documents with Excel data, charts and images (including Automated Bookmark generation) David Miller (dlmille) Synopsis In this article you’ll learn how to use ExcelToWord! to copy data,charts, shapes …
Calculating holidays and working days is a function that is often needed yet it is not one found within the Framework. This article presents one approach to building a working-day calculator for use in .NET.
Graphs within dashboards are meant to be dynamic, representing data from a period of time that will change each time the dashboard is updated with new data. Rather than update each graph to point to a different set within a static set of data, t…
This Micro Tutorial will demonstrate on a Mac how to change the sort order for chart legend values and decrpyt the intimidating chart menu.

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

5 Experts available now in Live!

Get 1:1 Help Now