Better way than this to export Datatable to Excel/Email?

In the code below, I retrieve a DataTable from SQL, then enumerate into a text file, attach it to an email and send it:

Dim dt as DataTable = GetData()
Dim sb As New StringBuilder
For Each dc As DataColumn In dt.Columns
	sb.Append("<td>" & dc.ColumnName & "</td>")
For Each dr As DataRow In dt.Rows
	For Each dc As DataColumn In dt.Columns
		sb.Append("<td>" & dr.Item(dc.ColumnName).ToString & "</td>")
Dim mm As New MailMessage
mm.To.Add(New MailAddress("", "Me"))
mm.From = New MailAddress("")
mm.IsBodyHtml = False
mm.Body = "Your data is attached"
If File.Exists(Environment.CurrentDirectory & "\" & Me._SpreadSheetFile) Then
	File.Delete(Environment.CurrentDirectory & "\" & Me._SpreadSheetFile)
End If
Dim fs As FileStream = File.Create((Environment.CurrentDirectory & "\" & Me._SpreadSheetFile))
Dim writer As New StreamWriter((Environment.CurrentDirectory & "\" & Me._SpreadSheetFile), True)
	Dim att As New Attachment(Environment.CurrentDirectory & "\" & Me._SpreadSheetFile)
	att.ContentType = New Net.Mime.ContentType("application/")
Catch ex As ApplicationException
	Throw ex
End Try
Dim sc As New SmtpClient(System.Environment.MachineName, 25)
sc.DeliveryMethod = Net.Mail.SmtpDeliveryMethod.Network
sc.UseDefaultCredentials = False
sc.Credentials = Me._emailCredentials
Catch ex As Exception
	Throw ex
	sb = Nothing
	mm = Nothing
	sc = Nothing
End Try

Open in new window

I am a VB.NET newbie, so have the following questions:

1) The attachment should be a Microsoft Excel spreadsheet.  Because Excel opens basic HTML, I've simply create a text file with HTML inside, and saved as XLS.  Is there a more efficient/better recommended way to export to Excel?  I've read dozens of tutorials on this today already so please don't post any more...!

2) Is it possible to attach the file directly from memory, to save creating the file in the operating system, then attaching it, then deleting next time it is executed?

3) At the risk of scrapping all my code, is there a more efficient/faster way to complete my logic?
LVL 25
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

this procedure will write your datatable to a specified excel file

Public Sub DataTableToExcel(ByVal fileName As String, ByVal dt As System.Data.DataTable)
	Dim ExlApp As Excel.Application
    	Dim aBook As Excel.Workbook
        Dim iCol, iRow, iColVal As Integer
        Dim missing As Object = System.Reflection.Missing.Value
        Dim i As Integer
        ' Open the document that was chosen by the dialog
        Dim aBook As Excel.Workbook
            ''re-initialize excel app
            ExlApp = New Excel.Application

            If ExlApp Is Nothing Then
                ''throw an exception
                Throw (New Exception("Unable to Start Microsoft Excel"))
                ''supresses overwrite warnings
                ExlApp.DisplayAlerts = False
                'aBook = New Excel.Workbook
                ''check if file exists
                If File.Exists(fileName) Then
                    aBook = ExlApp.Workbooks.Open(fileName)
                    aBook = ExlApp.Workbooks.Add(Excel.XlWBATemplate.xlWBATWorksheet)
                End If
                With ExlApp
                    .SheetsInNewWorkbook = 1
                    'For displaying the column name in the the excel file.
                    For iCol = 0 To dt.Columns.Count - 1
                        ''clear column name before setting a new value
                        .Cells(1, iCol + 1).Value = ""
                        .Cells(1, iCol + 1).Value = dt.Columns(iCol).ColumnName.ToString
                    'For displaying the column value row-by-row in the the excel file.
                    For iRow = 0 To dt.Rows.Count - 1
                            For iColVal = 0 To dt.Columns.Count - 1
                                If TypeOf dt.Rows(iRow).ItemArray(iColVal) Is String Then
                                    .Cells(iRow + 2, iColVal + 1).Value = "'" & Trim(dt.Rows(iRow).ItemArray(iColVal).ToString)
                                    .Cells(iRow + 2, iColVal + 1).Value = Trim(dt.Rows(iRow).ItemArray(iColVal).ToString)
                                End If
                        Catch ex As Exception
                            err.WriteError("C:\ERRORS\", ex.Message, ex.StackTrace)
                            'err.WriteError(GetExecutingAssembly.Location.ToString() & "errorlog.txt", ex.Message, ex.StackTrace)
                            Console.Write("ERROR: " & ex.Message)
                        End Try
                    If File.Exists(fileName) Then
                        .ActiveWorkbook().Save() 'fileName)
                        .ActiveWorkbook().SaveAs(fileName, missing, missing, missing, missing, missing, Excel.XlSaveAsAccessMode.xlNoChange, missing, missing, missing, missing, missing)
                    End If
                End With
                Console.Write("File exported sucessfully")
            End If
        Catch ex As Runtime.InteropServices.COMException
            Console.Write("ERROR: " & ex.Message)
        Catch ex As Exception
            Console.Write("ERROR: " & ex.Message)
            aBook = Nothing
            ExlApp = Nothing

        End Try
    End Sub

Open in new window

Jacques Bourgeois (James Burger)PresidentCommented:
Excel can connect directly to SQL Server and create a spreadsheet out of the result of a query.

You might be able to have Excel do all the job for your without having to go through a DataTable to retrieve the data.

Explore the Data...Import External Data menu entry in Excel 2003 or whatever ribbon entry that replaces that in newer versions.

Using that feature, your .NET code could simply open the Excel file, trigger a refresh of the data, save and the job is done. Simply send the result.

I have not worked with that feature in years, and used the scenario that I am suggesting from VB6 with old code I do not have anymore, so I cannot send you sample code. But I remember that it was very efficient and easy to code.
RouchieAuthor Commented:
Thanks for your responses.  Please let me answer each in turn...

>> this procedure will write your datatable to a specified excel file

Yes that looks fine.  Some questions though:

1) I assume I need to create a Reference to Excel in the VB project for this to work?
2) Excel is not installed on the live server, only on development machines, so would this work in a live environment?
3) You appear to enumerate row-by-row, as in my example, so surely its not any more efficient?
4) Its also creating a file on the OS which I'm trying to avoid - can the file be passed straight from memory as an attachment?

>> Excel can connect directly to SQL Server and create a spreadsheet out of the result of a query.

That's a good idea, however, in this case Excel is being used as a third-party data transfer tool between two databases that cannot connect directly to one another.  Therefore the live machines won't have Excel, so .NET is doing the work of reading the data and converting to ADO.NET.
OWASP: Threats Fundamentals

Learn the top ten threats that are present in modern web-application development and how to protect your business from them.

1) You are correct
2) That's a problem, if you are using Interop, Excel must be installed
3) Do you have other suggestions?
4) I don't think so

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
RouchieAuthor Commented:
Hey YZlat

Thanks for the follow up.

>>> 3) You appear to enumerate row-by-row, as in my example, so surely its not any more efficient?
>>  Do you have other suggestions?

Nope, but, being new to this type of thing I wondered if there was any method I wasn't aware of to 'push' the DataTable into a text representation without enumeration being necessary.
I tried getting SQL to export the results as XML, which worked really well, however, Excel 2003 (on the client server) could not open it natively without Importing.

From the links you posted, the first is very similar to what I've done initially, which gives me reassurance that I've not wasted my time, so thanks for that.

The second link involves using a webcontrol, which I do within my web apps (where my skills lie), however, I was researching to see if there was a 'better Forms method' than this.  Anyway I'm kind of glad there isn't because at least now I can move on.

Thanks for your help and clarification.
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Visual Basic.NET

From novice to tech pro — start learning today.