  asked on

# need to calculate percentage from table data

Hi experts,
I need to calculate percentage from a table with data as below
Cust_no  On-time
1                O
1                N
1                O
2                N
2                N
2                O
2                O

So I need to add a column called PercOntime = 100X(count(O)) / Total count

For the column On-time , flag O- ontime payments and  Flag N- not on time.
Microsoft SQL ServerMicrosoft SQL Server 2008 Last Comment
sqlcurious

8/22/2022 - Mon
David L. Hansen

Bad idea.  If this is Excel, no problem.  If you are doing this in the table itself you are violating good normalization rules.

Standard example is: Age and Birthdate in the same table is bad because one is a direct calculation of the other.  You could end up with them getting out of sync.  It is just unnecessary.  Do the calculation in the application(s) that use the table.
sqlcurious

k sure, but please give me a work out, creating a new temp table with this column and doing the calculation there?
SANDY_SK

what you can do is that have a stored procedure / a view to do the required calculations
jogos

View or stored procedure

The basic select for your % per customer.

``````select Cust_no,   100 * (sum(case when On-time= 'O' then 1 else 0 end) / count(Cust_no)) as Pct
from dbo.tableA
group by Cust_no
``````
David L. Hansen

Views are excellent for this sort of thing.  The underlying data stays pristine.
sqlcurious

thanks the reply but I am getting result as 0 or 100
jogos

How to debug .... (or how to start builiding it yourself)  start part by part implementing the functions you want and test step by step

Is the Case ok

select Cust_no,   On-time,
case when On-time= 'O' then 1 else 0 end,
from dbo.tableA

What count and sum + together in calculation

select Cust_no,
count(Cust_no),
sum(case when On-time= 'O' then 1 else 0 end),
100 * (sum(case when On-time= 'O' then 1 else 0 end) / count(Cust_no)) as Pct
from dbo.tableA
group by Cust_no
appari

your current query is doing integer division, need to convert numbers to decimal/float.
try this
``````select Cust_no,   100.0 * (sum(case when On-time= 'O' then 1 else 0 end) * 1.0 / count(Cust_no)) as Pct
from dbo.tableA
group by Cust_no
``````
deighton

try

select Cust_no,   100.0 * (sum(case when On-time= 'O' then 1.0 else 0.0 end) / count(Cust_no)) as Pct
from dbo.tableA
group by Cust_no