• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 404
  • Last Modified:

VBA to check cell value for NULL then replace with another value

Hi Experts,

I have a macro that someone else wrote but I have to make adjustments to.  I need some help to figure out the best way to acheive the following:

If Last Name = null look in the first name column.  Find the space in the first name column then cut the text after the space then past to the last name column.  

Below is current code.  When it runs and the last name = Null the merged field is empty.

'Name************************************************************
'first
Cells(1, 1).Select
k = 1

Do While First_name <> "RAFirst"
If Cells(1, k).Value <> "RAFirst" Then
k = k + 1
Else
First_name = "RAFirst"
End If

Loop
First_name = k



Columns(First_name).Select
Selection.Copy
Columns("N:N").Select
Selection.Insert Shift:=xlToRight

'last
Cells(1, 1).Select
k = 1

Do While Last_name <> "RALast"
If Cells(1, k).Value <> "RALast" Then
k = k + 1
Else
Last_name = "RALast"
End If

Loop
Last_name = k



Columns(Last_name).Select
Selection.Copy
Columns("O:O").Select
Selection.Insert Shift:=xlToRight

'merge 1st and LastNames
Columns("N:N").Select
Selection.Insert Shift:=xlToRight

For i = 2 To j

Cells(i, 14) = Cells(i, 15) & " " & Cells(i, 16)
Next i

Columns("N:N").Select
Selection.Copy

Cells(1, 14).Select
Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
0
rhadash
Asked:
rhadash
  • 4
  • 4
1 Solution
 
Saqib Husain, SyedEngineerCommented:
From what I understood, what you need is simply

Sub splitfirstlast()
Dim cel As Range
For Each cel In Range("B:B")
    If cel = "" And cel.Offset(0, -1) <> "" Then
        cel = Right(cel.Offset(0, -1), Len(cel.Offset(0, -1)) - InStr(cel.Offset(0, -1), " "))
        cel.Offset(0, -1) = Left(cel.Offset(0, -1), InStr(cel.Offset(0, -1), " ") - 1)
    End If
Next cel
End Sub
0
 
rhadashAuthor Commented:
I put the code before the name merge and then tried at the begining but did not work.  Code runs no errors but does not provide the desired result.  I attached the macro.
respmacro.txt
0
 
Saqib Husain, SyedEngineerCommented:
I cannot test your macro without your data.

I have setup some data which the macro works on. See attached.
Splitnames.xls
0
Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
rhadashAuthor Commented:
heres the data file that will run with the marco i posted.
Thank you
DATA-031412.xlsx
0
 
rhadashAuthor Commented:
Are you dropping this question?
0
 
Saqib Husain, SyedEngineerCommented:
Sorry I had lost track.

Try this modification
Replace

For i = 2 To j

Cells(i, 14) = Cells(i, 15) & " " & Cells(i, 16)
Next i

Open in new window


with

For i = 2 To Range("O2").End(xlDown).Row

If Cells(i, 15) = "NULL" Then
Cells(i, 14) = Right(Cells(i, 16), Len(Cells(i, 16)) - InStr(Cells(i, 16), " ")) & " " & Left(Cells(i, 16), InStr(Cells(i, 16), " ") - 1)
Else
Cells(i, 14) = Cells(i, 15) & " " & Cells(i, 16)
End If
Next i

Open in new window

0
 
rhadashAuthor Commented:
Thank you!  When I look at the solution you provided it makes sence to me but I cant figure for self.  Any suggestions for me to help me improve /gain skills?
0
 
Saqib Husain, SyedEngineerCommented:
Just follow this site. There is enough here to teach you. Just keep an eye on the questions and have a go at the simpler ones and see how others respond to more tricky ones. After some time you would be after the more tricky ones. The key is "Spend time".

Good luck and thanks for the grade.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: ZipGrep

ZipGrep is a utility that can list and search zip (.war, .ear, .jar, etc) archives for text patterns, without the need to extract the archive's contents.

One of a set of tools we're offering as a way to say thank you for being a part of the community.

  • 4
  • 4
Tackle projects and never again get stuck behind a technical roadblock.
Join Now