Solved

VBA to check cell value for NULL then replace with another value

Posted on 2012-03-14
8
389 Views
Last Modified: 2012-03-16
Hi Experts,

I have a macro that someone else wrote but I have to make adjustments to.  I need some help to figure out the best way to acheive the following:

If Last Name = null look in the first name column.  Find the space in the first name column then cut the text after the space then past to the last name column.  

Below is current code.  When it runs and the last name = Null the merged field is empty.

'Name************************************************************
'first
Cells(1, 1).Select
k = 1

Do While First_name <> "RAFirst"
If Cells(1, k).Value <> "RAFirst" Then
k = k + 1
Else
First_name = "RAFirst"
End If

Loop
First_name = k



Columns(First_name).Select
Selection.Copy
Columns("N:N").Select
Selection.Insert Shift:=xlToRight

'last
Cells(1, 1).Select
k = 1

Do While Last_name <> "RALast"
If Cells(1, k).Value <> "RALast" Then
k = k + 1
Else
Last_name = "RALast"
End If

Loop
Last_name = k



Columns(Last_name).Select
Selection.Copy
Columns("O:O").Select
Selection.Insert Shift:=xlToRight

'merge 1st and LastNames
Columns("N:N").Select
Selection.Insert Shift:=xlToRight

For i = 2 To j

Cells(i, 14) = Cells(i, 15) & " " & Cells(i, 16)
Next i

Columns("N:N").Select
Selection.Copy

Cells(1, 14).Select
Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
0
Comment
Question by:rhadash
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 4
8 Comments
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
ID: 37721602
From what I understood, what you need is simply

Sub splitfirstlast()
Dim cel As Range
For Each cel In Range("B:B")
    If cel = "" And cel.Offset(0, -1) <> "" Then
        cel = Right(cel.Offset(0, -1), Len(cel.Offset(0, -1)) - InStr(cel.Offset(0, -1), " "))
        cel.Offset(0, -1) = Left(cel.Offset(0, -1), InStr(cel.Offset(0, -1), " ") - 1)
    End If
Next cel
End Sub
0
 

Author Comment

by:rhadash
ID: 37721720
I put the code before the name merge and then tried at the begining but did not work.  Code runs no errors but does not provide the desired result.  I attached the macro.
respmacro.txt
0
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
ID: 37721991
I cannot test your macro without your data.

I have setup some data which the macro works on. See attached.
Splitnames.xls
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 

Author Comment

by:rhadash
ID: 37725982
heres the data file that will run with the marco i posted.
Thank you
DATA-031412.xlsx
0
 

Author Comment

by:rhadash
ID: 37730037
Are you dropping this question?
0
 
LVL 43

Accepted Solution

by:
Saqib Husain, Syed earned 500 total points
ID: 37730317
Sorry I had lost track.

Try this modification
Replace

For i = 2 To j

Cells(i, 14) = Cells(i, 15) & " " & Cells(i, 16)
Next i

Open in new window


with

For i = 2 To Range("O2").End(xlDown).Row

If Cells(i, 15) = "NULL" Then
Cells(i, 14) = Right(Cells(i, 16), Len(Cells(i, 16)) - InStr(Cells(i, 16), " ")) & " " & Left(Cells(i, 16), InStr(Cells(i, 16), " ") - 1)
Else
Cells(i, 14) = Cells(i, 15) & " " & Cells(i, 16)
End If
Next i

Open in new window

0
 

Author Closing Comment

by:rhadash
ID: 37730711
Thank you!  When I look at the solution you provided it makes sence to me but I cant figure for self.  Any suggestions for me to help me improve /gain skills?
0
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
ID: 37730735
Just follow this site. There is enough here to teach you. Just keep an eye on the questions and have a go at the simpler ones and see how others respond to more tricky ones. After some time you would be after the more tricky ones. The key is "Spend time".

Good luck and thanks for the grade.
0

Featured Post

[Webinar] How Hackers Steal Your Credentials

Do You Know How Hackers Steal Your Credentials? Join us and Skyport Systems to learn how hackers steal your credentials and why Active Directory must be secure to stop them. Thursday, July 13, 2017 10:00 A.M. PDT

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Do you use a spreadsheet like Microsoft's Excel?  Have you ever wanted to link out to a non excel file on your computer or network drive?  This is the way I found to do it!
This article describes a serious pitfall that can happen when deleting shapes using VBA.
Learn how to create and modify your own paragraph styles in Microsoft Word. This can be helpful when wanting to make consistently referenced styles throughout a document or template.
This Micro Tutorial will demonstrate how to use a scrolling table in Microsoft Excel using the INDEX function.

734 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question