[Last Call] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 417
  • Last Modified:

PHP code and $_GET $_POST

Hi,
I've posted here before about someone elses (non-working) PHP code I am making my way through. The code was written about 2005, if that tells you anything about the version of PHP they were using.
After posting the code, one of your Experts noticed that this was defined in many places:
global $HTTP_GET_VARS
global $HTTP_POST_VARS
I have since changed every occurance of $HTTP_GET_VARS to $_GET and  $HTTP_POST_VARS to $_POST.  My code is still not working but I have made some progress and now it's 'kinda' working.

I have a few questions

1.  Does $_POST return the same data in the same way that $HTTP_POST_VARS would have returned? The same question applies to $_GET and $HTTP_GET_VARS.

2. I'm noticing the split function in used throughout the code. I've read that it's deprecated and not advisable to use. below is one example of the split.
My questions regarding this are
    -  online docs say I should use preg_split(). How would I rewrite this using preg_split
    - It looks from the code that's it's splitting on a colon, thing is that I don't see any way a colon could have gotten into the string that CCGetFromGet is returning. Does the colon exist in the array that $_GET returns? If so, I'm not seeing when I do a var_dump($_GET).
   
$CCSForm = split(":", CCGetFromGet("ccsForm", ""), 2);

//Here is the function it's calling
function CCGetFromGet($parameter_name, $default_value = "")
{

    //global $HTTP_GET_VARS;
//echo $_GET[$parameter_name];
return isset($_GET[$parameter_name]) ? CCStrip($_GET[$parameter_name]) :$default_value;
}
//End CCGetFromGet

Thanks!

Nacht
0
nachtmsk
Asked:
nachtmsk
1 Solution
 
gr8gonzoConsultantCommented:
1. Yes.

2. If you're just splitting by a single character delimiter, then use explode() instead of split(). It has the same syntax, so it should just be a matter of changing the function called. If you want to split by a regular expression, then you would use preg_split.
0
 
Ray PaseurCommented:
str_split() may be your friend in some of these places.
0
 
Terry WoodsIT GuruCommented:
Note that in newer versions of PHP the split function is deprecated in favour of str_split and preg_split. Best not to add new code using split as it may need updating again later.
0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Tackle projects and never again get stuck behind a technical roadblock.
Join Now