Rewriting query for performance

I have a query .
table_1
clientid memberid  denom num
a              x                  1        1
a              y                  1        1
b             z                   0        1

table_2
clientid memberid type
a              x               c
a              y               s
b              z               c

I need to select values where denom=1 and type='c' from the two tables. The denominator value should be sum(denom) where type='c' and denom=1.
denom from table_1 is a flag. I wrote a sub query here. But there are many fields like numerator1,numerator2,etc. So I wrote many subqueries . I dont want to use subqueries here as there is much data. Can anyone suggest me a query which is much efficient than subqueries
select clientid,denominator=(select sum(denom) from table_1 t1
                                      join table_2 t2 on t1.clientid=t2.clientid
                                      where t2.type='C' and denom=1)
from dbo.table_1 t1
join table_2 t2
on t1.clietid=t2.clientid
where t2.type='C'
group by e.lob
himabindu_nvnAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Anthony PerkinsCommented:
Something like this:
SELECT  t1.clientid,
        SUM(t1.denom)
FROM    table_1 t1
        JOIN table_2 t2 ON t1.clientid = t2.clientid
WHERE   t2.type = 'C'
GROUP BY t1.clientid
HAVING  SUM(t1.denom) = 1

Open in new window

0
Olaf DoschkeSoftware DeveloperCommented:
It depends what you need, maybe even simpler

SELECT  t1.clientid,
        SUM(t1.denom) as SumDenom, sum(t1.numerator1) as SumNumerator1,...
FROM    table_1 t1
        INNER JOIN table_2 t2 ON t1.clientid = t2.clientid and t2.type='c'
GROUP BY t1.clientid

Open in new window


I'd recommend you first do a query
SELECT  t1.*
FROM    table_1 t1
        INNER JOIN table_2 t2 ON t1.clientid = t2.clientid and t2.type='c'

Open in new window


and inspect if you want the sums of this query result. If the join condition differs for each of the sums you want to make, there could still be ways of summing on condition using CASE.

I suspect you also want to add t1.memberid = t2.memberid in your join condition, otherwise you sum same records of t1 multiple times. Not with your sample data, but there might be cases you join records of other members also of type 'c'.

Bye, Olaf.
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
Microsoft SQL Server

From novice to tech pro — start learning today.