Solved

should I always declare my variables before assigning

Posted on 2012-03-26
7
265 Views
Last Modified: 2012-08-13
I've always been in the habit of declaring my variables at the top of the page as null and then assigning them, normally inside my try{} or main block of code, something along the lines of the below:
protected void Page_Load(object sender, EventArgs e)
    {
        List<Job> jobs = null;

        if (!Page.IsPostBack)
        {
            jobs = new List<Job>;

            //and so on....
        }
    }

Open in new window


Is that good/bad practice or would I be better off just creating a new list inside my main if.

Is it the case I should only do this if I need the list in scope for my finally block or some code outside of the main if....?
0
Comment
Question by:scm0sml
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
7 Comments
 
LVL 30

Assisted Solution

by:IanTh
IanTh earned 225 total points
ID: 37765086
its always safer to declare the variable before you use it imho
0
 

Author Comment

by:scm0sml
ID: 37765088
so you are saying as I'm doing it in your opinion is correct?
0
 
LVL 37

Accepted Solution

by:
Neil Russell earned 225 total points
ID: 37765104
Yes. Good practice is ALWAYS to pre declare ALL variables before use.
0
Salesforce Made Easy to Use

On-screen guidance at the moment of need enables you & your employees to focus on the core, you can now boost your adoption rates swiftly and simply with one easy tool.

 
LVL 7

Assisted Solution

by:Lalit Chandra
Lalit Chandra earned 50 total points
ID: 37765105
Every declared variable has it scope. the variable that you define outside oof methods, it become global to the class,means its get  of memory every time the class is initiated. and as it is global, there is no any control of their access,and hence any wrong access (updation) is done  by some other method while it being used by any other method.

So,By Standards, its a good habit to limit a variable to a limited scope (method scope) until an unless there is a serious need of declaring Global variables.
0
 

Author Comment

by:scm0sml
ID: 37765106
It's what I've always done but have never been clear whether it was correct or not.

Is there any reason for this as such?
0
 

Author Comment

by:scm0sml
ID: 37765109
Lalit-Chandra I understand scope, I was referring to inside my methods more so....
0
 
LVL 7

Expert Comment

by:Lalit Chandra
ID: 37765123
ok,then you r doing it in a right way.
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In an ASP.NET application, I faced some technical problems. In this article, I list them out and show the solutions that I found.  I hope it will be useful. Problem: After closing a pop-up window, the parent page should be refreshed automaticall…
International Data Corporation (IDC) prognosticates that before the current the year gets over disbursing on IT framework products to be sent in cloud environs will be $37.1B.
Nobody understands Phishing better than an anti-spam company. That’s why we are providing Phishing Awareness Training to our customers. According to a report by Verizon, only 3% of targeted users report malicious emails to management. With compan…
The Email Laundry PDF encryption service allows companies to send confidential encrypted  emails to anybody. The PDF document can also contain attachments that are embedded in the encrypted PDF. The password is randomly generated by The Email Laundr…

733 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question