asked on

For Inside ForEach Only Inserting First Array Value

Hi Experts,

Thanks for reason. The code below works, excepts it only inserts the first array first with $id=1 into the database and then reports a duplicate value for 1 in the database, so it's not getting to 2 or 3. Can you help me identify why?

The database insert code is Zend and is valid. Thanks!

$info = array(
    1 => array( 5, 'Name' ),
    2 => array( 5, 'Name' ),
    3 => array( 3, 'Name 2' )
    );

foreach( $info as $id => $data )
{
    
    for( $id_value_id = 0; $id_value_id < 3; $id_value_id++ )
    {
    
        $data = array(
            'id'            => $id,
            'user_id'       => $data[0],
            'name'          => $data[1],
            );
        
        $db->insert(
            'title',
            $data
            );
        
    }
    
}

Open in new window

Beverley Portlock

You are putting the original array into a variable called $data which you then overwrite in the loop.

foreach( $info as $id => $data )
{
....

$data = array(

SevenAteAnthony

ASKER

Thanks for finding that. I actually messed up when I renamed the variables to place on here to public eyes. Excluding that find, do you see anything else wrong with the idea behind the code why it would loop to the first one and keep looping to the first one until it reports the duplicate error?

gr8gonzo

Is that the actual code or did you modify it at all to show on here?

SevenAteAnthony

ASKER

Actual code. Variable names were modified. Thanks.

gr8gonzo

How heavily modified? More specifically, what were the original variable names on each of the loop lines?

SevenAteAnthony

ASKER

There's nothing wrong with the variables names minus the double $data. They were changed for legality reasons. Please assume the above are the variables names if you're willing to help. Thanks.

Ray Paseur

Variable names that are changed for any reason have no place in the debugging process.

Please do one of the following: (1) Post the actual code, along with the CREATE TABLE statements and enough data to illustrate the issue, so we can copy it and run it on our own servers, of (2) Create a replica that exactly illustrates the problem, and post all of the actual code, CREATE TABLE statements and enough test data to load the tables and illustrate the issue.

Good test data and access to the actual code are kind of the foundation of programming.

Thanks, ~Ray

ASKER CERTIFIED SOLUTION

SevenAteAnthony

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

gr8gonzo

Well, the reason I ask is because I'm trying to figure out why you're looping 3 times with no difference in the data:

for( $id_value_id = 0; $id_value_id < 3; $id_value_id++ )
{
... query in here ...
}

You're running the same query 3 times, so I figured there may have been something changed in the variable names to explain why and maybe the original had something changing. As of right now, the only variable that changes is $id_value_id but it's never used inside your loop.

The simple fact that I'm asking should indicate that I'm willing to help. I'm just trying to figure out the problem.

gr8gonzo

Umm... okay... I don't think it has anything to do with being dramatic. We just don't have any information other than what you give us. Most of us are pretty experienced programmers - we don't really ask for information unless it's relevant to understanding the problem and the solution.

Ray Paseur

Going forward, SevenAteAnthony, you'll get quicker results if you can create a test case that demonstrates the issues. Often you will find that just the act of creating the test case will cause you to think about the issues in ways that will lead you to the solution. The creation of a test case is a useful exercise and one worthy of your time. Changing the variable names or obscuring the data base details is not worthy of your time. In fact, these kinds of changes often introduce more errors into the code. So when you're wondering what you can produce for "public eyes" try your best to isolate the issues and demonstrate them separately. It is only easy to eat an elephant if you do it a bite at a time.

SevenAteAnthony

ASKER

Chosen because I fixed it myself.