Uninstall Windows Service Delphi

I'm using the following code (somewhat simplified) to uninstall a Windows service.

Each time it returns an error of ERROR_INVALID_HANDLE. Is there something wrong with the code? Is there a better way to do it? I know there should be a few more checks and try-finally's but OpenSCManager and OpenService both return valid values whereas DeleteService always returns a False.

var
  schm: SC_Handle;
  dwResult, dwLastError: DWord;
  ss: TServiceStatus;
  bResult: Boolean;
begin
  dwResult := 0;

  schm := OpenSCManager(nil, nil, SC_MANAGER_ALL_ACCESS);
  if schm > 0 then
  begin
    dwResult := OpenService(schm, ServiceName, SERVICE_ALL_ACCESS);    
    bResult := DeleteService(schm);
    if not bResult then
    begin
      dwLastError:= GetLastError;
      if dw = ERROR_ACCESS_DENIED then
        showmessage('ERROR_ACCESS_DENIED')
      else if dw = ERROR_INVALID_HANDLE then
        showmessage('ERROR_INVALID_HANDLE')
      else if dw = ERROR_SERVICE_MARKED_FOR_DELETE then
        showmessage('ERROR_SERVICE_MARKED_FOR_DELETE');
    end;

    CloseServiceHandle(schm);
  end;
end;
ChrisJonesLycosAsked:
Who is Participating?
 
Geert GruwezConnect With a Mentor Oracle dbaCommented:
OpenService returns the handle to the service
you are trying to delete using the handle of the service manager ...

    hService := OpenService(schm, ServiceName, SERVICE_ALL_ACCESS);
    bResult := DeleteService(hService);
0
 
Geert GruwezOracle dbaCommented:
have you tried ?

sc delete servicename

from services.msc, right click on the properties to get the name

you need to run your program as administrator if uac is enabled (vista, win7, win2k8r2)

having services.msc open, may cause a problem too
close and open it to refresh
0
 
ChrisJonesLycosAuthor Commented:
This is something that has to be done in code. I already have the working code for Install, Start, Stop Service  but for some reason can't get the Uninstall to work for the above reasons.
0
Take Control of Web Hosting For Your Clients

As a web developer or IT admin, successfully managing multiple client accounts can be challenging. In this webinar we will look at the tools provided by Media Temple and Plesk to make managing your clients’ hosting easier.

 
rinfoCommented:
I understand you are providing service name - hardcoded or perhaps passed using a parameter.
The reason of you getting handle error is service name as registered is different from service name as assigned by you.
Why dont you enumerate service name and search for service name which you wants to delete.
The following are attributed to christian wimmer and i am quoting it.

You can use file JclSvcCtrl.pas from JEDI Components Library (JCL)
M := TJclSCManager.Create;
For i := 0 to M.Count -1 do
begin
  S := M.Services; // TJclNtService
  if CompareText(S.ServiceName, 'bla') then
  showmessage('service found');
and this will confirm that you are passing proper service name.
Because there definitely is a service name mismatch.
There is another function in this component
m.findservice(servicename);
you can use either to confirm.
0
 
rinfoCommented:
Actually it is
for cnt := 0 to M.count- 1 do
begin
  S:= M.services[cnt];
0
 
ChrisJonesLycosAuthor Commented:
The service name is the same as the one I'm using in Install, Start and Stop Service functions and these all work fine. Why would it not be the right name for Uninstall?
0
 
ChrisJonesLycosAuthor Commented:
Brilliant! That works.
0
All Courses

From novice to tech pro — start learning today.