• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 400
  • Last Modified:

Excel Macro - "Do until last row is reached...

I would like to create a generic macro that identifies the last row in a column, and saves that number to repeat another recorded macro until that number is reached.  For instance, if there were 709 rows identified by something like

Range("1000000").End(x1Up).Select where ActiveCell.Row = 709, how could I save the 709 and then perform another macro I embed within this code until 709 is reached?  Does this make sense?
0
tomfarrar
Asked:
tomfarrar
  • 5
  • 4
  • 3
  • +1
1 Solution
 
Saqib Husain, SyedEngineerCommented:
You need to provide a column letter as well
x1up should be xlup

lr = Range("A1000000").End(xlUp).row
0
 
tomfarrarAuthor Commented:
Thanks, I apparently didn't do a good job in defining the right code, but I am open to how this is done.  In your example, if "lr" is equal to 709, how do I save that number and have another macro run 709 times?
0
 
Saqib Husain, SyedEngineerCommented:
You can define the variable lr as a global variable like

public dim lr as long

This should go at the top of the module before any other sub
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
Martin LissRetired ProgrammerCommented:
Change the column to whatever column you are interested and this will give you 709


Dim r As Range

Set r = Range("A1").End(xlDown).Offset(0, 0)
MsgBox r.Row
0
 
Martin LissRetired ProgrammerCommented:
And using ssaqibh's lr

lr = r.Row
0
 
Saqib Husain, SyedEngineerCommented:
Alternatively you can also store the value in a predefined cell of a worksheet and then directly pick it from there.
0
 
kgerbChief EngineerCommented:
If you don't know what column will contain the last row you can use the following.  It will return the last row of data regardless of which column it is in.
Sub FindLastRow()
Dim lRow As Long
lRow = Cells.Find("*", [A1], xlValues, xlWhole, xlByRows, xlPrevious).Row
End Sub

Open in new window

Kyle
0
 
tomfarrarAuthor Commented:
Okay a lot of thoughts here.  Maybe the question is now, what changes do I need to make to this code to ensure "MyMacroPerformedOnEachRow" is performed as many times as there is rows...  I know the code doesn't work now.  Thanks.

Sub IdentifyLastRow()

Dim x As Integer

Range("A1000000").End(xlUp).Select
x = ActiveCell.Row
Do Until ActiveCell = x

"MyMacroPerformedOnEachRow"

Loop

End Sub
0
 
Saqib Husain, SyedEngineerCommented:
You can try

for each cel in Range("A1:A" & rows.count).end(xlup)

"perform your code here using cel as a range which takes one cell at a time from A1:An"

next cel
0
 
kgerbChief EngineerCommented:
This sub will call your macro for each row from the active row to the last row.
Sub IdentifyLastRow()
Dim x As Long
For x = ActiveCell.Row To Cells.Find("*", [A1], xlValues, xlWhole, xlByRows, xlPrevious).Row
    Call MyMacroPerformedOnEachRow
Next x
End Sub

Open in new window

Kyle
0
 
Saqib Husain, SyedEngineerCommented:
Sorry change the first line of code in my last comment to

for each cel in Range("A1:A" & range("A" & rows.count).end(xlup).row)
0
 
tomfarrarAuthor Commented:
Hi Guys - Thanks for the help.  Both codes work, though ssaqibh code does not stop when the last row is reached.  It appears to go through all million + rows in the sheet.  Kyle's, on the other hand, stops when the last row is reached.
0
 
tomfarrarAuthor Commented:
Thank you for helping me on my question, Kyle.  I hope to continue to better understand VBA so that I can do more solutions on my own.  - Tom
0
 
kgerbChief EngineerCommented:
You're welcome.  Glad to help.  If you need further explanation on anything we come up with just ask.  Most of us are always happy to provide additional detail.

Kyle
0

Featured Post

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

  • 5
  • 4
  • 3
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now