Solved

Excel Macro - "Do until last row is reached...

Posted on 2012-03-29
14
386 Views
Last Modified: 2013-01-12
I would like to create a generic macro that identifies the last row in a column, and saves that number to repeat another recorded macro until that number is reached.  For instance, if there were 709 rows identified by something like

Range("1000000").End(x1Up).Select where ActiveCell.Row = 709, how could I save the 709 and then perform another macro I embed within this code until 709 is reached?  Does this make sense?
0
Comment
Question by:tomfarrar
  • 5
  • 4
  • 3
  • +1
14 Comments
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
Comment Utility
You need to provide a column letter as well
x1up should be xlup

lr = Range("A1000000").End(xlUp).row
0
 
LVL 7

Author Comment

by:tomfarrar
Comment Utility
Thanks, I apparently didn't do a good job in defining the right code, but I am open to how this is done.  In your example, if "lr" is equal to 709, how do I save that number and have another macro run 709 times?
0
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
Comment Utility
You can define the variable lr as a global variable like

public dim lr as long

This should go at the top of the module before any other sub
0
 
LVL 45

Expert Comment

by:Martin Liss
Comment Utility
Change the column to whatever column you are interested and this will give you 709


Dim r As Range

Set r = Range("A1").End(xlDown).Offset(0, 0)
MsgBox r.Row
0
 
LVL 45

Expert Comment

by:Martin Liss
Comment Utility
And using ssaqibh's lr

lr = r.Row
0
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
Comment Utility
Alternatively you can also store the value in a predefined cell of a worksheet and then directly pick it from there.
0
 
LVL 12

Accepted Solution

by:
kgerb earned 500 total points
Comment Utility
If you don't know what column will contain the last row you can use the following.  It will return the last row of data regardless of which column it is in.
Sub FindLastRow()
Dim lRow As Long
lRow = Cells.Find("*", [A1], xlValues, xlWhole, xlByRows, xlPrevious).Row
End Sub

Open in new window

Kyle
0
Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

 
LVL 7

Author Comment

by:tomfarrar
Comment Utility
Okay a lot of thoughts here.  Maybe the question is now, what changes do I need to make to this code to ensure "MyMacroPerformedOnEachRow" is performed as many times as there is rows...  I know the code doesn't work now.  Thanks.

Sub IdentifyLastRow()

Dim x As Integer

Range("A1000000").End(xlUp).Select
x = ActiveCell.Row
Do Until ActiveCell = x

"MyMacroPerformedOnEachRow"

Loop

End Sub
0
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
Comment Utility
You can try

for each cel in Range("A1:A" & rows.count).end(xlup)

"perform your code here using cel as a range which takes one cell at a time from A1:An"

next cel
0
 
LVL 12

Expert Comment

by:kgerb
Comment Utility
This sub will call your macro for each row from the active row to the last row.
Sub IdentifyLastRow()
Dim x As Long
For x = ActiveCell.Row To Cells.Find("*", [A1], xlValues, xlWhole, xlByRows, xlPrevious).Row
    Call MyMacroPerformedOnEachRow
Next x
End Sub

Open in new window

Kyle
0
 
LVL 43

Expert Comment

by:Saqib Husain, Syed
Comment Utility
Sorry change the first line of code in my last comment to

for each cel in Range("A1:A" & range("A" & rows.count).end(xlup).row)
0
 
LVL 7

Author Comment

by:tomfarrar
Comment Utility
Hi Guys - Thanks for the help.  Both codes work, though ssaqibh code does not stop when the last row is reached.  It appears to go through all million + rows in the sheet.  Kyle's, on the other hand, stops when the last row is reached.
0
 
LVL 7

Author Closing Comment

by:tomfarrar
Comment Utility
Thank you for helping me on my question, Kyle.  I hope to continue to better understand VBA so that I can do more solutions on my own.  - Tom
0
 
LVL 12

Expert Comment

by:kgerb
Comment Utility
You're welcome.  Glad to help.  If you need further explanation on anything we come up with just ask.  Most of us are always happy to provide additional detail.

Kyle
0

Featured Post

IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

Join & Write a Comment

Introduction While answering a recent question (http:/Q_27311462.html), I created an alternative function to the Excel Concatenate() function that you might find useful.  I tested several solutions and share the results in this article as well as t…
Workbook link problems after copying tabs to a new workbook? David Miller (dlmille) Intro Have you either copied sheets to a new workbook, and after having saved and opened that workbook, you find that there are links back to the original sou…
This Micro Tutorial will demonstrate in Microsoft Excel how to add style and sexy appeal to horizontal bar charts.
This Micro Tutorial will demonstrate how to create pivot charts out of a data set. I also added a drop-down menu which allows to choose from different categories in the data set and the chart will automatically update.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now