C++ code in Gauss Jordan Matrix reverse

I have found a few on the net but i dont want to just copy them.
Here is part of my code.
What am i missing ?
HWK6.txt
c_hocklandAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Infinity08Commented:
>> What am i missing ?

An explanation of what problem you're having, and what you need our help with ;)
0
c_hocklandAuthor Commented:
i need to use the Gauss Jordan method to find the inverse of a matrix nxn dimensions.
0
ambienceCommented:
Your choice of languages for the question is pretty intetersting. Few points

- Inverse is only possible for a square matrix so there is no need to read dimensions as row, col. This will simplify logic.
- I would suggest building a c++ abstraction say Matrix to handle matrices easily. A quick search took me here and looks like a good starting point. Use the Matrix class from here

http://stackoverflow.com/questions/2286991/c-two-dimensional-stdvector-best-practices

>> What am i missing ?

1) The identity matrix to start with.
2) You should use double for algorithms involving mathematical operations like divisions, otherwise chances are you'd get zeroed out results because of truncations.
3) I would suggest to simplify things by writing basic matrix operations needed for guass jordan method. In other words, build a DSL (domain specific language)

Whereever you are performing operations on A you should also be performing identical operation on I (identity matrix).

				 for (i=0 ; i < n  ; i++ )
				 {
						double buffer = A[i][i];
						for  (j=1 ; j < n ; j++ )
						{
							A[i][j] /= buffer ;
							I[i][j] /= buffer ;
						}
				 }

Open in new window


However, there are so many other issues with the code that I think I'll suffice with these for now and hopefully in a few iterations we can fix all.
0
Become a Certified Penetration Testing Engineer

This CPTE Certified Penetration Testing Engineer course covers everything you need to know about becoming a Certified Penetration Testing Engineer. Career Path: Professional roles include Ethical Hackers, Security Consultants, System Administrators, and Chief Security Officers.

ambienceCommented:
This was an interesting problem and I rolled out a quick example of what I was saying using the Matrix class from the link. This is minimalistic and only sets up the basics and does not take into account error conditions. You can fatten the solver class. Hope this helps ...

#include "stdafx.h"
#include <assert.h>
#include <algorithm>
#include <memory>
#include <vector>
#include <iostream>

template<class T, class A=std::allocator<T> >
struct Matrix {
	typedef T value_type;
	typedef std::vector<value_type, A> Container;

	Matrix() : _b(0) {}
	Matrix(int rows, int cols, value_type const& initial=value_type())
		: _b(0)
	{
		resize(rows, cols, initial);
	}
	Matrix(Matrix const& other)
		: _data(other._data), _b(other._b)
	{}

	Matrix& operator=(Matrix copy) {
		swap(*this, copy);
		return *this;
	}

	bool empty() const { return _data.empty(); }
	void clear() { _data.clear(); _b = 0; }

	int numRows() const { return _b ? _data.size() / _b : 0; }
	int numCols() const { return _b; }

	bool rowIsNull(int row) {
		for(int i=0; i<numCols(); i++)
			if(_data[row * _b + i] != 0)
				return false;
		return true;
	}

	bool colIsNull(int col) {
		for(int i=0; i<numRows(); i++)
			if(_data[i * _b + col] != 0)
				return false;
		return true;
	}

	value_type& operator()(int i) {
		return _data[i];
	}

	const value_type& operator()(int i) const {
		return _data[i];
	}

	value_type& operator()(int row, int col) {
		return _data[row * _b + col];
	}

	const value_type& operator()(int row, int col) const {
		return _data[row * _b + col];
	}

	void resize(int a, int b, value_type const& initial=value_type()) {
		if (a == 0) {
			b = 0;
		}
		_data.resize(a * b, initial);
		_b = b;
	}

	friend void swap(Matrix& a, Matrix& b) {
		using std::swap;
		swap(a._data, b._data);
		swap(a._b,    b._b);
	}

	std::ostream& print(std::ostream& s) 
	{
		s << "<Matrix" << numRows() << 'x' << numCols();
		if (!empty()) 
		{
			bool first = true;
			typedef typename Container::const_iterator Iter;
			Iter i = _data.begin(), end = _data.end();
			while (i != end) 
			{
				s << (first ? " [[" : "], [");
				first = false;
				s << *i;
				++i;
				for (int b = _b - 1; b; --b) {
					s << ", " << *i;
					++i;
				}
			}
			s << "]]";
		}
		s << '>' << std::endl;
		return s;
	}

private:
	Container _data;
	int _b;
};


template <class M>
struct MatrixBuilder
{
	typedef typename M::value_type value_type;
	typedef M return_type;

	MatrixBuilder(int a) :_m(a, a) {
	}

	MatrixBuilder(int a, int b) :_m(a, b) {
	}

	MatrixBuilder(const M& m) :_m(m) {
	}

	MatrixBuilder& zero() {
		_m = M(_m.numRows(), _m.numCols(), value_type(0));
		return *this;
	}


	MatrixBuilder& random() {
		_m = M(_m.numRows(), _m.numCols(), value_type(0));
		for(int i=0;i<_m.numRows();i++)
		for(int j=0;j<_m.numCols();j++)
			_m(i,j) = rand();
		return *this;
	}

	MatrixBuilder& identity() {
		assert(_m.numRows() == _m.numCols());
		_m = M(_m.numRows(), _m.numCols(), value_type(0));
		for(int i=0;i<_m.numRows();i++) {
			_m(i,i) = 1;
		}
		return *this;
	}

	MatrixBuilder& addToRow(int row, value_type v) {
		assert(!_m.empty());
		assert(row <= _m.numRows());
		for(int i=0;i<_m.numCols();i++) {
			_m(row, i) += v;
		}
		return *this;
	}

	MatrixBuilder& addToColumn(int col, value_type v) {
		assert(!_m.empty());
		assert(col <= _m.numCols());
		for(int i=0;i<_m.numRows();i++) {
			_m(i, col) += v;
		}
		return *this;
	}

	MatrixBuilder& multiplyRowBy(int row, value_type v) {
		assert(!_m.empty());
		assert(row <= _m.numRows());
		for(int i=0;i<_m.numCols();i++) {
			_m(row, i) *= v;
		}
		return *this;
	}

	MatrixBuilder& multiplyColumnBy(int col, value_type v) {
		assert(!_m.empty());
		assert(col <= _m.numCols());
		for(int i=0;i<_m.numRows();i++) {
			_m(i, col) *= v;
		}
		return *this;
	}

	MatrixBuilder& divideRowBy(int row, value_type v) {
		assert(!_m.empty());
		assert(row <= _m.numRows());
		for(int i=0;i<_m.numCols();i++) {
			_m(row, i) /= v;
		}
		return *this;
	}

	MatrixBuilder& divideColumnBy(int col, value_type v) {
		assert(!_m.empty());
		assert(col <= _m.numCols());
		for(int i=0;i<_m.numRows();i++) {
			_m(i, col) /= v;
		}
		return *this;
	}

	MatrixBuilder& swapRows(int row1, int row2) {
		assert(!_m.empty());
		assert(row1 <= _m.numRows());
		assert(row2 <= _m.numRows());

		for(int i=0;i<_m.numCols();i++) {
			std::swap( _m(row1, i), _m(row2, i) );
		}
		return *this;
	}

	MatrixBuilder& swapColumns(int col1, int col2) {
		assert(!_m.empty());
		assert(col1 <= _m.numCols());
		assert(col2 <= _m.numCols());

		for(int i=0;i<_m.numRows();i++) {
			std::swap( _m(i, col1), _m(i, col2) );
		}
		return *this;
	}

	MatrixBuilder& addRowElements(int row1, int row2, value_type multiplier) {
		assert(!_m.empty());
		assert(row1 <= _m.numRows());
		assert(row2 <= _m.numRows());

		for(int i=0;i<_m.numCols();i++) {
			_m(row1, i) += _m(row2, i) * multiplier;
		}
		return *this;
	}

	MatrixBuilder& subRowElements(int row1, int row2, value_type multiplier) {
		assert(!_m.empty());
		assert(row1 <= _m.numRows());
		assert(row2 <= _m.numRows());

		for(int i=0;i<_m.numCols();i++) {
			_m(row1, i) -= _m(row2, i) * multiplier;
		}
		return *this;
	}

	M result() const  {
		return _m;
	}

private:
	M _m;
};


template <class M>
struct GuassJordanSolver
{
	typedef typename M::value_type value_type;
	typedef M return_type;

	GuassJordanSolver(const M& m) :_m(m), _b(m), _i(m.numRows()) {
		assert(!_m.empty());
		assert(_m.numRows() == _m.numCols());
		_i.identity();
	}

	bool solve()
	{
		for(int i=0; i<_m.numCols(); i++)
		{
			value_type v = _b.result()(i, i);

			// Interchange rows to bring a non-zero element, only look for rows greater than current
			if(v == 0 && !fixNullPivot(i, i))
			{
				return false;
			}

			v = _b.result()(i, i);
			_b.divideRowBy(i, v);
			_i.divideRowBy(i, v);

			_b.result().print(std::cout);

			for(int j=0; j<_m.numRows(); j++)
			{
				if(i == j) continue;

				v = _b.result()(j, i);

				if(v == 0) continue;

				_b.subRowElements(j, i, v);
				_i.subRowElements(j, i, v);

				_b.result().print(std::cout);
			}

		}

		return true;
	}

	M original() const  {
		return _m;
	}
	
	M transformed() const  {
		return _b.result();
	}

	M inverse() const  {
		return _i.result();
	}

private:
	bool fixNullPivot(int r, int c)
	{
		for(int i = r+1; i<_m.numRows(); i++)
		{
			if(_b.result()(i, c) != 0)
			{
				_b.swapRows(r, i);
				_i.swapRows(r, i);
				_b.result().print(std::cout);
				return true;
			}
		}
		return false;
	}

private:
	M _m;
	MatrixBuilder<return_type> _b;
	MatrixBuilder<return_type> _i;
};



Matrix<double> fromData() 
{
	Matrix<double> _m = Matrix<double>(3, 3, 0);
	_m(0, 0) = 0;
	_m(0, 1) = -2;
	_m(0, 2) = 3;

	_m(1, 0) = 2;
	_m(1, 1) = 0;
	_m(1, 2) = 6;

	_m(2, 0) = 3;
	_m(2, 1) = 5;
	_m(2, 2) = 0;
	return _m;
}

int _tmain(int argc, _TCHAR* argv[])
{
	MatrixBuilder<Matrix<double>> b(3);
	GuassJordanSolver<Matrix<double>> s(fromData());

	s.solve();
	s.original().print(std::cout);
	s.transformed().print(std::cout);
	s.inverse().print(std::cout);

	return 0;
}

Open in new window

0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
c_hocklandAuthor Commented:
thnks for the quick input. We are not supposed to use classes. Only matrices and functions if needed. Let me try the code you sent me...
0
ambienceCommented:
In that case it shouldnt be that difficult to convert c++ code into equivalent c code, just pass matrix as first parameter in all methods and make them functions.
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
C++

From novice to tech pro — start learning today.