Please critique my work!

Greetings,

I've included the code for a "box test" I was given by someone to test my abilities and how I do things with regards to structure and style.  They sent me a .png (attached) and asked me to create it using HTML and CSS.  

Incidentally, while the png shows each box with a letter designation, I did not include that figuring it was beside the point of the exercise i.e. they wanted to see how I deal with creating a table-less layout.  Perhaps that was a mistake in judgement?

I would ask any experts to inspect my work and critique what I've done.  Please be specific about where I could have done something perhaps better and I also want to know if I did something that was a no-no or even egregiously wrong by today's standards.

Tell me the truth but, be nice! :)

<!DOCTYPE html>
<html lang="en">
	<head>
		<meta charset="utf-8" />
		<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />
		<title>Box Test</title>
		<meta name="description" content="Box Test" />
		<style>
			#wrapper {
				width: 900px;
				height: auto;
			}
			#boxA, #two_box {
				border: 1px solid #000;
			}
			
			#boxB, #boxC {
				border-bottom: 1px solid #000;
			}
			
			#boxA, #two_box {
				width: 450px;
			}
			
			#boxA, #boxD, #two_box {
				height: 300px;
			}
			
			#boxA {
				background: #f4cccc;
			}
			#boxB {
				background: #b6d7a8;
				height: 150px;
			}
			#boxC {
				background: #cfe2f3;
				height: 149px;
			}
			#boxD {
				background: #ffe599;
				border: solid #000;
				border-width: 0 1px 1px 1px;
			}
			#two_box {
				float: right;
				margin-top: -302px;
			}
		</style>
	</head>
	<body>
		<div>
			<header>
				<h1>Box Test</h1>
			</header>
			<div id="wrapper">
				<div id="boxA"></div>
				<div id="two_box">
					<div id="boxB"></div>
					<div id="boxC"></div>
				</div>
				<div id="boxD"></div>
			</div>
			<footer></footer>
		</div>
	</body>
</html>

Open in new window


thanks,
LVL 1
max7Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

max7Author Commented:
sorry, it seems I did not attach the original png for this.
boxTest.png
0
n2fcCommented:
Good job!  Neatly organized and very readable code...
0
Daniel Van Der WerkenIndependent ConsultantCommented:
I would get rid of the unused <footer> tag. Unless it's necessary, which I doubt.
It looks like you friend wants the box and the text centered.
Also, I changed the width of the two smaller boxes to 50% instead of 450px.

Here's the modified code I came up with:

<!DOCTYPE html>
<html lang="en">
      <head>
            <meta charset="utf-8" />
            <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />
            <title>Box Test</title>
            <meta name="description" content="Box Test" />
            <style>
                  #outer {
                        width: 100%;
                  }
                  #wrapper {
                        width: 90%;
                        height: auto;
                        margin: 0px auto;
                  }
                  #boxA, #two_box {
                        border: 1px solid #000;
                  }
                  
                  #boxB, #boxC {
                        border-bottom: 1px solid #000;
                  }
                  
                  #boxA, #two_box {
                        width: 50%;
                  }
                  
                  #boxA, #boxD, #two_box {
                        height: 300px;
                  }
                  
                  #boxA {
                        background: #f4cccc;
                  }
                  #boxB {
                        background: #b6d7a8;
                        height: 150px;
                  }
                  #boxC {
                        background: #cfe2f3;
                        height: 149px;
                  }
                  #boxD {
                        background: #ffe599;
                        border: solid #000;
                        border-width: 0 1px 1px 1px;
                  }
                  #two_box {
                        float: right;
                        margin-top: -302px;
                  }
                  #boxtest {
                        text-align: center;
                  }
            </style>
      </head>
      <body>
            <div>
                  <header>
                        <h1 id="boxtest">HTML/CSS Box Test</h1>
                  </header>
                  <div id="outer">
                        <div id="wrapper">
                              <div id="boxA"></div>
                              <div id="two_box">
                                    <div id="boxB"></div>
                                    <div id="boxC"></div>
                              </div>
                              <div id="boxD"></div>
                        </div>
                  </div>
            </div>
      </body>
</html>
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Ultimate Tool Kit for Technology Solution Provider

Broken down into practical pointers and step-by-step instructions, the IT Service Excellence Tool Kit delivers expert advice for technology solution providers. Get your free copy now.

max7Author Commented:
I would get rid of the unused <footer> tag. Unless it's necessary, which I doubt.

Yes, I noticed that as well.  Does it look terribly bad to have that hanging around unused?

It looks like you friend wants the box and the text centered.

Not sure what you mean by wanting the box centered.  Could you expand on that?

Regarding the text, are you indicating you think it was a mistake NOT to include it?

Also, I changed the width of the two smaller boxes to 50% instead of 450px.

Is there a particular advantage to using % for width instead of px?  Is it a poor choice to use pixel instead of % here?

Keeping the issues you mentioned in mind, overall, do you think the work here is decent?  Can you give it a grade e.g. A through F?
0
EirmanChief Operations ManagerCommented:
> Is there a particular advantage to using % for width instead of px?

% is better becase it displays much better/consistently on different monitor sizes, aspect ratios and resolutions.
0
max7Author Commented:
Not sure what you mean by wanting the box centered.  Could you expand on that?

ok, I feel foolish.  I wasn't carefully reviewing your code changes but I now see the outer div and how you centered the wrapper div within it. Doh!

% is better becase it displays much better/consistently on different monitor sizes, aspect ratios and resolutions.

Excellent, thanks for that.

Still hoping for an over-all assessment of this work.
0
Daniel Van Der WerkenIndependent ConsultantCommented:
Grade A- because of the centering and sizing. Plus I think you should put in the letters A B C D like the image has.
0
max7Author Commented:
Thanks very much for the feedback, greatly appreciate it!
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
CSS

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.