asked on

Please critique my work!

Greetings,

I've included the code for a "box test" I was given by someone to test my abilities and how I do things with regards to structure and style. They sent me a .png (attached) and asked me to create it using HTML and CSS.

Incidentally, while the png shows each box with a letter designation, I did not include that figuring it was beside the point of the exercise i.e. they wanted to see how I deal with creating a table-less layout. Perhaps that was a mistake in judgement?

I would ask any experts to inspect my work and critique what I've done. Please be specific about where I could have done something perhaps better and I also want to know if I did something that was a no-no or even egregiously wrong by today's standards.

Tell me the truth but, be nice! :)

<!DOCTYPE html>
<html lang="en">
	<head>
		<meta charset="utf-8" />
		<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1" />
		<title>Box Test</title>
		<meta name="description" content="Box Test" />
		<style>
			#wrapper {
				width: 900px;
				height: auto;
			}
			#boxA, #two_box {
				border: 1px solid #000;
			}
			
			#boxB, #boxC {
				border-bottom: 1px solid #000;
			}
			
			#boxA, #two_box {
				width: 450px;
			}
			
			#boxA, #boxD, #two_box {
				height: 300px;
			}
			
			#boxA {
				background: #f4cccc;
			}
			#boxB {
				background: #b6d7a8;
				height: 150px;
			}
			#boxC {
				background: #cfe2f3;
				height: 149px;
			}
			#boxD {
				background: #ffe599;
				border: solid #000;
				border-width: 0 1px 1px 1px;
			}
			#two_box {
				float: right;
				margin-top: -302px;
			}
		</style>
	</head>
	<body>
		<div>
			<header>
				<h1>Box Test</h1>
			</header>
			<div id="wrapper">
				<div id="boxA"></div>
				<div id="two_box">
					<div id="boxB"></div>
					<div id="boxC"></div>
				</div>
				<div id="boxD"></div>
			</div>
			<footer></footer>
		</div>
	</body>
</html>

Open in new window

thanks,

max7

ASKER

sorry, it seems I did not attach the original png for this.
boxTest.png

n2fc

Good job! Neatly organized and very readable code...

ASKER CERTIFIED SOLUTION

Daniel Van Der Werken

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

max7

ASKER

I would get rid of the unused <footer> tag. Unless it's necessary, which I doubt.

Yes, I noticed that as well. Does it look terribly bad to have that hanging around unused?

It looks like you friend wants the box and the text centered.

Not sure what you mean by wanting the box centered. Could you expand on that?

Regarding the text, are you indicating you think it was a mistake NOT to include it?

Also, I changed the width of the two smaller boxes to 50% instead of 450px.

Is there a particular advantage to using % for width instead of px? Is it a poor choice to use pixel instead of % here?

Keeping the issues you mentioned in mind, overall, do you think the work here is decent? Can you give it a grade e.g. A through F?

SOLUTION

Eirman

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

max7

ASKER

Not sure what you mean by wanting the box centered. Could you expand on that?

ok, I feel foolish. I wasn't carefully reviewing your code changes but I now see the outer div and how you centered the wrapper div within it. Doh!

% is better becase it displays much better/consistently on different monitor sizes, aspect ratios and resolutions.

Excellent, thanks for that.

Still hoping for an over-all assessment of this work.

Daniel Van Der Werken

Grade A- because of the centering and sizing. Plus I think you should put in the letters A B C D like the image has.

max7

ASKER

Thanks very much for the feedback, greatly appreciate it!