Calculation using input from text file

Good evening -
I am having some difficulty with a field that is being read from a text input file.   I need to determine if the value is an odd number.   However, when I try to calculate using the field I get sharing violations.   I've even moved it to another integer field, but I get lvalue errors.   Here's the code snippet below.   Am I using a pointer incorrectly here?

while ((fscanf(fpNumbr, "%d", &numbIn)) == 1)
{      
      oddno = fscanf(fpNumbr, "%d", numbIn);
      if (oddno % 2 == 0)
      printf("*");
      else
      printf("%d", oddno);
}
mojeauxAsked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
Anthony2000Connect With a Mentor Commented:
I think what you need to do is read a single character at a time, determine if it represent a number between 0-9, and then determine if it is odd or even. Be careful to skip over carriage returns and line feedcharacters.
0
 
Anthony2000Commented:
The problem is that fscanf's return value is not the value you need to test against. Your scanned value will be in numbIn and not in oddno as written.

int oddno;
while ((fscanf(fpNumbr, "%d", &oddno)) == 1)
{      
      if (oddno % 2 == 0)
         printf("*");
      else
         printf("%d", oddno);
}
0
 
Anthony2000Commented:
I just removed the extra parenthesis.

int oddno;
while (fscanf(fpNumbr, "%d", &oddno) == 1)
{      
      if (oddno % 2 == 0)
         printf("*");
      else
         printf("%d", oddno);
}
0
What Kind of Coding Program is Right for You?

There are many ways to learn to code these days. From coding bootcamps like Flatiron School to online courses to totally free beginner resources. The best way to learn to code depends on many factors, but the most important one is you. See what course is best for you.

 
Kent OlsenData Warehouse Architect / DBACommented:
Hi Mo,

The while() loop continues to grab consecutive integers from the input stream.  In fact, it can grab only one because the character that terminates the number isn't skipped.  When the fscanf() function is called again, it starts with the character that ended the previous conversion, so it reads no values.

You need to skip all of the non-digit items (space, newline, etc.) before calling fscanf again.


Kent
0
 
Anthony2000Commented:
I didn't include all the original code, but here is part that reads and determines whether the number is odd/even.

I ran the modified code and here is what the output looked like:

code:

                  int oddno;
                  while (fscanf(fpNumbr, "%d", &oddno) == 1)
                  {      
                          printf("%d", oddno); // I added to see what came back from fscanf
                          if (oddno % 2 == 0)
                               printf("*\n");
                          else
                               printf("%d\n", oddno);
                  }


output:
.
.
.
Press any key to continue . . .
123456789123456789
12345678*
12345671234567
123456*
1234512345
1234*
123123
12*
11
0
 
Anthony2000Commented:
Hi Kent,

I thought fscanf worked as you stated, but it appears to be skipping the newlines?

Anthony
0
 
mojeauxAuthor Commented:
Hi Anthony -
Here's the full function... i've commented out some sections because I'm testing.  
void oddNumb(FILE *fpNumbr, int *numbIn)
{

/* LOCAL DECLARATIONS */

int oddno;

/* STATEMENTS */

while ((fscanf(fpNumbr, "%d", &numbIn)) == 1)
{      
      /*fscanf(fpNumbr, "%d", numbIn);
      if (oddno % 2 == 0)
      printf("*");
      else*/
      printf("%d", numbIn);
      printf("*");
}  

return;
}/*disyplays odd numbers from text file*/

Right now the ouptput displays the following:
123456789*12345678*1234567*123456*12345*1234*123*12*1

However, the display should be:
1*3*5*7*9 new line
1*3*5*7* new line
1*3*5*7new line
1*3*5* new line
1*3*5 new line
1*3* new line
1*3 new line
1* new line
1 new line

I'm reading from a text file that looks like
123456789
12345678
1234567
123456
12345
1234
123
12
1

Hi Kent - I read your comments and I'm not sure how to eliminate the new lines from being read by the fscanf statement.   Should I check for " "?  Is this what the program sees when it reads from the text file?

Thanks!!
0
 
Anthony2000Commented:
Ok, i see.

Here is what i think you need to understand. Fscanf is is reading the numbers not one character at a time but rather one number such as 123456789, 12345678, etc. Then it converts from ASCII to a integer representation of the numeruc characters. Do youunderstand?
0
 
phoffricCommented:
>> I get sharing violations
>> oddno = fscanf(fpNumbr, "%d", numbIn);
>> Am I using a pointer incorrectly here?

No. You need &numbIn to make numbIn a pointer to an int.
0
 
mojeauxAuthor Commented:
Hi Anthony -  thanks for the clarification.   I understand how the fscanf is working now.  

Would it be easier if I wrote to the text file, placing a space between each number?  Would the fscan then recognize each interger?   Or would I then have to identify the spaces like Kent mentioned earlier?
0
 
mojeauxAuthor Commented:
I see your last post and it answered my question.  Thanks!
0
 
mojeauxAuthor Commented:
Appreciate the help tonight.   Hopefully I can get this wrapped up soon.   =)
0
 
Anthony2000Commented:
That sounds like an easy adjustment to try. I think adding a space will work.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.