?
Solved

Optimizing query ,sybase

Posted on 2012-04-04
5
Medium Priority
?
499 Views
Last Modified: 2012-04-12
Is there a better way to right this query which increase optimization?

select table1.id 'MCN'
      ,table1.LastName+', '+table1.FirstName 'Name'
      ,PTList.noteDate 'LastDocumented'
      ,table1.patientid
      ,(
      select DisplayValue from table3
            where selectionvalueid = table1.gender
       ) 'Gender'
       
     ,table1.dateofbirth
     
     ,PTLIST.notepadid
     
     ,PTLIST.note
 from
       
       (
           select distinct table2.patientid, notepadid, noteDate, note
         
           from  table2
           
           inner join table5
              on table5.PatientId = table2.patientid
             
           inner join table4
              on table4.TxEventId = table5.TxEventId
             
           where closedDate is null
             and noteType = (
                               select selectionvalueid from  table3
                              where code = 'NoteType_Pending'
                             )
                             
             and    
             
             case --Calculate coordinator id based on whether or not the transplant has occurred
                     when table4.TxDate is null
                     then table4.PreTxCoordinator
                            else table4.PostTxCoordinator
                        end  =   {0}       --Parameter              
        )
        PTList
0
Comment
Question by:rbhargaw
  • 2
  • 2
5 Comments
 
LVL 14

Expert Comment

by:Jan Franek
ID: 37809822
Can you post structure of your tables, indexes and number of rows in tables ?

And it seems like your query is not complete - you use table1 in the first part, but there is no table1 in FROM clause.
0
 
LVL 24

Accepted Solution

by:
Joe Woodhouse earned 2000 total points
ID: 37811946
I am suspicious of the distinct in the derived table. Why is it there? Why use a derived table at all? You don't join to it in any way. Flatten everything in it to the outermost query. If you need the distinct to eliminate duplicates, you haven't put enough joins and/or WHERE clauses in.

Likewise I don't see any reason why your correlated subquery on table3 couldn't be written as a regular join.
0
 

Author Comment

by:rbhargaw
ID: 37812442
Thanks Joe, I will remove the derived table,  how to deal with the case statement?
0
 
LVL 24

Expert Comment

by:Joe Woodhouse
ID: 37814706
I don't think you can change the CASE, but I don't think you need to, CASE isn't expensive.
0
 

Author Closing Comment

by:rbhargaw
ID: 37838700
Not enough joins in the table and hence working on that. The answers points to right direction
0

Featured Post

Keep up with what's happening at Experts Exchange!

Sign up to receive Decoded, a new monthly digest with product updates, feature release info, continuing education opportunities, and more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

An alternative to the "For XML" way of pivoting and concatenating result sets into strings, and an easy introduction to "common table expressions" (CTEs). Being someone who is always looking for alternatives to "work your data", I came across this …
When trying to connect from SSMS v17.x to a SQL Server Integration Services 2016 instance or previous version, you get the error “Connecting to the Integration Services service on the computer failed with the following error: 'The specified service …
Using examples as well as descriptions, and references to Books Online, show the documentation available for date manipulation functions and by using a select few of these functions, show how date based data can be manipulated with these functions.
Via a live example, show how to extract information from SQL Server on Database, Connection and Server properties
Suggested Courses

809 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question