Improve company productivity with a Business Account.Sign Up

Status: Solved
Priority: Medium
Security: Public
Views: 284
Last Modified: 2012-06-27

Nested Loop nightmare

Hi again.

I have now the next mind boggling task in front o me and it comes in nested while loops. Explanation:

A customer performs a search on my products and gets shown his search result. On the search result page,
I displaya list of products through a while loop.

Now, I have another table that contains thats basically holds info in what subcategory each product is.
1 product might be listed in 2 or 3 categories etc. I would like to be able to show this to the customer.

Example.

Product 1
Product 1 Description, price etc
Listed in: Sub-catA, Sub-catB

Product 2
Product 2 Description, price etc
Listed in: Sub-catC, Sub-catE

etc.

My current code looks like this:

<?php
#
$searchSQL = "SELECT *,MATCH(pdescription, pname, pintro, psku) AGAINST ('{$searchTermDB}') as Relevance FROM products WHERE 
MATCH(pdescription, pname, pintro, psku) AGAINST ('{$searchTermDB}' IN BOOLEAN MODE)
ORDER BY pname DESC LIMIT ".$class->offset.", ".$class->entries_per_page;"";

$searchRLT = mysql_query($searchSQL) or die("Error: ".mysql_error()); # output error message

while($prdROW = mysql_fetch_array($searchRLT)) {

echo $prdROW['psku'].' | '.$prdROW['pname'].' | '.$prdROW['pdescription'].'<br />';
echo 'Listed in: ';
#Running my 2nd query to the products_subcategories table
$subcatSQL = "SELECT subcategory FROM e2o_products_subcategories WHERE psku = '{$prdROW['psku']}'"; 
$subcatRLT = mysql_query($subcatSQL) or die("Error: ".mysql_error()); # output error message;
while($subcatROW = mysql_fetch_array($subcatRLT))
{
$listed .=  $subcatROW['subcategory'];
}
echo $listed;
?>

Open in new window

slickip

Asked: 2012-04-04

Advertise Here

2 Solutions

LVL 84

Dave BaldwinFixer of ProblemsCommented: 2012-04-04

Somewhere about line 15 you need to set $listed = ""; so you can start over each time.

slickipAuthor Commented: 2012-04-04

Hi DaveBaldwin,

Thanks for the reply. When adding the $listed=""; on line 15, the duplication increase stops, but shows the data as such:

001 | Product 1 | Product 1 description here
Listed in: hair-and-lashes-care | cosmetics |

002 | Product 2 | Product 2 description here
Listed in: hair-and-lashes-care | cosmetics |

003 | Product 3 | Product 3 description here
Listed in: hair-and-lashes-care | cosmetics |

The problem still is that Product 2 should only show 2 subcategories and the rest should show their assigned subcategories, meaning that Product 1 & Product 3 have completely different subcatgories assigned.

I hope this will be possible to achieve.

Thanks.

LVL 84

Dave BaldwinFixer of ProblemsCommented: 2012-04-04

I think you need to check your 'e2o_products_subcategories' table. $prdROW['psku'] is the only thing in the WHERE and it is different for each product.

LVL 111

Ray PaseurCommented: 2012-04-05

Please post the CREATE TABLE statements for these tables.

And before line 16, add this statement

$listed = NULL;

Open in new window

Overall you will find that programming is easier to understand if you indent your control structures according to a coding standard. I use a modified ZEND standard that calls for 4 spaces of indentation for the stuff inside the curly braces. It makes the code easy to read!

slickipAuthor Commented: 2012-04-05

Hi all and thanks for all the replies.

I managed, after reading and more reading, to find a workaround myself. The initial search query to my products table caused some issues. Explaining why exactly, I cannot, as I am not so good in PHP, yet.

What I did is basically the following: The initial search query to my products table gave me my required psku. I then ran a loop for this query as:

while ($searchROW = mysql_fetch_array($searchRLT)){
$types[] = "`psku` = '{$searchROW['psku']}'";
$searchSQL = implode(" OR ", $types). ' ';
}
//Inside this loop I basically formed a clean string for my new query to my products table:

$finalPSKUSQL = "SELECT * FROM e2o_products WHERE $searchSQL";
$finalPSKURLT = mysql_query($finalPSKUSQL) or die("Error: ".mysql_error()); # output error message;
while($prdROW = mysql_fetch_array($finalPSKURLT)) {
$prdROW[psku'] .' | '.$prdROW['panme'].' | '.$prdROW['pdescription'];
echo 'Listed in: ';
$subcatSQL="SELECT * FROM e2o_products_subcategories WHERE psku = '{$prdROW['psku']}'";
	$subcatRLT = mysql_query($subcatSQL);
while($subROW = mysql_fetch_array($subcatRLT)){
echo $subROW['subcategory'];
}
}

Open in new window

I hope this makes sense, but it works great now!

Thanks for everyone involved. If its OK with DaveBaldwin & Ray_Paseur, I will split the points equally? Would this be the right way do to in an event were the Asker finds his/her own solution?

Regards to all.

LVL 111

Ray PaseurCommented: 2012-04-05

It seems that the subcategory loop doubles, starting on the Product 1 and seems to double again for each other product.
Has anyone got an idea on how to make this work?

The reason for this phenomenon was that the $listed variable had fields added to it over and over again (line 18) without ever being reset. It appears to me that if you set it to NULL before the inner query you would get reasonable output without the "double again" effect.

I'm not particularly worried about the points - I have enough points to orbit Saturn. But I do wish that you would indent your code. It will help you find the logic errors, and I believe you still have a logic error in the way the script constructs the WHERE clause. This is how I believe the most recent code snippet should read (not sure - I cannot test it without your data base and we never got the CREATE TABLE statements).

while ($searchROW = mysql_fetch_assoc($searchRLT))
{
    $types[] = "`psku` = '{$searchROW['psku']}'";
}
$searchSQL = implode(" OR ", $types) . ' ';

$finalPSKUSQL = "SELECT * FROM e2o_products WHERE $searchSQL";
$finalPSKURLT = mysql_query($finalPSKUSQL) or die("Error: $finalPSKUSQL<br/>" . mysql_error()); 
while($prdROW = mysql_fetch_assoc($finalPSKURLT)) 
{
//  $prdROW[psku'] .' | '.$prdROW['panme'].' | '.$prdROW['pdescription']; THIS STATEMENT DOES NOTHING
    echo 'Listed in: ';
    $subcatSQL = "SELECT * FROM e2o_products_subcategories WHERE psku = '{$prdROW['psku']}'";
    $subcatRLT = mysql_query($subcatSQL) or die("Error: $subcatSQL<br/>" . mysql_error());
    while($subROW = mysql_fetch_assoc($subcatRLT))
    {
        echo $subROW['subcategory'];
    }
}

Open in new window

slickipAuthor Commented: 2012-04-05

Hi Ray.

Thanks for the reply. I totally agree with you and will indent my code by adding the

$listed = NULL;

Open in new window

on my backup file, on line 16.

See below CREATE statements for products table and products_subcategories table:

CREATE TABLE `e2o_products` (
  `id` int(7) NOT NULL AUTO_INCREMENT,
  `maincategory` varchar(100) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `subcategory` varchar(120) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `pname` varchar(130) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT '',
  `pseoname` varchar(200) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `pbrandname` varchar(150) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `pbrandnameseo` varchar(100) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT '',
  `pprefix` varchar(10) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `psku` varchar(14) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT '',
  `pdate` datetime NOT NULL,
  `pdateunix` varchar(12) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `modpdate` datetime NOT NULL,
  `modpdateunix` varchar(12) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `psize` varchar(40) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT '',
  `psizequantifier` varchar(40) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `pintro` varchar(255) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `pdescription` text CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `expdate` varchar(20) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `expdateoption` int(1) NOT NULL,
  `pweightdisp` varchar(15) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT '',
  `ppriceretailuk` varchar(20) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL DEFAULT '',
  `newppriceretailuk` varchar(10) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `prdsavingsuk` varchar(6) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `ppriceretailus` varchar(20) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `newppriceretailus` varchar(10) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `prdsavingsus` varchar(6) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `isdiscount` int(1) NOT NULL DEFAULT '0',
  `prdlargimg` varchar(100) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `prdmedimg` varchar(100) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `prdsmlimg` varchar(100) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `pqty` int(2) NOT NULL DEFAULT '0',
  `pstatus` int(1) NOT NULL,
  `psellcount` int(10) NOT NULL DEFAULT '0',
  `isfront` int(1) NOT NULL,
  `isfeatured` int(1) NOT NULL,
  `istopseller` int(1) NOT NULL,
  `instock` int(1) NOT NULL,
  PRIMARY KEY (`id`),
  FULLTEXT KEY `pdescription` (`pdescription`,`pname`,`pintro`,`psku`)
) ENGINE=MyISAM AUTO_INCREMENT=31 DEFAULT CHARSET=utf8

Open in new window

CREATE TABLE `products_subcategories` (
  `id` int(11) NOT NULL AUTO_INCREMENT,
  `psku` varchar(10) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `subcategory` varchar(100) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `maincategory` varchar(30) CHARACTER SET utf8 COLLATE utf8_unicode_ci NOT NULL,
  `pstatus` int(1) NOT NULL,
  PRIMARY KEY (`id`)
) ENGINE=MyISAM AUTO_INCREMENT=63 DEFAULT CHARSET=utf8

Open in new window

I hope this helps.

Thank you.

slickipAuthor Commented: 2012-04-05

Hi Ray,

I have followed your advice and amended my code. After adding the

$listed = NULL;

Open in new window

before line 16 I got the result that I was after.

Everything works exactly they way I wanted it. Perfect!
I appreciated the afford in explaining. Greatly appreciated.

Best regards.

slickipAuthor Commented: 2012-04-05

Thank you to all parties involved.

Regards to all.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Expand your skills with this month's free Premium course.

Nested Loop nightmare

Join & Write a Comment Already a member? Login.

Featured Post