Javascript syntax

I have the following javascript, but something in the syntax is wrong, perhaps someone who knows syntax can help. I get an error when running the ASP/Javascrip page on this lines:

<%
function isIPad() {
alert( Request.ServerVariables("HTTP_USER_AGENT") );
    var isIpad = false;
alert( Request.ServerVariables("HTTP_USER_AGENT") );
    if ( userAgent.indexOf("iPad") > 0 )
        isIPad = true;

    return isIpad;

}
%>


The code detects if the user is using an ipad or not.
LVL 1
AleksAsked:
Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

x
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

AleksAuthor Commented:
Thanks but I really don't know much of Javascript, what i do is display a region in the ASP based on user using ipad or not:

<%if ( isIPad() ) { %>
    Code for text field here
<% } else { %>
    Code for HTML editor here
<% } %>

... that being said what I need is to return 'isPad' value and not redirecting anywhere, so the javascript is quite different.
ProculopsisCommented:


// I think you need something like this:

function isIPad() {
alert( "<%= Request.ServerVariables("HTTP_USER_AGENT") %>" );
    var isIpad = false;
    var userAgent =  "<%= Request.ServerVariables("HTTP_USER_AGENT") %>";
    if ( userAgent.indexOf("iPad") > 0 )
        isIPad = true;

    return isIpad;

}
Determine the Perfect Price for Your IT Services

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden with our free interactive tool and use it to determine the right price for your IT services. Download your free eBook now!

AleksAuthor Commented:
Got this error:

Microsoft JScript compilation error '800a03ee'

Expected ')'

/bluedot/Intranet/Cases/Commentspop/AddComments.asp, line 289

alert( "<%= Request.ServerVariables("HTTP_USER_AGENT")
Chirag1211Commented:
I think the below code should work for you

<script type='text/javascript'>
      function isIPad(){
            var isIPad = false;
            var userAgent = '<%=Request.ServerVariables("HTTP_USER_AGENT")%>';
            alert(userAgent);
            if(userAgent.indexOf("iPad") > 0) isIPad = true;
            return isIPad;
      }
</script>
AleksAuthor Commented:
Seems like that worked, the second part of the code gave me an error though ... here it is:

 <%if ( isIPad() ) { %>

        <label for="Comments"></label>
        <textarea name="Comments" cols="50" rows="8" id="Comments"><% if (!Lettrmrg.EOF || !Lettrmrg.BOF) { %> <%=(Lettrmrg.Fields.Item("LtrBody").Value)%>  <% } // end !Lettrmrg.EOF || !Lettrmrg.BOF %>  
        </textarea>
<% } else { %>
     <textarea id="Comments" name="Comments" class="dmxEditor" style="width:600px;height:300px"><% if (!Lettrmrg.EOF || !Lettrmrg.BOF) { %> <%=(Lettrmrg.Fields.Item("LtrBody").Value)%>  <% } // end !Lettrmrg.EOF || !Lettrmrg.BOF %>  
</textarea>
<script type="text/javascript">
  // <![CDATA[
 jQuery(document).ready(
   function()
     {
       jQuery("#Comments").dmxEditor(
         {}
       );
     }
 );
  // ]]>
</script>
<% } %>

-- the error is in the first like of the code --

Microsoft JScript runtime error '800a138f'

Object expected

/bluedot/Intranet/Cases/Commentspop/AddComments.asp, line 506

-------

I didnt use to get an error on this part of the code ... maybe a naming is not the same as the first part of the code ?
AleksAuthor Commented:
To keep things simple this is the bottom code that displays the region based on the value captured.

 <%if ( isIPad() ) { %>
 code for text region here
<% } else { %>
 code for HTML editor here
<% } %>

<%if ( isIPad() ) { %>

I get the error above on line # 1.  Seems like the value is not being captured ?
AleksAuthor Commented:
As a matter of fact the logic that we should have in the javascript is the following:

Function isIPad()
    If InStr(Request.ServerVariables("HTTP_USER_AGENT"), "iPad") > 0 Then
        isIPad = True
    Else
        isIPad = False
    End If
End Function

The above is VBscript though ... same logic but in javascript, i dont think the current logic is the same for:

<script type='text/javascript'>
      function isIPad(){
            var isIPad = false;
            var userAgent = '<%=Request.ServerVariables("HTTP_USER_AGENT")%>';
            alert(userAgent);
            if(userAgent.indexOf("iPad") > 0) isIPad = true;
            return isIPad;
      }
</script>
AleksAuthor Commented:
I also tried using vbscript code in the javascript page:

<script type="text/vbscript">

Function isIPad()
    If InStr(Request.ServerVariables("HTTP_USER_AGENT"), "iPad") > 0 Then
        isIPad = True
    Else
        isIPad = False
    End If
End Function

 </script>

then below ...

<%if ( isIPad() ) { %>

        <label for="Comments"></label>
        <textarea name="Comments" cols="50" rows="8" id="Comments"><% if (!Lettrmrg.EOF || !Lettrmrg.BOF) { %> <%=(Lettrmrg.Fields.Item("LtrBody").Value)%>  <% } // end !Lettrmrg.EOF || !Lettrmrg.BOF %>  
        </textarea>
<% } else { %>
     <textarea id="Comments" name="Comments" class="dmxEditor" style="width:600px;height:300px"><% if (!Lettrmrg.EOF || !Lettrmrg.BOF) { %> <%=(Lettrmrg.Fields.Item("LtrBody").Value)%>  <% } // end !Lettrmrg.EOF || !Lettrmrg.BOF %>  
</textarea>
<script type="text/javascript">
  // <![CDATA[
 jQuery(document).ready(
   function()
     {
       jQuery("#Comments").dmxEditor(
         {}
       );
     }
 );
  // ]]>
</script>
<% } %>

Same error:

Microsoft JScript runtime error '800a138f'

Object expected

/bluedot/Intranet/Cases/Commentspop/AddComments.asp, line 510
AleksAuthor Commented:
If I get rid of the bottom code the page works fine with the javascript code at the top. So right now the bottom code is the issue. I will open a different ticket for this issue thanks for the javascript code help.
Sar1973Commented:
You can include a Javascript function in your web page HTML code
<script language="Javascript">
function isIPad() {
    alert(Request.ServerVariables("HTTP_USER_AGENT") );
    var isIpad = false;
    alert( Request.ServerVariables("HTTP_USER_AGENT") );
    if ( userAgent.indexOf("iPad") >= 0 ) {
        isIPad = true;
         return isIpad;
    } else {
    }
}
</script>
</body>
</html>

or in a separate .js file, calling it like this:
<script language="JavaScript" src="amucino.js">
<!--
-->
</script>

Please notice that your original function I have reported is slightly different, since on line 5 it's better to declare ">=0" in the indexOf function, because the string you're looking may be exactly at position 0. Moreover you have a couple of { missing at the end, such as the if declaration end wiht else statement.
Finally it depends on you and on the function itself (I haven't really examined its steps) where to put the different commands (inside or outside the if declaration); I have only noticed a double alert which should be elsewhere.
AleksAuthor Commented:
Ok, so I used the code above it didnt give me an y errors on any of those lines, but below in the page i get this error (Part where i display content based on the above code)

This is the base code i use to display content:

<%if ( isIPad() ) { %>
 code for text region here
<% } else { %>
 code for HTML editor here
<% } %>

But it gives me this error:

Microsoft JScript runtime error '800a138f'

Object expected

/bluedot/Intranet/Cases/Commentspop/AddComments.asp, line 515


Anything i am missing ?
Sar1973Commented:
If it's so precise, you should first check the code itself at the specified line: probably you missed/misnamed a declaration. Are you now in case isIpad or not?
nap0leonCommented:
Minor capitalization issue in Sar1973's function
When it tries to set "isIpad = true" you actually have "isIPad=true"

isIPad is the name of your function
isIpad is the value you are setting and returning

Also, Request.ServerVariables("HTTP_USER_AGENT")  is not valid javascript, so you need to wrap it in <% %> and put quotes around it.

Also, the variable 'userAgent' is never set

Here is the capitalization corrected function:
<div id="content"></div>
<script language="Javascript">
function isIPad() {
    var userAgent = '<%=Request.ServerVariables("HTTP_USER_AGENT")%>'
    var isIpad = false;
    if ( userAgent.indexOf("iPad") >= 0 ) {
        isIpad = true;
    } else {
    }
    return isIpad;
}

var iPad = isIPad()
if (iPad){
	document.getElementById('content').innerHTML = "This is an iPad"
} else {
	document.getElementById('content').innerHTML = "This is NOT an iPad"
}
</script>

Open in new window

nap0leonCommented:
To make you isIPad function a bit shorter (and also since I am not sure of the capitalization of "iPad" in the HTTP_USER_AGENT, try this instead:

function isIPad() {
	('<%=lcase(Request.ServerVariables("HTTP_USER_AGENT"))%>'.indexOf("ipad") >= 0) ? isIpad = true : isIpad = false
	return isIpad
}

Open in new window

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
JavaScript

From novice to tech pro — start learning today.