Solved

Why aren't MS-SQL tables dropped?

Posted on 2012-04-13
3
334 Views
Last Modified: 2012-06-22
I have an interesting issue which is perplexing me.   I have included the code below.  A basic description of the issue is this.  I am running a T-SQL MS SQL Server 2008 script.  The first time through it works fine, then it doesn't work because apparently the statements that are supposed to DROP two tables at the very beginning didn't do that.  I don't know why (although I have my suspicions) and would like to figure out how to get them to work.  I'll point out too, that if I execute them by themselves, they work fine.

So...  
1) The script checks to see if the tables exist and if they do, it is supposed to drop them (which it doesn't).
2) The script creates table RJZ_SL_Temp from scratch.
3) The script populates the table RJZ_SL_Temp.
4) The script then creates the table RJZ_SL_Deliverable by pulling data from RJZ_SL_Temp
5) The script then ALTERS the table RJZ_SL_Deliverable  by DROPping some columns that were used in step 4.

Runs fine when the two created tables don't exist. If I run the commands to check for and DROP the two tables as a standalone run, they work fine.  But if I run the entire script again without dropping the two tables manually, I get a number of
"Invalid column name 'ExtractableEmailVendorFeedName'." messages. These all stem from the second to last SQL Statement where I'm counting the vendor feed names.

Essentially, SQL is looking for one of the columns that was dropped.  For some reason, the deliverable table isn't being dropped when the script is run twice in a row so the CREATE isn't working and the old modified tables remain.  If I drop the tables manually, then it works fine.

The code (parred back to make reading easier):
IF OBJECT_ID ('RJZ_SL_Temp','U') IS NOT NULL
      DROP TABLE RJZ_SL_Temp;
IF OBJECT_ID ('RJZ_SL_Deliverable','U') IS NOT NULL
      DROP TABLE RJZ_SL_Deliverable;
CREATE TABLE RJZ_SL_Temp
      (
      KeyID INT NOT NULL
      ,DedupID INT NOT NULL
      ,DistinctID VARCHAR(61) NULL
      ,EmployeeCount INT
      ,FirstName VARCHAR (100) NULL
      ,MiddleName VARCHAR (100) NULL
      ,LastName VARCHAR (100) NULL
      ,Prefix VARCHAR (50) NULL
      ,Suffix VARCHAR(50) NULL
      ,ExecutiveTitle VARCHAR (500) NULL
      ,OSLevelID int NULL
      ,ExtractableEmailVendorFeedID INT NULL
      ,EMail VARCHAR(255) NULL
      ,ExtractableEmailVendorFeedName VARCHAR(30) NULL
      );
INSERT INTO RJZ_SL_Temp
SELECT DISTINCT
      c.KeyID
      ,f.DedupID
      ,f.DistinctID
      ,c.Employees
      ,f.FirstName
      ,f.MiddleName
      ,f.LastName
      ,f.Prefix
      ,f.Suffix
      ,f.ExecutiveTitle
      ,F.OSLevelID
      ,f.ExtractableEmailVendorFeedID
      ,f.Email
      ,F.ExtractableEmailVendorFeedName
FROM PSExtract.dbo.vwCompany AS c
INNER JOIN PSExtract.dbo.vwExecutiveAndExecutiveFunction AS f
      ON c.KeyID = f.KeyID
WHERE
      c.ContentSetID = 100
      AND c.MSACode = 38060  --Phoenix, AZ  
      AND f.OSFunctionID IN (330,333,355)  --Information,Network,Telecom
      AND f.OSLevelID < 61  /*  Restrict to directors or higher */
      AND F.ExtractableEmailVendorFeedID IS NOT NULL;

-- Second query
/* Populate RJZ_SL_Deliverable with data */
SELECT
A.KeyID, LTRIM(RTRIM(A.CompanyName)) AS CompanyName, Address1 AS Address1, A.Address2 AS Address2, A.Address3 AS Address3, City AS City,
A.StateOrProvinceAbbrev AS StateOrProvinceAbbrev, A.PostalCode AS PostalCode, A.County AS County, CountryName AS CountryName,B.FirstName ,B.MiddleName ,B.LastName ,
B.Prefix ,B.Suffix ,B.ExecutiveTitle,B.Email,B.ExtractableEmailVendorFeedName,B.DistinctID
INTO RJZ_SL_Deliverable
FROM PSExtract.dbo.vwCompany AS A
INNER JOIN (SELECT TOP 250 *
                  FROM      RJZ_SL_Temp Employee
                  WHERE      Employee.DistinctID  IN  
                     (SELECT  TOP 5 DistinctID
                     FROM      RJZ_SL_Temp Top5Emp
                     WHERE      Top5Emp.KeyID =  Employee.KeyID
                     ORDER BY OSLevelID ASC--, DistinctID ASC
                     )  
                  ORDER BY EmployeeCount Desc
                  )AS B
      ON A.KeyID =B.KeyID AND A.ContentSetID = 100
Order By A.Employees DESC, B.DistinctID;

/* Get email counts by vendor feed name */  
SELECT A.ExtractableEmailVendorFeedName, COUNT(A.ExtractableEmailVendorFeedName) as Vendor_Count
FROM RJZ_SL_Deliverable AS A
group by A.ExtractableEmailVendorFeedName
Order by A.ExtractableEmailVendorFeedName;

/* Drop non-deliverable columns from deliverable */
ALTER TABLE RJZ_SL_Deliverable
DROP COLUMN DistinctID,ExtractableEmailVendorFeedName;
0
Comment
Question by:RichNH
  • 2
3 Comments
 
LVL 1

Author Comment

by:RichNH
ID: 37843089
If I select and run as a block all the statements up to but not including "Second query", it works fine, the tables are dropped.   If I run as a block all the statements through second query, it doesn't work.

Is there a VB "DoEvents" equivalent in T-SQL?
0
 
LVL 5

Accepted Solution

by:
gman84 earned 500 total points
ID: 37843119
You could use "GO" to signal the end of a batch
0
 
LVL 1

Author Closing Comment

by:RichNH
ID: 37843157
Well, I'll be, I didn't even know that the GO command existed.  Thanks, it solved the problem.  Reading up on it it appears that it is the equivalent of the DoEvents command, kinda.  Thanks.
0

Featured Post

Threat Intelligence Starter Resources

Integrating threat intelligence can be challenging, and not all companies are ready. These resources can help you build awareness and prepare for defense.

Join & Write a Comment

Suggested Solutions

The Delta outage: 650 cancelled flights, more than 1200 delayed flights, thousands of frustrated customers, tens of millions of dollars in damages – plus untold reputational damage to one of the world’s most trusted airlines. All due to a catastroph…
Ever wondered why sometimes your SQL Server is slow or unresponsive with connections spiking up but by the time you go in, all is well? The following article will show you how to install and configure a SQL job that will send you email alerts includ…
Via a live example combined with referencing Books Online, show some of the information that can be extracted from the Catalog Views in SQL Server.
Via a live example, show how to extract information from SQL Server on Database, Connection and Server properties

743 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now