Excel VBA Select Case issue
I am still in the beginer stage of VBA programming but a long time Excel user. I am in need of some assitance in writing a modified code. My task is to highlight rows in excel based on a keyword in a "T" column. Column "T" will have either Open, Closed, Recalled. I've tried using conditional formatting, but it wasnt working past first row. I have written a macro to do the highlighting and it works great. Here is the code...
Here is the problem.
Current macro just looks at Column"T" and highlights the rows.
While the document is in "Open" status, I need that row to be highlighted by a different color based on the cell not being empty in Column "O" ( it will have a reviewed date). Afterwards, when Column "T" changes to either "Closed" or "Recalled", for that same document, the rows will be highlighted accordingly, regardless if the cell is empty or not empty in Column "O".
Private Sub Worksheet_SelectionChange(ByVal Target As Range)
Dim oCell As Range
For Each oCell In Range("$T2:$T5000")
Select Case oCell.Value
Case Is = "Closed"
oCell.EntireRow.Interior.Color = RGB(196, 215, 155)
Case Is = "Recalled"
oCell.EntireRow.Interior.Color = RGB(191, 191, 191)
Case Is = "Open"
oCell.EntireRow.Interior.ColorIndex = xlNone
End Select
Next oCell
End Sub
Here is the problem.
Current macro just looks at Column"T" and highlights the rows.
While the document is in "Open" status, I need that row to be highlighted by a different color based on the cell not being empty in Column "O" ( it will have a reviewed date). Afterwards, when Column "T" changes to either "Closed" or "Recalled", for that same document, the rows will be highlighted accordingly, regardless if the cell is empty or not empty in Column "O".
Do more with
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
If cell being changed in column T has the value "Open", then if column O of the same row is empty, the row will be highlighted yellow (new color), otherwise, your original logic stands.
Dave
Private Sub Worksheet_SelectionChange(ByVal Target As Range)
Dim oCell As Range
For Each oCell In Range("$T2:$T5000")
Select Case oCell.Value
Case Is = "Closed"
oCell.EntireRow.Interior.Color = RGB(196, 215, 155)
Case Is = "Recalled"
oCell.EntireRow.Interior.Color = RGB(191, 191, 191)
Case Is = "Open"
If Cells(oCell.Row, "O").Value = vbNullString Then
oCell.EntireRow.Interior.Color = vbYellow
Else
oCell.EntireRow.Interior.ColorIndex = xlNone
End If
End Select
Next oCell
End Sub
Dave
May I suggest a couple optimization steps? Is there a need to look at every row in column T from row 2 to 5000, or just the row where a change has (or changes have) been made?
This code (above) checks only the rows that have been changed in column T (2:5000) and is triggered by Worksheet_Change() event, as opposed to Worksheet_SelectionChange(
May I also ask what should be done if the value in column T were blank? You don't seem to have code handling that, so you might be highlighting a row after the column T value were cleared, that didn't need highlighting.
Dave
Private Sub Worksheet_Change(ByVal Target As Range)
Dim oCell As Range
If Not Intersect(Target, Range("T2:T5000")) Is Nothing Then
For Each oCell In Target
Select Case oCell.Value
Case Is = "Closed"
oCell.EntireRow.Interior.Color = RGB(196, 215, 155)
Case Is = "Recalled"
oCell.EntireRow.Interior.Color = RGB(191, 191, 191)
Case Is = "Open"
If Cells(oCell.Row, "O").Value = vbNullString Then
oCell.EntireRow.Interior.Color = vbYellow
Else
oCell.EntireRow.Interior.ColorIndex = xlNone
End If
End Select
Next oCell
End If
End Sub
This code (above) checks only the rows that have been changed in column T (2:5000) and is triggered by Worksheet_Change() event, as opposed to Worksheet_SelectionChange(
May I also ask what should be done if the value in column T were blank? You don't seem to have code handling that, so you might be highlighting a row after the column T value were cleared, that didn't need highlighting.
Dave
Premium Content
You need an Expert Office subscription to comment.Start Free Trial