We help IT Professionals succeed at work.
Get Started

Best practice to using if - else logic

jkteater
jkteater asked
on
458 Views
Last Modified: 2012-08-16
In my method I am getting a String value for XMLFormat.  If the value is null or has no value I want to run method a, if the value has a value of version 1, I want to run method a.  but if the value has a value of version 2, I want to run method b.  Please tell me if my logic looks OK?

public void setXMLFormat(){
      TCPreferenceService ups = session.getPreferenceService(); 
      String xmlFormat = ups.getString(TCPreferenceService.TC_preference_user,  XML_FORMAT");    
      if(xmlFormat == null || xmlFormat.trim().isEmpty()) {
         buildXMLTwo(true);
      }
      else if(xmlFormat == "version 1") {
         buildXMLTwo(true);       
      }
      else {
         buildXml(true);
      }
   }

Open in new window

Comment
Watch Question
This problem has been solved!
Unlock 1 Answer and 5 Comments.
See Answer
Why Experts Exchange?

Experts Exchange always has the answer, or at the least points me in the correct direction! It is like having another employee that is extremely experienced.

Jim Murphy
Programmer at Smart IT Solutions

When asked, what has been your best career decision?

Deciding to stick with EE.

Mohamed Asif
Technical Department Head

Being involved with EE helped me to grow personally and professionally.

Carl Webster
CTP, Sr Infrastructure Consultant
Ask ANY Question

Connect with Certified Experts to gain insight and support on specific technology challenges including:

  • Troubleshooting
  • Research
  • Professional Opinions
Did You Know?

We've partnered with two important charities to provide clean water and computer science education to those who need it most. READ MORE