Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!
Passing a parameter with Like
I have a query that displays voided transactions, and I am passing a parameter value to the WHERE clause with like but it is not returning any rows, I know I am missing something but I can't seem to figure out what.
declare @ITEM char(1000)
set @ITEM = 'ATIGM9130'
SELECT
[Company]='NAME',
[Source]=cast('History' as varchar(7)),
[Doc_Type]=CASE SOP30200.SOPTYPE when 1 then 'QUOTE' when 2 then 'ORDER' when 3 then 'INVOICE' when 4 then 'RETURN' when 5 then 'BACKORDER' else '' end,
[Doc_Number]=SOP30200.SOPNUMBE,
SOP30300.ITEMNMBR,
SOP30300.ITEMDESC,
SOP30300.QUANTITY,
SOP30200.ORIGNUMB,
[Doc_Date]=SOP30200.DOCDATE,
[GL_Posting_Date]=SOP30200.GLPOSTDT,
[Invoice_Date]=SOP30200.INVODATE,
SOP30200.FUFILDAT,
SOP30200.ACTLSHIP,
SOP30200.LOCNCODE,
SOP30200.BCHSOURC,
[Batch_No]=SOP30200.BACHNUMB,
SOP30200.CUSTNMBR,
SOP30200.CUSTNAME,
SOP30200.ADDRESS1,
SOP30200.ADDRESS2,
SOP30200.CITY,
SOP30200.[STATE],
SOP30200.CNTCPRSN,
SOP30200.PHNUMBR1,
SOP30200.PHNUMBR2,
SOP30200.SHIPMTHD,
[Posting_Status]=CASE SOP30200.PSTGSTUS when 0 then 'NOT POSTED' when 2 then 'POSTED' else 'UNKNOWN' end,
[Void_Status]=CASE SOP30200.VOIDSTTS when 1 then 'VOIDED' else '' end,
--[Message] = CASE SOP30200.VOIDSTTS when 1 then 'Voided By will be the Batch_No for the transaction.' else '' end,
[Voided By]= CASE SOP30200.VOIDSTTS when 0 then '' else SOP30200.BACHNUMB end,
IV00101.ITMCLSCD
FROM SOP30200 WITH(nolock) INNER JOIN
SOP30300 WITH(nolock) ON SOP30200.SOPTYPE = SOP30300.SOPTYPE AND SOP30200.SOPNUMBE = SOP30300.SOPNUMBE INNER JOIN
IV00101 WITH(nolock) ON SOP30300.ITEMNMBR = IV00101.ITEMNMBR
WHERE (IV00101.ITMTRKOP = 2) AND (NOT (SOP30200.SOPTYPE = 1)) AND (SOP30300.ITEMNMBR LIKE '%'+@ITEM+'%' )--AND SOP30300.ITEMNMBR in (select Value from dbo.parmstolist(@ITEM, ','))
ORDER BY 8 DESC
Do more with
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
the query syntax is correct. may be there is something wrong with the logic.
for example:
- may be you need to replace AND with OR.
- make sure ITEMNMBR is varchar...
WHERE ( IV00101.ITMTRKOP = 2 )
AND ( SOP30200.SOPTYPE <> 1 )
AND ( SOP30300.ITEMNMBR LIKE '%' + @ITEM + '%' )
for example:
- may be you need to replace AND with OR.
- make sure ITEMNMBR is varchar...
That (commented) subquery of select Value from dbo.parmstolist(@ITEM, ',') points to that @item contains more than one value?
If I just use the @ITEM param without the LIKE and enter the full item number value it works just fine. the (select Value from dbo.parmstolist(@ITEM, ',') is a stored proc that allows me to pass several values separated by a comma, which also works if I enter multiple complete Item numbers which I don't want do do. Adding an OR does not filter on the parameter value.
The cause could be multiple and not necessarily the LIKE clause condition. It is possible that the INNER JOIN conditions filter out the results or maybe in a different WHERE clause condition.
My advice is to run a query only with count to see which condition is actually causing the filtering out of the rows:
If you will get rows aftec commenting the LIKE condition it means that there are no ITEMNUMBERs with that format: %ATIGM9130%
My advice is to run a query only with count to see which condition is actually causing the filtering out of the rows:
declare @ITEM char(1000)
set @ITEM = 'ATIGM9130'
SELECT
count(*) cnt
FROM
SOP30200 WITH(nolock)
INNER JOIN SOP30300 WITH(nolock) ON SOP30200.SOPTYPE = SOP30300.SOPTYPE AND SOP30200.SOPNUMBE = SOP30300.SOPNUMBE
INNER JOIN IV00101 WITH(nolock) ON SOP30300.ITEMNMBR = IV00101.ITEMNMBR
WHERE
(IV00101.ITMTRKOP = 2)
AND (NOT (SOP30200.SOPTYPE = 1))
AND (SOP30300.ITEMNMBR LIKE '%'+@ITEM+'%' )
If you will get rows aftec commenting the LIKE condition it means that there are no ITEMNUMBERs with that format: %ATIGM9130%
instead of declaring @item as char(1000) declare it as varchar(1000).
declare @ITEM varchar(1000)
set @ITEM = 'ATIGM9130'
Premium Content
You need an Expert Office subscription to comment.Start Free Trial