asked on Passing a parameter with Like
I have a query that displays voided transactions, and I am passing a parameter value to the WHERE clause with like but it is not returning any rows, I know I am missing something but I can't seem to figure out what.
declare @ITEM char(1000)
set @ITEM = 'ATIGM9130'
SELECT
[Company]='NAME',
[Source]=cast('History' as varchar(7)),
[Doc_Type]=CASE SOP30200.SOPTYPE when 1 then 'QUOTE' when 2 then 'ORDER' when 3 then 'INVOICE' when 4 then 'RETURN' when 5 then 'BACKORDER' else '' end,
[Doc_Number]=SOP30200.SOPNUMBE,
SOP30300.ITEMNMBR,
SOP30300.ITEMDESC,
SOP30300.QUANTITY,
SOP30200.ORIGNUMB,
[Doc_Date]=SOP30200.DOCDATE,
[GL_Posting_Date]=SOP30200.GLPOSTDT,
[Invoice_Date]=SOP30200.INVODATE,
SOP30200.FUFILDAT,
SOP30200.ACTLSHIP,
SOP30200.LOCNCODE,
SOP30200.BCHSOURC,
[Batch_No]=SOP30200.BACHNUMB,
SOP30200.CUSTNMBR,
SOP30200.CUSTNAME,
SOP30200.ADDRESS1,
SOP30200.ADDRESS2,
SOP30200.CITY,
SOP30200.[STATE],
SOP30200.CNTCPRSN,
SOP30200.PHNUMBR1,
SOP30200.PHNUMBR2,
SOP30200.SHIPMTHD,
[Posting_Status]=CASE SOP30200.PSTGSTUS when 0 then 'NOT POSTED' when 2 then 'POSTED' else 'UNKNOWN' end,
[Void_Status]=CASE SOP30200.VOIDSTTS when 1 then 'VOIDED' else '' end,
--[Message] = CASE SOP30200.VOIDSTTS when 1 then 'Voided By will be the Batch_No for the transaction.' else '' end,
[Voided By]= CASE SOP30200.VOIDSTTS when 0 then '' else SOP30200.BACHNUMB end,
IV00101.ITMCLSCD
FROM SOP30200 WITH(nolock) INNER JOIN
SOP30300 WITH(nolock) ON SOP30200.SOPTYPE = SOP30300.SOPTYPE AND SOP30200.SOPNUMBE = SOP30300.SOPNUMBE INNER JOIN
IV00101 WITH(nolock) ON SOP30300.ITEMNMBR = IV00101.ITEMNMBR
WHERE (IV00101.ITMTRKOP = 2) AND (NOT (SOP30200.SOPTYPE = 1)) AND (SOP30300.ITEMNMBR LIKE '%'+@ITEM+'%' )--AND SOP30300.ITEMNMBR in (select Value from dbo.parmstolist(@ITEM, ','))
ORDER BY 8 DESC
Microsoft SQL ServerMicrosoft SQL Server 2008SQL
Last Comment
skull52
If you take out the like condition, do results that match that item get returned?
the query syntax is correct. may be there is something wrong with the logic.
for example:
- may be you need to replace AND with OR.
- make sure ITEMNMBR is varchar...
WHERE ( IV00101.ITMTRKOP = 2 )
AND ( SOP30200.SOPTYPE <> 1 )
AND ( SOP30300.ITEMNMBR LIKE '%' + @ITEM + '%' )
for example:
- may be you need to replace AND with OR.
- make sure ITEMNMBR is varchar...
That (commented) subquery of select Value from dbo.parmstolist(@ITEM, ',') points to that @item contains more than one value?
All of life is about relationships, and EE has made a viirtual community a real community. It lifts everyone's boat
William Peck
ASKER
If I just use the @ITEM param without the LIKE and enter the full item number value it works just fine. the (select Value from dbo.parmstolist(@ITEM, ',') is a stored proc that allows me to pass several values separated by a comma, which also works if I enter multiple complete Item numbers which I don't want do do. Adding an OR does not filter on the parameter value.
The cause could be multiple and not necessarily the LIKE clause condition. It is possible that the INNER JOIN conditions filter out the results or maybe in a different WHERE clause condition.
My advice is to run a query only with count to see which condition is actually causing the filtering out of the rows:
If you will get rows aftec commenting the LIKE condition it means that there are no ITEMNUMBERs with that format: %ATIGM9130%
My advice is to run a query only with count to see which condition is actually causing the filtering out of the rows:
declare @ITEM char(1000)
set @ITEM = 'ATIGM9130'
SELECT
count(*) cnt
FROM
SOP30200 WITH(nolock)
INNER JOIN SOP30300 WITH(nolock) ON SOP30200.SOPTYPE = SOP30300.SOPTYPE AND SOP30200.SOPNUMBE = SOP30300.SOPNUMBE
INNER JOIN IV00101 WITH(nolock) ON SOP30300.ITEMNMBR = IV00101.ITEMNMBR
WHERE
(IV00101.ITMTRKOP = 2)
AND (NOT (SOP30200.SOPTYPE = 1))
AND (SOP30300.ITEMNMBR LIKE '%'+@ITEM+'%' )
If you will get rows aftec commenting the LIKE condition it means that there are no ITEMNUMBERs with that format: %ATIGM9130%
ASKER CERTIFIED SOLUTION
Log in or sign up to see answer
Become an EE member today7-DAY FREE TRIAL
Members can start a 7-Day Free trial then enjoy unlimited access to the platform
or
Learn why we charge membership fees
We get it - no one likes a content blocker. Take one extra minute and find out why we block content.
Not exactly the question you had in mind?
Sign up for an EE membership and get your own personalized solution. With an EE membership, you can ask unlimited troubleshooting, research, or opinion questions.
ask a question
Correct, pourfard is right. Declaring the variable as CHAR the comparition value will actually be:
%ATIGM9130 %
where the trailing spaces will count hence the lack of results.
%ATIGM9130 %
where the trailing spaces will count hence the lack of results.
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.
ASKER
Yep it was the varchar, I normally don't use char, I copied that declare statement from another query I did a while ago which was a char, missed that one, thanks pourfard and thanks to all who responded. "Happy Holidays"