Avatar of hchabria
hchabria
Flag for India asked on

PowerShell to crete HTML report

I am using the attached PowerShell scripts (XeAapp_Check.ps1, Ctx_functions.ps1) to export the XenApp 4.5 Zone details to HTML file as a report. On executing the script for the first time I am getting the desired result but unfortunately everytime I execute the script, the zone details gets appended to that report.

Here is my server details:

Farm Name: MyFarm

Server Name              zone Name
==========               ==========
XEN-1                           192.168.1.0
XEN-2                           TEST ZONE

Please assist me to get the correct result so that I can get the desired output by correctly modifying that script.
Ctx-Functions.txt
XenApp-Check.txt
XenApp-Check--Farm-Name--MyFarm-.mht
CitrixPowershell

Avatar of undefined
Last Comment
hchabria

8/22/2022 - Mon
Meir Rivkin

the problem is that its appended to the html result instead of generating fresh one?
can u describe expected result?
hchabria

ASKER
Yes, that is the exact problem. Can you please guide me to rectify this?
hchabria

ASKER
Please find the attached expected result.
XenApp-Check--Farm-Name--MyFarm-.mht
This is the best money I have ever spent. I cannot not tell you how many times these folks have saved my bacon. I learn so much from the contributors.
rwheeler23
Meir Rivkin

in XenApp-Check.txt script just before you call out-file to save as .htm (scroll all the way down the script), you wanna delete them if already exists:

if(Test-Path  $FileXenApp_Check){
remove-item $FileXenApp_Check
}

if(Test-Path  $FileXenApp_CheckBackup){
remove-item  $FileXenApp_CheckBackup
	
}

$XenAppReport | out-file -encoding ASCII -filepath $FileXenApp_Check
$XenAppReport | out-file -encoding ASCII -filepath $FileXenApp_CheckBackup
	
echo "DONE"

Open in new window

Meir Rivkin

i saw that you hard coded:
$Check_OutputEnteteZone = "TRUE"

when u generate the html, you iterate the zones:
If ($Check_OutputEnteteZone -eq "TRUE")
{
Foreach ($Zones in $Zones) {

so the if statement is redundant (cause its always true).
hchabria

ASKER
I've added the code you provided but still having the same result (please see the attached file). The report gets deleted but when recreated, the restult gets appended in the report.

I am not that much expert on PowerShell. Can you please guide me what should I do in case if I set $Check_OutputEnteteZone = "TRUE".

It would be very helpful of me if you could provide me the rectified code.
XenApp-Check--Farm-Name--MyFarm-.mht
⚡ FREE TRIAL OFFER
Try out a week of full access for free.
Find out why thousands trust the EE community with their toughest problems.
hchabria

ASKER
Event I've deleted the "If ($Check_OutputEnteteZone -eq "TRUE")" condition and then executed the script, but getting same result.

#Farm Name
$XenAppReport = Get-CustomHTML "Farm Name : $Farm"
$XenAppReport += Get-CustomHeaderClose

#Write-CustomOut "..Adding Zones Details Info to the report"
	Foreach ($Zones in $Zones) {
	$OutputEnteteZone2 += @($Zones | Select @{N="Zone Name";E={if($Zones.ZoneName -eq $Null){"Error"}else{$Zones.ZoneName}}}, @{N="Zone Data Collector";E={if($Zones.DataCollector -eq $Null){"Error"}else{$Zones.DataCollector}}}) }
	$XenAppReport += Get-CustomHeader ("Zone(s) Details : "+($Zones_Count))
	$XenAppReport += Get-HTMLTable $OutputEnteteZone2
	$XenAppReport += Get-CustomHeaderClose
	

$Date = Get-Date -Format "yyyyMMddHH"
$FileXenApp_Check = $Path + $FileName + ".htm"
$FileXenApp_CheckBackup = $PathBackup + $FileName + "_" + $date + ".htm"


if(Test-Path  $FileXenApp_Check){
remove-item $FileXenApp_Check
}

if(Test-Path  $FileXenApp_CheckBackup){
remove-item  $FileXenApp_CheckBackup
	
}

$XenAppReport | out-file -encoding ASCII -filepath $FileXenApp_Check
$XenAppReport | out-file -encoding ASCII -filepath $FileXenApp_CheckBackup
	
echo "DONE"

Open in new window

hchabria

ASKER
What I have seen that, if I change the following variable name everytime then, I am getting the desired result.

$OutputEnteteZone

Also, I there is any way to delete the value of that variable then I think the result will come but I don't have any clue about how to do this.
Meir Rivkin

change this:
If ($Check_OutputEnteteZone -eq "TRUE")
{
	Foreach ($Zones in $Zones) {
	$OutputEnteteZone1 += @($Zones | Select @{N="Zone Name";E={if($Zones.ZoneName -eq $Null){"Error"}else{$Zones.ZoneName}}}, @{N="Zone Data Collector";E={if($Zones.DataCollector -eq $Null){"Error"}else{$Zones.DataCollector}}}) }
	$XenAppReport += Get-CustomHeader ("Zone(s) Details : "+($Zones_Count))
	$XenAppReport += Get-HTMLTable $OutputEnteteZone1
	$XenAppReport += Get-CustomHeaderClose
}

Open in new window


to this:
	$OutputEnteteZone1 += @($Zones | Select @{N="Zone Name";E={if($Zones.ZoneName -eq $Null){"Error"}else{$Zones.ZoneName}}}, @{N="Zone Data Collector";E={if($Zones.DataCollector -eq $Null){"Error"}else{$Zones.DataCollector}}}) 
	$XenAppReport += Get-CustomHeader ("Zone(s) Details : "+($Zones_Count))
	$XenAppReport += Get-HTMLTable $OutputEnteteZone1
	$XenAppReport += Get-CustomHeaderClose

Open in new window


--> remove if stetment and foreach stetment.
the if is redundant and the foreach already takes place when you call:
$OutputEnteteZone1 += @($Zones | ....
Experts Exchange has (a) saved my job multiple times, (b) saved me hours, days, and even weeks of work, and often (c) makes me look like a superhero! This place is MAGIC!
Walt Forbes
Meir Rivkin

btw, can u debug your script?
hchabria

ASKER
Please find below the code as you instructed and the attached result. The result is getting appended everytime and the ouput is producing an error as $Zones.ZoneName value is producing NULL value.

$XenAppReport = Get-CustomHTML "Farm Name : $Farm"
$XenAppReport += Get-CustomHeaderClose

$OutputEnteteZone1 += @($Zones | Select @{N="Zone Name";E={if($Zones.ZoneName -eq $Null){"Error"}else{$Zones.ZoneName}}}, @{N="Zone Data Collector";E={if($Zones.DataCollector -eq $Null){"Error"}else{$Zones.DataCollector}}}) 
$XenAppReport += Get-CustomHeader ("Zone(s) Details : "+($Zones_Count))
$XenAppReport += Get-HTMLTable $OutputEnteteZone1
$XenAppReport += Get-CustomHeaderClose

$Date = Get-Date -Format "yyyyMMddHH"
$FileXenApp_Check = $Path + $FileName + ".htm"
$FileXenApp_CheckBackup = $PathBackup + $FileName + "_" + $date + ".htm"

if(Test-Path  $FileXenApp_Check){
remove-item $FileXenApp_Check
}
if(Test-Path  $FileXenApp_CheckBackup){
remove-item  $FileXenApp_CheckBackup
}

$XenAppReport | out-file -encoding ASCII -filepath $FileXenApp_Check
$XenAppReport | out-file -encoding ASCII -filepath $FileXenApp_CheckBackup
	
echo "DONE"

Open in new window

Report.PNG
Meir Rivkin

the problem is not appending the file but the $zones creation.
there's a function called GET-XAZone i assume which returns aggregated $Zones.
i couldn't;t find source of this function in the files you've attached.
please check $Zones.Count when code is back from GET-XAZone.
i guess that from second run you get aggregated result.
but again do not have the source of GET-XAZone.
⚡ FREE TRIAL OFFER
Try out a week of full access for free.
Find out why thousands trust the EE community with their toughest problems.
Meir Rivkin

btw, you can remove the test-path code i've suggested before cause its not the issue.
hchabria

ASKER
I posted the above result after debugging my script only.
ASKER CERTIFIED SOLUTION
SubSun

THIS SOLUTION ONLY AVAILABLE TO MEMBERS.
View this solution by signing up for a free trial.
Members can start a 7-Day free trial and enjoy unlimited access to the platform.
See Pricing Options
Start Free Trial
GET A PERSONALIZED SOLUTION
Ask your own question & get feedback from real experts
Find out why thousands trust the EE community with their toughest problems.
hchabria

ASKER
Excellent Subsun. It's working perfectly now after setting $OutputEnteteZone1 to $null.

Thank you so much.
I started with Experts Exchange in 2004 and it's been a mainstay of my professional computing life since. It helped me launch a career as a programmer / Oracle data analyst
William Peck