asked on Problem with ON DUPLICATE query
Hi,
Something is wrong with this query, but don't know what :(
The query should update an entry if it already exists (country code) or insert it not.
Something is wrong with this query, but don't know what :(
The query should update an entry if it already exists (country code) or insert it not.
$sql = "
INSERT INTO currency_exchange_rates
	(base, country, value, updated, updated_datetime)
VALUES
	('{$this->base}', '$code','$item','{$exchangeRates->timestamp}','".date("Y-m-d H:i:s",$exchangeRates->timestamp)."')
ON DUPLICATE
	country
UPDATE
	value='$item', updated_datetime='{$exchangeRates->timestamp}', updated_datetime='".date("Y-m-d H:i:s",$exchangeRates->timestamp)."'
WHERE
	country='$code'
";
PHPMySQL Server
Last Comment
Ray Paseur
ASKER CERTIFIED SOLUTION
THIS SOLUTION ONLY AVAILABLE TO MEMBERS.
View this solution by signing up for a free trial.
Members can start a 7-Day free trial and enjoy unlimited access to the platform.
ASKER
Ray_Paseur;
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'country UPDATE value='3.672971', updated_datetime='13564800
country is an index.
Corrected an error, but still the same error message
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'country UPDATE value='3.672971', updated_datetime='13564800
country is an index.
Corrected an error, but still the same error message
$sql = "
INSERT INTO currency_exchange_rates
(base, country, value, updated, updated_datetime)
VALUES
('{$this->base}', '$code','$item','{$exchangeRates->timestamp}','".date("Y-m-d H:i:s",$exchangeRates->timestamp)."')
ON DUPLICATE
country
UPDATE
value='$item', updated='{$exchangeRates->timestamp}', updated_datetime='".date("Y-m-d H:i:s",$exchangeRates->timestamp)."'
WHERE
country='$code'
";
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'country UPDATE value='3.672971', updated='1356480009', updated_datetime='' at line 6
ASKER
The "Is the column country an index?" question kinda 'tricked' it for me, think I fixed the issue. This seems to work:
I guess "ON DUPLICATE country UPDATE value='$item', updated=....." is not valid.
$sql = "
INSERT INTO currency_exchange_rates
(base, country, value, updated, updated_datetime)
VALUES
('{$this->base}', '$code','$item','{$exchangeRates->timestamp}','".date("Y-m-d H:i:s",$exchangeRates->timestamp)."')
ON DUPLICATE KEY UPDATE
value='$item', updated='{$exchangeRates->timestamp}', updated_datetime='".date("Y-m-d H:i:s",$exchangeRates->timestamp)."'
";
I guess "ON DUPLICATE country UPDATE value='$item', updated=....." is not valid.
Make a Google search for "on duplicate key update mysql php" and see if the answers win the day. Best regards and merry Christmas, ~Ray
The only thing I have to add to this is that the ON DUPLICATE KEY UPDATE command line only works with Unique or Primary Key values.
ASKER
Thanks Wadehults, will make sure that is the case :)
Man Page here: http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html
Important Note here: In general, you should try to avoid using an ON DUPLICATE KEY UPDATE clause on tables with multiple unique indexes.
That tells me that you want country to be the index and the only index.
Important Note here: In general, you should try to avoid using an ON DUPLICATE KEY UPDATE clause on tables with multiple unique indexes.
That tells me that you want country to be the index and the only index.
Duplicate Key Update