Status: Solved
Priority: Medium
Security: Public
Views: 241
Last Modified: 2012-12-30

Problem with ON DUPLICATE query

Hi,

Something is wrong with this query, but don't know what :(
The query should update an entry if it already exists (country code) or insert it not.

$sql = "
INSERT INTO currency_exchange_rates
&#9;(base, country, value, updated, updated_datetime) 
VALUES
&#9;('{$this->base}', '$code','$item','{$exchangeRates->timestamp}','".date("Y-m-d H:i:s",$exchangeRates->timestamp)."')
ON DUPLICATE
&#9;country
UPDATE
&#9;value='$item', updated_datetime='{$exchangeRates->timestamp}', updated_datetime='".date("Y-m-d H:i:s",$exchangeRates->timestamp)."'
WHERE
&#9;country='$code'
";

Open in new window

kgp43

Asked: 2012-12-25

Advertise Here

1 Solution

LVL 111

Ray PaseurCommented: 2012-12-25

Something is wrong with this query

What is the Something in that statement? Please tell us a little more. Is the column country an index? Is there an error message?

LVL 3

wadehultsCommented: 2012-12-25

Here is an article that may be useful to you:
Duplicate Key Update

kgp43Author Commented: 2012-12-25

Ray_Paseur;

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'country UPDATE value='3.672971', updated_datetime='1356480009', updated_d' at line 6

country is an index.

Corrected an error, but still the same error message

$sql = "
INSERT INTO currency_exchange_rates
	(base, country, value, updated, updated_datetime) 
VALUES
	('{$this->base}', '$code','$item','{$exchangeRates->timestamp}','".date("Y-m-d H:i:s",$exchangeRates->timestamp)."')
ON DUPLICATE
	country
UPDATE
	value='$item', updated='{$exchangeRates->timestamp}', updated_datetime='".date("Y-m-d H:i:s",$exchangeRates->timestamp)."'
WHERE
	country='$code'
";

Open in new window

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'country UPDATE value='3.672971', updated='1356480009', updated_datetime='' at line 6

Open in new window

kgp43Author Commented: 2012-12-25

The "Is the column country an index?" question kinda 'tricked' it for me, think I fixed the issue. This seems to work:

$sql = "
INSERT INTO currency_exchange_rates
	(base, country, value, updated, updated_datetime) 
VALUES
	('{$this->base}', '$code','$item','{$exchangeRates->timestamp}','".date("Y-m-d H:i:s",$exchangeRates->timestamp)."')
ON DUPLICATE KEY UPDATE
	value='$item', updated='{$exchangeRates->timestamp}', updated_datetime='".date("Y-m-d H:i:s",$exchangeRates->timestamp)."'
";

Open in new window

I guess "ON DUPLICATE country UPDATE value='$item', updated=....." is not valid.

LVL 111

Ray PaseurCommented: 2012-12-25

Make a Google search for "on duplicate key update mysql php" and see if the answers win the day. Best regards and merry Christmas, ~Ray

LVL 3

wadehultsCommented: 2012-12-25

The only thing I have to add to this is that the ON DUPLICATE KEY UPDATE command line only works with Unique or Primary Key values.

kgp43Author Commented: 2012-12-25

Thanks Wadehults, will make sure that is the case :)

LVL 111

Ray PaseurCommented: 2012-12-26

Man Page here: http://dev.mysql.com/doc/refman/5.0/en/insert-on-duplicate.html
Important Note here: In general, you should try to avoid using an ON DUPLICATE KEY UPDATE clause on tables with multiple unique indexes.

That tells me that you want country to be the index and the only index.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Problem with ON DUPLICATE query

Join & Write a Comment Already a member? Login.

Featured Post