Batch Script Modification Needed
I have a script working great. However the script and the 'filelist.txt' file will reside in:
C:\Scripts
While the data files in the 'filelist.txt' file will reside in
C:\Data
So the resulting files will also reside in:
C:\Data
Do I just put the whole path in the 'filelist.txt' file or do I need to change script?
@echo off
setlocal EnableDelayedExpansion
REM get a file name and the YEAR column
for /F "tokens=1,2 delims=|" %%A in (filelist.txt) do call :Extract %%A %%B
exit /b
:Extract FileName YearColNo
set filename=%1
set colno=%2
@echo Processing file %filename%
REM Get the header line
set head=
for /F "usebackq delims=" %%F in ("%filename%") do if not defined head set head=%%F
REM Construct RegEx for matching the correct year column
set pat=
for /L %%L in (2,1,%colno%) do set "pat=!pat![^^|]*|"
set "pat=^^!pat!2004^|"
> 2004_%filename% echo,!head!
>>2004_%filename% findstr /R "%pat%" %filename%
REM Head will be added automatically
REM > Non_2004_%filename% findstr /V /R "%pat%" %filename%
exit /b
C:\Scripts
While the data files in the 'filelist.txt' file will reside in
C:\Data
So the resulting files will also reside in:
C:\Data
Do I just put the whole path in the 'filelist.txt' file or do I need to change script?
@echo off
setlocal EnableDelayedExpansion
REM get a file name and the YEAR column
for /F "tokens=1,2 delims=|" %%A in (filelist.txt) do call :Extract %%A %%B
exit /b
:Extract FileName YearColNo
set filename=%1
set colno=%2
@echo Processing file %filename%
REM Get the header line
set head=
for /F "usebackq delims=" %%F in ("%filename%") do if not defined head set head=%%F
REM Construct RegEx for matching the correct year column
set pat=
for /L %%L in (2,1,%colno%) do set "pat=!pat![^^|]*|"
set "pat=^^!pat!2004^|"
> 2004_%filename% echo,!head!
>>2004_%filename% findstr /R "%pat%" %filename%
REM Head will be added automatically
REM > Non_2004_%filename% findstr /V /R "%pat%" %filename%
exit /b
Do more with
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
You will run into problems near the end of the script if you put full pathnames into the 'filelist.txt' file.
The script appears to create new files prefixed with "2004_", and appends data to them. This will mess up if you use a full path because it will try to create a file that looks like this: "2004_C:\Data\somefile.txt
The script will look in the "current directory" for any file operations that use a relative path, so it is easier if you CD to C:\Data inside your script, and then use relative file names inside of the 'filelist.txt'. If you do this, you'll need to make sure the FOR loop accesses "filelist.txt" using an absolute path, since it does not reside in C:\Data.
Example:
@echo off
setlocal EnableDelayedExpansion
cd C:\DATA
REM get a file name and the YEAR column
for /F "tokens=1,2 delims=|" %%A in (C:\Scripts\filelist.txt) do call :Extract %%A %%B
exit /b
..... rest of your script ....
The script appears to create new files prefixed with "2004_", and appends data to them. This will mess up if you use a full path because it will try to create a file that looks like this: "2004_C:\Data\somefile.txt
The script will look in the "current directory" for any file operations that use a relative path, so it is easier if you CD to C:\Data inside your script, and then use relative file names inside of the 'filelist.txt'. If you do this, you'll need to make sure the FOR loop accesses "filelist.txt" using an absolute path, since it does not reside in C:\Data.
Example:
@echo off
setlocal EnableDelayedExpansion
cd C:\DATA
REM get a file name and the YEAR column
for /F "tokens=1,2 delims=|" %%A in (C:\Scripts\filelist.txt) do call :Extract %%A %%B
exit /b
..... rest of your script ....
Assuming the files listed in filelist.txt do not have the full path specified, but are just the file names, then these changes should take care of things.
@echo off
setlocal EnableDelayedExpansion
REM Define file and directory to work with
set FileList=C:\Scripts\filelist.txt
set DataDir=C:\Data
REM get a file name and the YEAR column
for /F "usebackq tokens=1,2 delims=|" %%A in ("%FileList") do call :Extract %%A %%B
exit /b
:Extract [FileName] [YearColNo]
set filename=%~1
set colno=%~2
@echo Processing file "%DataDir%\%filename%"
REM Get the header line
set head=
for /F "usebackq delims=" %%F in ("%DataDir%\%filename%") do if not defined head set head=%%F
REM Construct RegEx for matching the correct year column
set pat=
for /L %%L in (2,1,%colno%) do set "pat=!pat![^^|]*|"
set "pat=^^!pat!2004^|"
> "%DataDir%\2004_%filename%" echo,!head!
>>"%DataDir%\2004_%filename%" findstr /R "%pat%" "%DataDir%\%filename%"
REM Head will be added automatically
REM > "%DataDir%\Non_2004_%filename%" findstr /V /R "%pat%" "%DataDir%\%filename%"
exit /b
Premium Content
You need an Expert Office subscription to comment.Start Free Trial