If your data, services or processes become compromised, your organization can suffer damage in just minutes and how fast you communicate during a major IT incident is everything. Learn how to immediately identify incidents & best practices to resolve them quickly and effectively.
Course Of The Month
1 day, 19 hours left to enrollBecome a Premium Member and unlock a new, free course in leading technologies each month.
Solved
Simplify jquery
Posted on 2012-12-26
Hello experts and merry christmas
I need helpto simplify the attached code:
f.e
I 'm using this code:
<br /><center><img src="' + staticurl + 'img/errorsmall.gif" /><br /><h4>' + defaulterror + '</h4></center>
OR:
p.html('<br /><center><img src="' + staticurl + 'img/errorsmall.gif" /><br /><h4>' + defaulterror + '</h4></center>');
OR:
p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
})
more than once in the same function and in other functions in the same file.
I need helpto simplify the attached code:
f.e
I 'm using this code:
<br /><center><img src="' + staticurl + 'img/errorsmall.gif" /><br /><h4>' + defaulterror + '</h4></center>
OR:
p.html('<br /><center><img src="' + staticurl + 'img/errorsmall.gif" /><br /><h4>' + defaulterror + '</h4></center>');
OR:
p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
})
more than once in the same function and in other functions in the same file.
// JavaScript Document
var p = $("#popuploader");
var staticurl = $('#msg_staticurl').attr('title');
var defaulterror = $('#msg_defaulterror').attr('title');
var globalprice = function () {
p.dialog({
autoOpen: false,
bgiframe: true,
title: "test",
width: 420,
height: 300
});
p.dialog("open");
var d = $("#formitems");
var c = d.serialize();
p.html('<br><br><center><img src="' + staticurl + 'img/chef.gif" border=0 /></center>');
$.post("myactionpage.cfm", c, function (g, ts) {
if (ts == 'success') {
if (g) {
if ($.trim(g) == 'true') {
} else {
p.html('<br /><center><img src="' + staticurl + 'img/errorsmall.gif" /><br /><h4>' + defaulterror + '</h4></center>');
p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
})
}
} else {
p.html('<br /><center><img src="' + staticurl + 'img/errorsmall.gif" /><br /><h4>' + defaulterror + '</h4></center>');
p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
})
}
} else {
p.html('<br /><center><img src="' + staticurl + 'img/errorsmall.gif" /><br /><h4>' + defaulterror + '</h4></center>');
p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
})
}
})
};
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
7-
5
12 Comments
Try this (haven't tested it, but it looks right and should work for you)...if not, then post error if possible.
Only part I'm unsure about is the dialogVar that I created. Might have the double- and single-quotes off.
Only part I'm unsure about is the dialogVar that I created. Might have the double- and single-quotes off.
// JavaScript Document
var p = $("#popuploader");
var staticurl = $('#msg_staticurl').attr('title');
var defaulterror = $('#msg_defaulterror').attr('title');
var htmlVar = "<br /><center><img src=" + staticurl + "img/errorsmall.gif /><br /><h4>" + defaulterror + "</h4></center>";
var dialogVar = "option, buttons, {" +
"End: function () {" +
"p.empty();" +
"$(this).dialog('close');" +
"$(this).dialog('empty');" +
"}" +
"}";
var globalprice = function () {
p.dialog({
autoOpen: false,
bgiframe: true,
title: "test",
width: 420,
height: 300
});
p.dialog("open");
var d = $("#formitems");
var c = d.serialize();
p.html('<br><br><center><img src="' + staticurl + 'img/chef.gif" border=0 /></center>');
$.post("myactionpage.cfm", c, function (g, ts) {
if (ts == 'success') {
if (g) {
if ($.trim(g) == 'true') {
} else {
p.html(htmlVar);
p.dialog(dialogVar)
}
} else {
p.html(htmlVar);
p.dialog(dialogVar)
}
} else {
p.html(htmlVar);
p.dialog(dialogVar)
}
})
};
Hi Element1910
The dialogVar is not working.
I willtry tomake some tests with the double- and single-quotes
The dialogVar is not working.
I willtry tomake some tests with the double- and single-quotes
Yeah, figured that it might not work with the quotes where they are. My apologies. When I get to work this morning, I'll try to help figure out that portion of it :)
Just thought of something....try this:
// JavaScript Document
var p = $("#popuploader");
var staticurl = $('#msg_staticurl').attr('title');
var defaulterror = $('#msg_defaulterror').attr('title');
var htmlVar = "<br /><center><img src=" + staticurl + "img/errorsmall.gif /><br /><h4>" + defaulterror + "</h4></center>";
var dialgVar = tempfunction () {p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
});};
var globalprice = function () {
p.dialog({
autoOpen: false,
bgiframe: true,
title: "test",
width: 420,
height: 300
});
p.dialog("open");
var d = $("#formitems");
var c = d.serialize();
p.html('<br><br><center><img src="' + staticurl + 'img/chef.gif" border=0 /></center>');
$.post("myactionpage.cfm", c, function (g, ts) {
if (ts == 'success') {
if (g) {
if ($.trim(g) == 'true') {
} else {
p.html(htmlVar);
p.dialog(dialogVar)
}
} else {
p.html(htmlVar);
p.dialog(dialogVar)
}
} else {
p.html(htmlVar);
p.dialog(dialogVar)
}
})
};
Wait...errr...scratch that...try this:
// JavaScript Document
var p = $("#popuploader");
var staticurl = $('#msg_staticurl').attr('title');
var defaulterror = $('#msg_defaulterror').attr('title');
var htmlVar = "<br /><center><img src=" + staticurl + "img/errorsmall.gif /><br /><h4>" + defaulterror + "</h4></center>";
var dialgVar = tempfunction () {p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
});};
var globalprice = function () {
p.dialog({
autoOpen: false,
bgiframe: true,
title: "test",
width: 420,
height: 300
});
p.dialog("open");
var d = $("#formitems");
var c = d.serialize();
p.html('<br><br><center><img src="' + staticurl + 'img/chef.gif" border=0 /></center>');
$.post("myactionpage.cfm", c, function (g, ts) {
if (ts == 'success') {
if (g) {
if ($.trim(g) == 'true') {
} else {
p.html(htmlVar);
dialgVar();
}
} else {
p.html(htmlVar);
dialgVar();
}
} else {
p.html(htmlVar);
dialgVar();
}
})
};
If that doesn't work...try this:
// JavaScript Document
var p = $("#popuploader");
var staticurl = $('#msg_staticurl').attr('title');
var defaulterror = $('#msg_defaulterror').attr('title');
var htmlVar = "<br /><center><img src=" + staticurl + "img/errorsmall.gif /><br /><h4>" + defaulterror + "</h4></center>";
var dialgVar = function () {p.dialog("option", "buttons", {
End: function () {
p.empty();
$(this).dialog("close");
$(this).dialog("empty");
}
});};
var globalprice = function () {
p.dialog({
autoOpen: false,
bgiframe: true,
title: "test",
width: 420,
height: 300
});
p.dialog("open");
var d = $("#formitems");
var c = d.serialize();
p.html('<br><br><center><img src="' + staticurl + 'img/chef.gif" border=0 /></center>');
$.post("myactionpage.cfm", c, function (g, ts) {
if (ts == 'success') {
if (g) {
if ($.trim(g) == 'true') {
} else {
p.html(htmlVar);
dialgVar();
}
} else {
p.html(htmlVar);
dialgVar();
}
} else {
p.html(htmlVar);
dialgVar();
}
})
};
Featured Post
We value your feedback.
Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
Suggested Solutions
| Title | # Comments | Views | Activity |
|---|---|---|---|
| dynamic created check uncheck boxes | 6 | 54 | |
| Duplicate Elements with JS / jQuery | 3 | 39 | |
| How does this modal gets closed? | 6 | 42 | |
| How do I Evaluate an expression using OR in jquery | 16 | 20 |
I have answered several questions lately that were solved utilizing the power of jQuery's AJAX functions, so I thought I would write an article demonstrating the ease of use.
Why should I use jQuery as opposed to regular JavaScript?
Now I know…
How to build a simple, quick and effective accordion menu using just 15 lines of jQuery and 2 css classes
The viewer will learn how to dynamically set the form action using jQuery.
The viewer will learn the basics of jQuery, including how to invoke it on a web page.
Reference your jQuery libraries: (CODE)
Include your new external js/jQuery file: (CODE)
Write your first lines of code to setup your site for jQuery.: (CODE)
Suggested Courses
Course of the Month1 day, 19 hours left to enroll
710 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.