Make a Subform Field Required

gigifarrow
gigifarrow used Ask the Experts™
on
I Have a form that is in a  tab format.

One of the tab pages is a subform. On save I have some fields  that are required before it will save. I need it to also  make fields  required on the subform but the code is not working.
Any experts know what im doing wrong? here is the code:
 
(frmInductionChecks) is the name of the subform.
(frmMain)is the name of the main form.
(Date of Induction) is the name of the control.

 If IsNull(Me!frmInductionChecks.Form![Date of Induction]) Then
  MsgBox "You must provide a value for Perform Date of Induction."
  Me.Me!frmInductionChecks.Form![Date of Induction].SetFocus
     Cancel = True
     Exit Sub
 End If


 If IsNull(Me.Text562) Then
     MsgBox "You must provide a value for Perform Fire Turret Runout Reading."
     Me.Text562.SetFocus
     Cancel = True
     Exit Sub
 End If
Comment
Watch Question

Do more with

Expert Office
EXPERT OFFICE® is a registered trademark of EXPERTS EXCHANGE®
mbizupNerd
Most Valuable Expert 2012
Top Expert 2013
Commented:
Where is your code located?

Put it in the BeforeUpdate event of the main form if it is not there already.  Also your subform reference is not quite correct.  Try this:

 If "" & Me.frmInductionChecks.Form.[Date of Induction] = "" Then
  MsgBox "You must provide a value for Perform Date of Induction."
  Me.frmInductionChecks.Form.[Date of Induction].SetFocus
     Cancel = True
     Exit Sub
 End If


 If "" & Me.Text562 = "" Then
     MsgBox "You must provide a value for Perform Fire Turret Runout Reading."
     Me.Text562.SetFocus
     Cancel = True
     Exit Sub
 End If

Open in new window

Author

Commented:
My code is on save record that is where all the append quieries are .
It will not append unless all these field are filled up.

if I put it on before update it will allow the user to contintinue. and still save the record.

 when i put it on save  button it wont save until the fields are field out.


thank you for the help and your time I will try this.


The message pops up I hit okay but it will not let you fill in the blank I have it on before update like u said
mbizupNerd
Most Valuable Expert 2012
Top Expert 2013

Commented:
Can you post a sample database?
Success in ‘20 With a Profitable Pricing Strategy

Do you wonder if your IT business is truly profitable or if you should raise your prices? Learn how to calculate your overhead burden using our free interactive tool and use it to determine the right price for your IT services. Start calculating Now!

Author

Commented:
That is okay it is working fine , but how could i do it so i dont have to write every control down in a subform?

Dim ctl As Control
    For Each ctl In Me.Controls
       If IsNull(ctl) Then
           MsgBox ctl.Name & " Is Empty, Please enter a Value.", vbCritical
           'Controls(ctl.Name).SetFocus
           Exit Sub
        End If
  ' Next ctl
mbizupNerd
Most Valuable Expert 2012
Top Expert 2013

Commented:
For each ctl in Me.subformname.form.controls

Etc...
Owner, Dev-Soln LLC
Most Valuable Expert 2014
Top Expert 2010
Commented:
1.  recommend you adopt the syntax that mbizup used to test whether the control is empty.  Your syntax will only identify those that are null, not those that are an empty string "".  By concatenating an empty string to the controls value, and testing to see if the result is still an empty string, you will identify both NULLs and empty strings.

2.  And if you have some fields in the subform that are not required, then one technique is to add something to the Tag property of the controls that are (I set Tag to "Req"), then modify the loop to include a check for the Tag property

3.  Lastly, I have not checked all versions of Access, but some will not allow you to directly set the focus to a control on a subform without first setting the focus to that form, so I added a line for that as well
Dim ctl As Control
    For Each ctl In Me.subformControlName.Controls
       If ("" & ctl.Value  = "") AND (ctrl.Tag = "Req") Then
           MsgBox ctl.Name & " Is Empty, Please enter a Value.", vbCritical
           me.subformcontrolName.form.setfocus
           me.subformcontrolname.form.controls(ctrl.Name).SetFocus
           Exit Sub
        End If
  Next ctl 

Open in new window

Author

Commented:
I tried what you said fyed but when i push save it doesnt work . I get no error message

Dim ctl As Control
    For Each ctl In Me.subformControlName.Controls
       If ("" & ctl.Value  = "") AND (ctrl.Tag = "Req") Then
           MsgBox ctl.Name & " Is Empty, Please enter a Value.", vbCritical
           me.subformcontrolName.form.setfocus
           me.subformcontrolname.form.controls(ctrl.Name).SetFocus
           Exit Sub
        End If
  Next ctl  



This code works:

 If "" & Me.frmInductionChecks.Form.[Date of Induction] = "" Then
  MsgBox "You must provide a value for Perform Date of Induction."
  Me.frmInductionChecks.Form.[Date of Induction].SetFocus
     Cancel = True
     Exit Sub
 End If

I would rathe r use the first one so that I dont have to write each field. Here is my database I had to delete alot of it
sendinhelprestriction.zip
Dale FyeOwner, Dev-Soln LLC
Most Valuable Expert 2014
Top Expert 2010

Commented:
try changing:

    For Each ctl In Me.subformControlName.Controls

to

    For Each ctl In Me.subformControlName.Form.Controls

Have you put a breakpoint in the code and stepped through it?  That is almost always the first step in debugging why something is not doing what you expect it to do.

Author

Commented:
No i didnt put a code to stepped through dont know how.

 I have been assigned to do access and I have only taken one class and that wasnt in depth. I will try this thank you.
Dale FyeOwner, Dev-Soln LLC
Most Valuable Expert 2014
Top Expert 2010

Commented:
gigi,

To create a breakpoint in your code, you open a code module and then left-click in the bar that runs from top to bottom, just to the left of the code window.  When you do this, you will see a red/brown dot appear in that bar (see attached).breakpointThen, when you run your application, when the code reaches the line that is highlighted by the dot, it will pause and display the code window.  You can then mouse over the code and see the values of the controls and variables in your code.  You use the F8 button to "step-through" your code, one line at a time. You can use the F5 button to resume your code execution when you are done stepping through the code.

Do more with

Expert Office
Submit tech questions to Ask the Experts™ at any time to receive solutions, advice, and new ideas from leading industry professionals.

Start 7-Day Free Trial