What's in the eBook?
- Full list of reasons for poor performance
- Ultimate measures to speed things up
- Primary web monitoring types
- KPIs you should be monitoring in order to increase your ROI
COURSE of the MONTH
10 days, 19 hours left to enrollBecome a Premium Member and unlock a new, free course in leading technologies each month.
Solved
row that should be excluded still shows up
Posted on 2012-12-31
disclaimer: I am a sql beginner working on concepts a bit beyond my comfort level. Stored Proc was not written by me.
I do not see why a row is showing up that should be hidden (based upon my where clause conditions)
Here is the Stored Proc:
(note: final result is a select on a temporary table, if that matters)
(note 2: The "ShowForm" column and the table AgentFormOverride were recently created by me and this is my attempt at integration into the existing Stored Proc below)
Here is the where clause (at the bottom of the stored proc) that (in my mind) should be excluding the last row:
WHERE
t.ShowForm = 1 and
t.DuplicatesAllowed = 1 AND NOT EXISTS
(SELECT * FROM @tblForms WHERE Sequence = t.Sequence AND DocumentID IS NULL)
The reason is that ShowForm is set to False (set to "0"). ShowForm type is bit.
Essentially, the last row in the result set should toggle (show or be hidden) as ShowForm is set to "show" or "not show".
Here is the result set:
I do not see why a row is showing up that should be hidden (based upon my where clause conditions)
Here is the Stored Proc:
(note: final result is a select on a temporary table, if that matters)
(note 2: The "ShowForm" column and the table AgentFormOverride were recently created by me and this is my attempt at integration into the existing Stored Proc below)
USE [PP]
GO
/****** Object: StoredProcedure [dbo].[AgentFormList_Get] Script Date: 12/31/2012 09:32:23 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER Procedure [dbo].[AgentFormList_Get]
@AssetID int,
@AssetSID int
AS
/*
////////////////////////////////////////////////////////////////////////////////////////////////////////////
Name: AgentFormList_Get
Date:
Purpose: Returns list of active forms for specified asset
Requested by: Madhav
Author: Paul Peterson
History
Date Modified by Requested by Modification/Description
--------------------------------------------------------------------------------------------------------------
11-30-2010 Paul Kade Don't return Reimbursement Policy for Saxon & Litton
3/3/2011 Bethb Madhav A part of the Document and Image Archive Process, changed proc to look at vDocument
////////////////////////////////////////////////////////////////////////////////////////////////////////////
*/
DECLARE @Colist bit,
@ExcludeValue int,
@DocExpReim int,
@Abbr varchar(10)
SELECT @Colist = dbo.ColistRequired(@AssetID, @AssetSID)
SELECT @ExcludeValue = CASE WHEN @Colist = 1 THEN 2 ELSE 1 END
SELECT @DocExpReim = dbo.GetLookupID('DocExpReim')
SELECT @Abbr = RTRIM(Merchant.Abbr)
FROM Asset
INNER JOIN Pool ON Asset.PoolID = Pool.PoolID AND Asset.PoolSID = Pool.PoolSID
INNER JOIN Merchant on Pool.MerchantID = Merchant.MerchantID AND Pool.MerchantSID = Merchant.MerchantSID
WHERE Asset.AssetID = @AssetID AND Asset.AssetSID = @AssetSID
DECLARE @tblForms table (
AgentFormListID int,
AgentFormListSID int,
FormTypeID int,
Sequence int,
FormName varchar(50),
AcceptanceReqd bit,
DuplicatesAllowed bit,
ExternalLink varchar(50),
CreateDt datetime,
ActionDate datetime,
AcceptDecline int,
AcceptedBy varchar(50),
DocumentID int,
DocumentSID int,
AssetTaskID int,
AssetTaskSID int,
AgentFormID int,
AgentFormSID int,
TaskCode varchar(50),
Active bit,
ShowForm bit
)
INSERT INTO @tblForms
SELECT AgentFormList.AgentFormListID, AgentFormList.AgentFormListSID,
FormTypeID, Sequence, FormName, AcceptanceReqd, DuplicatesAllowed, ExternalLink,
CreateDt, ActionDate, AcceptDecline, dbo.getUserName(AgentForm.AcceptUserID,AgentForm.AcceptUserSID) AS AcceptedBy, Document.DocumentID, Document.DocumentSID, AssetTaskID, AssetTaskSID,
AgentForm.AgentFormID, AgentForm.AgentFormSID, TaskCode, AgentForm.Active, afo.ShowForm
FROM AgentFormList
LEFT JOIN AgentForm on
AgentFormList.AgentFormListID = AgentForm.AgentFormListID
AND AgentFormList.AgentFormListSID = AgentForm.AgentFormListSID
AND AgentForm.AssetID = @AssetID AND AgentForm.AssetSID = @AssetSID
LEFT JOIN AgentFormOverride afo on
AgentFormList.AgentFormListID = afo.AgentFormListID
LEFT JOIN vDocument Document ON
AgentForm.DocumentID = Document.DocumentID
AND AgentForm.DocumentSID = Document.DocumentSID
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
INSERT INTO @tblForms
SELECT
AgentFormListID,
AgentFormListSID,
FormTypeID,
Sequence,
FormName,
AcceptanceReqd,
DuplicatesAllowed,
ExternalLink,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
TaskCode,
1,
ShowForm
FROM @tblForms t
WHERE
t.ShowForm = 1 and
t.DuplicatesAllowed = 1 AND NOT EXISTS
(SELECT * FROM @tblForms WHERE Sequence = t.Sequence AND DocumentID IS NULL)
SELECT * FROM @tblForms
order by sequence
Here is the where clause (at the bottom of the stored proc) that (in my mind) should be excluding the last row:
WHERE
t.ShowForm = 1 and
t.DuplicatesAllowed = 1 AND NOT EXISTS
(SELECT * FROM @tblForms WHERE Sequence = t.Sequence AND DocumentID IS NULL)
The reason is that ShowForm is set to False (set to "0"). ShowForm type is bit.
Essentially, the last row in the result set should toggle (show or be hidden) as ShowForm is set to "show" or "not show".
Here is the result set:
[X]
Welcome to Experts Exchange
Add your voice to the tech community where 5M+ people just like you are talking about what matters.
- Help others & share knowledge
- Earn cash & points
- Learn & ask questions
-
9
7
16 Comments
Active 3 days ago
There are at least two INSERT statements in your stored procedure. Is it possible the record is being added by the other?
I see what you mean.
Yes, I believe it is possible.
Assuming the record is being added by the FIRST insert, how do I prevent that?
Yes, I believe it is possible.
Assuming the record is being added by the FIRST insert, how do I prevent that?
Active 3 days ago
The obvious answer is to duplicate your criteria:
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN'))) AND t.ShowForm = 1
...
It's not possible for me to say whether or not that would have other repercussions, but it's easy enough to try and undo if it doesn't work the way you want.
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN'))) AND t.ShowForm = 1
...
It's not possible for me to say whether or not that would have other repercussions, but it's easy enough to try and undo if it doesn't work the way you want.
I did try that.
But since none of the other rows returned will have a value of 0 for "ShowForm" (since they don't exist in AgentFormOverride) the only row that shows up is the one in AgentFormOverride.
Does that make sense?
But since none of the other rows returned will have a value of 0 for "ShowForm" (since they don't exist in AgentFormOverride) the only row that shows up is the one in AgentFormOverride.
Does that make sense?
Active 3 days ago
How about:
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN'))) AND t.ShowForm <> 0
...
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN'))) AND t.ShowForm <> 0
...
It still shows up in the results with this change...but there is only ONE row returned instead of 21 rows.
When I make this change is it ONLY in the top WHERE clause and NOT in the bottom WHERE clause?
When I make this change is it ONLY in the top WHERE clause and NOT in the bottom WHERE clause?
Maybe this can help:
This version actually returns 0 rows:
Whereas. . .
This version returns 21 rows, and the last row still shows up:
This version actually returns 0 rows:
USE [PP]
GO
/****** Object: StoredProcedure [dbo].[AgentFormList_Get] Script Date: 12/31/2012 12:54:23 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER Procedure [dbo].[AgentFormList_Get]
@AssetID int,
@AssetSID int
AS
/*
////////////////////////////////////////////////////////////////////////////////////////////////////////////
Name: AgentFormList_Get
Date:
Purpose: Returns list of active forms for specified asset
Requested by: Madhav
Author: Paul Peterson
History
Date Modified by Requested by Modification/Description
--------------------------------------------------------------------------------------------------------------
11-30-2010 Paul Kade Don't return Reimbursement Policy for Saxon & Litton
3/3/2011 Bethb Madhav A part of the Document and Image Archive Process, changed proc to look at vDocument
////////////////////////////////////////////////////////////////////////////////////////////////////////////
*/
DECLARE @Colist bit,
@ExcludeValue int,
@DocExpReim int,
@Abbr varchar(10)
SELECT @Colist = dbo.ColistRequired(@AssetID, @AssetSID)
SELECT @ExcludeValue = CASE WHEN @Colist = 1 THEN 2 ELSE 1 END
SELECT @DocExpReim = dbo.GetLookupID('DocExpReim')
SELECT @Abbr = RTRIM(Merchant.Abbr)
FROM Asset
INNER JOIN Pool ON Asset.PoolID = Pool.PoolID AND Asset.PoolSID = Pool.PoolSID
INNER JOIN Merchant on Pool.MerchantID = Merchant.MerchantID AND Pool.MerchantSID = Merchant.MerchantSID
WHERE Asset.AssetID = @AssetID AND Asset.AssetSID = @AssetSID
DECLARE @tblForms table (
AgentFormListID int,
AgentFormListSID int,
FormTypeID int,
Sequence int,
FormName varchar(50),
AcceptanceReqd bit,
DuplicatesAllowed bit,
ExternalLink varchar(50),
CreateDt datetime,
ActionDate datetime,
AcceptDecline int,
AcceptedBy varchar(50),
DocumentID int,
DocumentSID int,
AssetTaskID int,
AssetTaskSID int,
AgentFormID int,
AgentFormSID int,
TaskCode varchar(50),
Active bit,
ShowForm bit
)
INSERT INTO @tblForms y
SELECT AgentFormList.AgentFormListID, AgentFormList.AgentFormListSID,
FormTypeID, Sequence, FormName, AcceptanceReqd, DuplicatesAllowed, ExternalLink,
CreateDt, ActionDate, AcceptDecline, dbo.getUserName(AgentForm.AcceptUserID,AgentForm.AcceptUserSID) AS AcceptedBy, Document.DocumentID, Document.DocumentSID, AssetTaskID, AssetTaskSID,
AgentForm.AgentFormID, AgentForm.AgentFormSID, TaskCode, AgentForm.Active, afo.ShowForm
FROM AgentFormList
LEFT JOIN AgentForm on
AgentFormList.AgentFormListID = AgentForm.AgentFormListID
AND AgentFormList.AgentFormListSID = AgentForm.AgentFormListSID
AND AgentForm.AssetID = @AssetID AND AgentForm.AssetSID = @AssetSID
LEFT JOIN AgentFormOverride afo on
AgentFormList.AgentFormListID = afo.AgentFormListID
LEFT JOIN vDocument Document ON
AgentForm.DocumentID = Document.DocumentID
AND AgentForm.DocumentSID = Document.DocumentSID
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
AND y.ShowForm <> 0
INSERT INTO @tblForms
SELECT
AgentFormListID,
AgentFormListSID,
FormTypeID,
Sequence,
FormName,
AcceptanceReqd,
DuplicatesAllowed,
ExternalLink,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
TaskCode,
1,
ShowForm
FROM @tblForms t
WHERE
t.DuplicatesAllowed = 1 AND NOT EXISTS
(SELECT * FROM @tblForms WHERE Sequence = t.Sequence AND DocumentID IS NULL)
SELECT * FROM @tblForms
order by sequence
Whereas. . .
This version returns 21 rows, and the last row still shows up:
USE [PP]
GO
/****** Object: StoredProcedure [dbo].[AgentFormList_Get] Script Date: 12/31/2012 12:54:23 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER Procedure [dbo].[AgentFormList_Get]
@AssetID int,
@AssetSID int
AS
/*
////////////////////////////////////////////////////////////////////////////////////////////////////////////
Name: AgentFormList_Get
Date:
Purpose: Returns list of active forms for specified asset
Requested by: Madhav
Author: Paul Peterson
History
Date Modified by Requested by Modification/Description
--------------------------------------------------------------------------------------------------------------
11-30-2010 Paul Kade Don't return Reimbursement Policy for Saxon & Litton
3/3/2011 Bethb Madhav A part of the Document and Image Archive Process, changed proc to look at vDocument
////////////////////////////////////////////////////////////////////////////////////////////////////////////
*/
DECLARE @Colist bit,
@ExcludeValue int,
@DocExpReim int,
@Abbr varchar(10)
SELECT @Colist = dbo.ColistRequired(@AssetID, @AssetSID)
SELECT @ExcludeValue = CASE WHEN @Colist = 1 THEN 2 ELSE 1 END
SELECT @DocExpReim = dbo.GetLookupID('DocExpReim')
SELECT @Abbr = RTRIM(Merchant.Abbr)
FROM Asset
INNER JOIN Pool ON Asset.PoolID = Pool.PoolID AND Asset.PoolSID = Pool.PoolSID
INNER JOIN Merchant on Pool.MerchantID = Merchant.MerchantID AND Pool.MerchantSID = Merchant.MerchantSID
WHERE Asset.AssetID = @AssetID AND Asset.AssetSID = @AssetSID
DECLARE @tblForms table (
AgentFormListID int,
AgentFormListSID int,
FormTypeID int,
Sequence int,
FormName varchar(50),
AcceptanceReqd bit,
DuplicatesAllowed bit,
ExternalLink varchar(50),
CreateDt datetime,
ActionDate datetime,
AcceptDecline int,
AcceptedBy varchar(50),
DocumentID int,
DocumentSID int,
AssetTaskID int,
AssetTaskSID int,
AgentFormID int,
AgentFormSID int,
TaskCode varchar(50),
Active bit,
ShowForm bit
)
INSERT INTO @tblForms y
SELECT AgentFormList.AgentFormListID, AgentFormList.AgentFormListSID,
FormTypeID, Sequence, FormName, AcceptanceReqd, DuplicatesAllowed, ExternalLink,
CreateDt, ActionDate, AcceptDecline, dbo.getUserName(AgentForm.AcceptUserID,AgentForm.AcceptUserSID) AS AcceptedBy, Document.DocumentID, Document.DocumentSID, AssetTaskID, AssetTaskSID,
AgentForm.AgentFormID, AgentForm.AgentFormSID, TaskCode, AgentForm.Active, afo.ShowForm
FROM AgentFormList
LEFT JOIN AgentForm on
AgentFormList.AgentFormListID = AgentForm.AgentFormListID
AND AgentFormList.AgentFormListSID = AgentForm.AgentFormListSID
AND AgentForm.AssetID = @AssetID AND AgentForm.AssetSID = @AssetSID
LEFT JOIN AgentFormOverride afo on
AgentFormList.AgentFormListID = afo.AgentFormListID
LEFT JOIN vDocument Document ON
AgentForm.DocumentID = Document.DocumentID
AND AgentForm.DocumentSID = Document.DocumentSID
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
INSERT INTO @tblForms
SELECT
AgentFormListID,
AgentFormListSID,
FormTypeID,
Sequence,
FormName,
AcceptanceReqd,
DuplicatesAllowed,
ExternalLink,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
TaskCode,
1,
ShowForm
FROM @tblForms t
WHERE
t.DuplicatesAllowed = 1 AND NOT EXISTS
(SELECT * FROM @tblForms WHERE Sequence = t.Sequence AND DocumentID IS NULL)
AND t.ShowForm <> 0
SELECT * FROM @tblForms
order by sequence
Active 3 days ago
How about this change to the first query. Note you're checking the ShowForm field of AgentFormOverride this time. Whether you should be checking for "<> 0" or " =1" I can't say, but this is probably the better syntax. Leave the second query as it was originally.
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
AND afo.ShowForm <> 0
...
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
AND afo.ShowForm <> 0
...
Now no rows return. Did I do it correctly?
Screenshot of what was returned in Management Studio query window:
USE [PP]
GO
/****** Object: StoredProcedure [dbo].[AgentFormList_Get] Script Date: 12/31/2012 12:54:23 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER Procedure [dbo].[AgentFormList_Get]
@AssetID int,
@AssetSID int
AS
/*
////////////////////////////////////////////////////////////////////////////////////////////////////////////
Name: AgentFormList_Get
Date:
Purpose: Returns list of active forms for specified asset
Requested by: Madhav
Author: Paul Peterson
History
Date Modified by Requested by Modification/Description
--------------------------------------------------------------------------------------------------------------
11-30-2010 Paul Kade Don't return Reimbursement Policy for Saxon & Litton
3/3/2011 Bethb Madhav A part of the Document and Image Archive Process, changed proc to look at vDocument
////////////////////////////////////////////////////////////////////////////////////////////////////////////
*/
DECLARE @Colist bit,
@ExcludeValue int,
@DocExpReim int,
@Abbr varchar(10)
SELECT @Colist = dbo.ColistRequired(@AssetID, @AssetSID)
SELECT @ExcludeValue = CASE WHEN @Colist = 1 THEN 2 ELSE 1 END
SELECT @DocExpReim = dbo.GetLookupID('DocExpReim')
SELECT @Abbr = RTRIM(Merchant.Abbr)
FROM Asset
INNER JOIN Pool ON Asset.PoolID = Pool.PoolID AND Asset.PoolSID = Pool.PoolSID
INNER JOIN Merchant on Pool.MerchantID = Merchant.MerchantID AND Pool.MerchantSID = Merchant.MerchantSID
WHERE Asset.AssetID = @AssetID AND Asset.AssetSID = @AssetSID
DECLARE @tblForms table (
AgentFormListID int,
AgentFormListSID int,
FormTypeID int,
Sequence int,
FormName varchar(50),
AcceptanceReqd bit,
DuplicatesAllowed bit,
ExternalLink varchar(50),
CreateDt datetime,
ActionDate datetime,
AcceptDecline int,
AcceptedBy varchar(50),
DocumentID int,
DocumentSID int,
AssetTaskID int,
AssetTaskSID int,
AgentFormID int,
AgentFormSID int,
TaskCode varchar(50),
Active bit,
ShowForm bit
)
INSERT INTO @tblForms
SELECT AgentFormList.AgentFormListID, AgentFormList.AgentFormListSID,
FormTypeID, Sequence, FormName, AcceptanceReqd, DuplicatesAllowed, ExternalLink,
CreateDt, ActionDate, AcceptDecline, dbo.getUserName(AgentForm.AcceptUserID,AgentForm.AcceptUserSID) AS AcceptedBy, Document.DocumentID, Document.DocumentSID, AssetTaskID, AssetTaskSID,
AgentForm.AgentFormID, AgentForm.AgentFormSID, TaskCode, AgentForm.Active, afo.ShowForm
FROM AgentFormList
LEFT JOIN AgentForm on
AgentFormList.AgentFormListID = AgentForm.AgentFormListID
AND AgentFormList.AgentFormListSID = AgentForm.AgentFormListSID
AND AgentForm.AssetID = @AssetID AND AgentForm.AssetSID = @AssetSID
LEFT JOIN AgentFormOverride afo on
AgentFormList.AgentFormListID = afo.AgentFormListID
LEFT JOIN vDocument Document ON
AgentForm.DocumentID = Document.DocumentID
AND AgentForm.DocumentSID = Document.DocumentSID
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
AND afo.ShowForm <> 0
SELECT * FROM @tblForms
order by sequence
INSERT INTO @tblForms
SELECT
AgentFormListID,
AgentFormListSID,
FormTypeID,
Sequence,
FormName,
AcceptanceReqd,
DuplicatesAllowed,
ExternalLink,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
TaskCode,
1,
ShowForm
FROM @tblForms t
WHERE
t.DuplicatesAllowed = 1 AND NOT EXISTS
(SELECT * FROM @tblForms WHERE Sequence = t.Sequence AND DocumentID IS NULL)
SELECT * FROM @tblForms
order by sequence
Screenshot of what was returned in Management Studio query window:
Active 3 days ago
It looks as if you did what I asked. What if you try the corollary:
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
AND afo.ShowForm = 1
...
...
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
AND afo.ShowForm = 1
...
Same result. It's as if the WHERE clause addition is being ignored.
I checked AgentFormOverride table and it has ONE entry and ShowForm is set to 0 (zero). I was beginning to wonder if the row had been deleted! But no, it's still there:
I checked AgentFormOverride table and it has ONE entry and ShowForm is set to 0 (zero). I was beginning to wonder if the row had been deleted! But no, it's still there:
I just want to mention that if I REMOVE the WHERE clause restriction, the row shows up (the bottom row)
Here is a screenshot:
Here is the T-SQL that generates the screen above:
Here is a screenshot:
Here is the T-SQL that generates the screen above:
USE [PP]
GO
/****** Object: StoredProcedure [dbo].[TomTest] Script Date: 01/02/2013 11:14:29 ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER Procedure [dbo].[TomTest]
@AssetID int,
@AssetSID int
AS
/*
////////////////////////////////////////////////////////////////////////////////////////////////////////////
Name: AgentFormList_Get
Date:
Purpose: Returns list of active forms for specified asset
Requested by: Madhav
Author: Paul Peterson
History
Date Modified by Requested by Modification/Description
--------------------------------------------------------------------------------------------------------------
11-30-2010 Paul Kade Don't return Reimbursement Policy for Saxon & Litton
3/3/2011 Bethb Madhav A part of the Document and Image Archive Process, changed proc to look at vDocument
////////////////////////////////////////////////////////////////////////////////////////////////////////////
*/
DECLARE @Colist bit,
@ExcludeValue int,
@DocExpReim int,
@Abbr varchar(10)
SELECT @Colist = dbo.ColistRequired(@AssetID, @AssetSID)
SELECT @ExcludeValue = CASE WHEN @Colist = 1 THEN 2 ELSE 1 END
SELECT @DocExpReim = dbo.GetLookupID('DocExpReim')
SELECT @Abbr = RTRIM(Merchant.Abbr)
FROM Asset
INNER JOIN Pool ON Asset.PoolID = Pool.PoolID AND Asset.PoolSID = Pool.PoolSID
INNER JOIN Merchant on Pool.MerchantID = Merchant.MerchantID AND Pool.MerchantSID = Merchant.MerchantSID
WHERE Asset.AssetID = @AssetID AND Asset.AssetSID = @AssetSID
DECLARE @tblForms table (
AgentFormListID int,
AgentFormListSID int,
FormTypeID int,
Sequence int,
FormName varchar(50),
AcceptanceReqd bit,
DuplicatesAllowed bit,
ExternalLink varchar(50),
CreateDt datetime,
ActionDate datetime,
AcceptDecline int,
AcceptedBy varchar(50),
DocumentID int,
DocumentSID int,
AssetTaskID int,
AssetTaskSID int,
AgentFormID int,
AgentFormSID int,
TaskCode varchar(50),
Active bit,
ShowForm bit
)
INSERT INTO @tblForms
SELECT AgentFormList.AgentFormListID, AgentFormList.AgentFormListSID,
FormTypeID, Sequence, FormName, AcceptanceReqd, DuplicatesAllowed, ExternalLink,
CreateDt, ActionDate, AcceptDecline, dbo.getUserName(AgentForm.AcceptUserID,AgentForm.AcceptUserSID) AS AcceptedBy, Document.DocumentID, Document.DocumentSID, AssetTaskID, AssetTaskSID,
AgentForm.AgentFormID, AgentForm.AgentFormSID, TaskCode, AgentForm.Active, afo.ShowForm
FROM AgentFormList
LEFT JOIN AgentForm on
AgentFormList.AgentFormListID = AgentForm.AgentFormListID
AND AgentFormList.AgentFormListSID = AgentForm.AgentFormListSID
AND AgentForm.AssetID = @AssetID AND AgentForm.AssetSID = @AssetSID
LEFT JOIN AgentFormOverride afo on
AgentFormList.AgentFormListID = afo.AgentFormListID
LEFT JOIN vDocument Document ON
AgentForm.DocumentID = Document.DocumentID
AND AgentForm.DocumentSID = Document.DocumentSID
WHERE ColistFlag <> @ExcludeValue
AND (FormTypeID <> @DocExpReim OR (FormTypeID = @DocExpReim AND @Abbr NOT IN ('LIT','SXN')))
SELECT * FROM @tblForms
order by sequence
INSERT INTO @tblForms
SELECT
AgentFormListID,
AgentFormListSID,
FormTypeID,
Sequence,
FormName,
AcceptanceReqd,
DuplicatesAllowed,
ExternalLink,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
Null,
TaskCode,
1,
ShowForm
FROM @tblForms t
WHERE
t.DuplicatesAllowed = 1 AND NOT EXISTS
(SELECT * FROM @tblForms WHERE Sequence = t.Sequence AND DocumentID IS NULL)
SELECT * FROM @tblForms
order by sequence
Active 3 days ago
What happens if you skip the second SELECT and INSERT statements altogether? You can just wrap them in
/*
...
*/
to comment them out.
/*
...
*/
to comment them out.
Featured Post
At Percona’s web store you can order full Percona Database Performance Audit in minutes. Find out the health of your database, and how to improve it. Pay online with a credit card. Improve your database performance now!
Question has a verified solution.
If you are experiencing a similar issue, please ask a related question
This article shows gives you an overview on SQL Server 2016 row level security. You will also get to know the usages of row-level-security and how it works
In this article we will learn how to fix “Cannot install SQL Server 2014 Service Pack 2: Unable to install windows installer msi file” error ?
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
Viewers will learn how to use the INSERT statement to insert data into their tables. It will also introduce the NULL statement, to show them what happens when no value is giving for any given column.
Suggested Courses
Course of the Month10 days, 19 hours left to enroll
770 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.