Solved

C++: Switch Statement

Posted on 2013-01-05
1
508 Views
Last Modified: 2013-01-05
Hello everyone, I recently started learning about the C++ Programming Language through online tutorials and would like some help with a basic program that I have written. The program is a simple calculator that will perform a desired operation and then ask for the user's input on what to do next. Here is my code below:

#include <cstdlib>
#include <iostream>

using namespace std;

float addition(float value1, float value2)
{
    return value1 + value2;  
}

float subtraction (float value1, float value2)
{
    return value1 - value2;  
}

float multiplication (float value1, float value2)
{
    return value1 * value2;  
}

float division (float value1, float value2)
{
    return value1 / value2;  
}


int main(int argc, char *argv[])
{
    float number1;
    float number2;
    int choice;
    cout << "Would you like to: \n\nAdd (1) \nSubtract (2) \nMultiply (3) \nDivide (4) \nQuit (5) \n" << endl;
    cout << "Choice: ";
    cin >> choice;
    while (true)
    {
        switch (choice)
        {
           case 1:
                {
               //Addition
               cout << "You are adding two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << addition(number1, number2) << endl;
               system("PAUSE");
               }
           case 2:
               {
               //Subtraction
               cout << "You are subtracting two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << subtraction(number1, number2) << endl;
               system("PAUSE");
               }
           case 3:
               {
               //Multiplication
               cout << "You are multiplying two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << multiplication(number1, number2) << endl;
               system("PAUSE");
               }
           case 4:
               {
               //Division
               cout << "You are dividing two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << division(number1, number2) << endl;
               system("PAUSE");
               }
           case 5:
               {
               cout << "Goodbye!";
               system("PAUSE");
               return 0;      
               }
           default:
               cout << "Please enter a value between 1 and 5";
        }    
    }
    system("PAUSE");
    return 0;
}

The "quit" option that I have put in works fine, but the other cases have issues. All of my cases except the default case will start with the desired operation, but will then immediately jump over to the following operation afterwards (i.e. pressing 1 will start the addition, but will go straight to asking for subtraction when it finishes). The default case does not loop back to the question that is asked at the beginning of the program. Any help is appreciated.
0
Comment
Question by:Paul_ATL
1 Comment
 
LVL 86

Accepted Solution

by:
jkr earned 200 total points
ID: 38747384
>>but will then immediately jump over to the following operation afterwards

Yes, you have to terminate each 'case:' branch with a 'break' statement, i.e.

    while (true)
    {
        switch (choice)
        {
           case 1:
                {
               //Addition
               cout << "You are adding two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << addition(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 2:
               {
               //Subtraction
               cout << "You are subtracting two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << subtraction(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 3:
               {
               //Multiplication
               cout << "You are multiplying two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << multiplication(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 4:
               {
               //Division
               cout << "You are dividing two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << division(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 5:
               {
               cout << "Goodbye!";
               system("PAUSE");
               return 0;      
               }
               break; // <-----
           default:
               cout << "Please enter a value between 1 and 5";
        }    
    }

Open in new window

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Often, when implementing a feature, you won't know how certain events should be handled at the point where they occur and you'd rather defer to the user of your function or class. For example, a XML parser will extract a tag from the source code, wh…
IntroductionThis article is the second in a three part article series on the Visual Studio 2008 Debugger.  It provides tips in setting and using breakpoints. If not familiar with this debugger, you can find a basic introduction in the EE article loc…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now