Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

C++: Switch Statement

Posted on 2013-01-05
1
Medium Priority
?
530 Views
Last Modified: 2013-01-05
Hello everyone, I recently started learning about the C++ Programming Language through online tutorials and would like some help with a basic program that I have written. The program is a simple calculator that will perform a desired operation and then ask for the user's input on what to do next. Here is my code below:

#include <cstdlib>
#include <iostream>

using namespace std;

float addition(float value1, float value2)
{
    return value1 + value2;  
}

float subtraction (float value1, float value2)
{
    return value1 - value2;  
}

float multiplication (float value1, float value2)
{
    return value1 * value2;  
}

float division (float value1, float value2)
{
    return value1 / value2;  
}


int main(int argc, char *argv[])
{
    float number1;
    float number2;
    int choice;
    cout << "Would you like to: \n\nAdd (1) \nSubtract (2) \nMultiply (3) \nDivide (4) \nQuit (5) \n" << endl;
    cout << "Choice: ";
    cin >> choice;
    while (true)
    {
        switch (choice)
        {
           case 1:
                {
               //Addition
               cout << "You are adding two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << addition(number1, number2) << endl;
               system("PAUSE");
               }
           case 2:
               {
               //Subtraction
               cout << "You are subtracting two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << subtraction(number1, number2) << endl;
               system("PAUSE");
               }
           case 3:
               {
               //Multiplication
               cout << "You are multiplying two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << multiplication(number1, number2) << endl;
               system("PAUSE");
               }
           case 4:
               {
               //Division
               cout << "You are dividing two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << division(number1, number2) << endl;
               system("PAUSE");
               }
           case 5:
               {
               cout << "Goodbye!";
               system("PAUSE");
               return 0;      
               }
           default:
               cout << "Please enter a value between 1 and 5";
        }    
    }
    system("PAUSE");
    return 0;
}

The "quit" option that I have put in works fine, but the other cases have issues. All of my cases except the default case will start with the desired operation, but will then immediately jump over to the following operation afterwards (i.e. pressing 1 will start the addition, but will go straight to asking for subtraction when it finishes). The default case does not loop back to the question that is asked at the beginning of the program. Any help is appreciated.
0
Comment
Question by:Paul_ATL
1 Comment
 
LVL 86

Accepted Solution

by:
jkr earned 800 total points
ID: 38747384
>>but will then immediately jump over to the following operation afterwards

Yes, you have to terminate each 'case:' branch with a 'break' statement, i.e.

    while (true)
    {
        switch (choice)
        {
           case 1:
                {
               //Addition
               cout << "You are adding two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << addition(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 2:
               {
               //Subtraction
               cout << "You are subtracting two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << subtraction(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 3:
               {
               //Multiplication
               cout << "You are multiplying two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << multiplication(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 4:
               {
               //Division
               cout << "You are dividing two numbers, enter the first number. \n Number 1: ";
               cin >> number1;
               cout << "Enter the second number. \n Number 2: ";
               cin >> number2;
               cout << "The answer is: " << division(number1, number2) << endl;
               system("PAUSE");
               }
               break; // <-----
           case 5:
               {
               cout << "Goodbye!";
               system("PAUSE");
               return 0;      
               }
               break; // <-----
           default:
               cout << "Please enter a value between 1 and 5";
        }    
    }

Open in new window

0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

  Included as part of the C++ Standard Template Library (STL) is a collection of generic containers. Each of these containers serves a different purpose and has different pros and cons. It is often difficult to decide which container to use and …
This article will show you some of the more useful Standard Template Library (STL) algorithms through the use of working examples.  You will learn about how these algorithms fit into the STL architecture, how they work with STL containers, and why t…
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
The viewer will be introduced to the technique of using vectors in C++. The video will cover how to define a vector, store values in the vector and retrieve data from the values stored in the vector.
Suggested Courses

824 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question