• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 3262
  • Last Modified:

Unable to index into an object of type System.String

Hello, I am getting the following error and not sure how to fix it.
11
10
9
8
7
6
5
4
3
2
1
0
Type the new TELEPHONE Number: 3033334444
BINGO NO -
Unable to index into an object of type System.String.
At C:\scripts\AD\loops.ps1:71 char:3
+         $InputTelephoneNumber[$counter] = "-"
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [], RuntimeException
    + FullyQualifiedErrorId : CannotIndex

Open in new window

And this is the code:
[string]$InputTelephoneNumber = Read-Host 'Type the new TELEPHONE Number'
for($counter = 11; $counter -gt ($InputTelephoneNumber.Count - 2); $counter--) {	 
	 if (($counter -eq "7") -and ($InputTelephoneNumber[$counter] -ne "-")) {
	    write-host "BINGO NO -"
		$InputTelephoneNumber[$counter] = "-"
	 }
 }

Open in new window

Thanks for your help
0
namerg
Asked:
namerg
2 Solutions
 
LearnctxEngineerCommented:
I'm not really sure what you're trying to achieve here, but if it is pattern matching on the input of a phone number look at using regular expressions. But, looking at your code as is, you're using $InputTelephoneNumber.count. This will always return 1, because the string only contains 1 object, the string. So When you finally get $counter to be less than 1, and -2, it is -1. So you are effectively doing:

$InputTelephoneNumber[-1]

Open in new window

This is an invalid index for an array. So, maybe you mean to use $InputTelephoneNumber.Length instead, which is the length of the string. I don't think this will achieve whatever it is you're trying to do either, what are you actually trying to check? If a certain character in the string is a dash/hyphen?
0
 
Meir RivkinFull stack Software EngineerCommented:
can u explain first what is the purpose of your code?
0
 
namergSystems AdministratorAuthor Commented:
Well, $InputTelephoneNumber  is an array once you enter the phone number right ?

So, if I enter 3034445555

3 -> Position 0
0 -> Position 1
3 -> Position 2
4 -> Position 3
.
.
5 -> Position 9

Correct ?

So, if I want to change the value of Position 3 for (-) and Position 7 for (-), how would i do it ?

In other words how do i replace values in an array ?

Thanks,
0
Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
Meir RivkinFull stack Software EngineerCommented:
use index to change array values:

position 3:
$InputTelephoneNumber[2] = "-"

position 7:
$InputTelephoneNumber[6] = "-"
0
 
namergSystems AdministratorAuthor Commented:
Hmm, but can I replace the number [2] by a counter $i or $counter ? Like my code reflects it ?
0
 
Meir RivkinFull stack Software EngineerCommented:
Yes use $counter as the array index
0
 
Meir RivkinFull stack Software EngineerCommented:
What do u expect the phone to look like?
For example
3034445555

Should be
303-444-5555

Am i correct?
0
 
Meir RivkinFull stack Software EngineerCommented:
In any case you dont have to loop the number.
With one line of code you can reformat it.
0
 
namergSystems AdministratorAuthor Commented:
Yes, you are correct.

The thing is in another language your treat the array as I said, but in powershell is different and is hard to understand the logic for the array if i want to change values if i want to treat the index as a counter..
0
 
Meir RivkinFull stack Software EngineerCommented:
To format a number the same way you want you do the following:
$telephoneNumber = {0:###-###-####} -f [double]$telephoneNumber
0
 
SubsunCommented:
Why don't you simply insert the the '-'?
$InputTelephoneNumber.Insert(3,"-").Insert(7,"-")
0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now