• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 275
  • Last Modified:

cannot make it run as a batch file

I am able to run the following from the command prompt with success, but I cannot make it run as a batch file any help making this run from a .bat file is appreciated

CD /D "D: \PDFBills"
set "source=D: \PDFBills\UnZip"
set "targetRoot=D:\ PDFBills\MonthlyPDFBills"
for %F in ("%source%\*") do (
  for /f "tokens=1,2,3 delims=/ " %A in ("%~tF") do (
    if not exist "%targetRoot%\%C\%A" mkdir "%targetRoot%\%C\%A"
    move "%~fF" "%targetRoot%\%C\%A"
  )
)

Lori
0
NLITech
Asked:
NLITech
  • 2
1 Solution
 
Steve KnightIT ConsultancyCommented:
You have a space in the source/dest line for starters, but most of all any % syntax within for commands need to be doubled to %% in batch files.  Try this for starters.

Steve

@echo off
CD /D "D:\PDFBills"
set source=D:\PDFBills\UnZip
set targetRoot=D:\PDFBills\MonthlyPDFBills
for %%F in ("%source%\*") do (
  for /f "tokens=1,2,3 delims=/ " %%A in ("%%~tF") do (
    if not exist "%targetRoot%\%%C\%%A" mkdir "%targetRoot%\%%C\%%A"
    move "%%~fF" "%targetRoot%\%%C\%%A"
  )
)

Open in new window


Steve
0
 
NLITechAuthor Commented:
Perfect! Thank you.
0
 
Steve KnightIT ConsultancyCommented:
no problem
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now