Solved

C++, copy constructor

Posted on 2013-01-17
3
436 Views
Last Modified: 2013-01-18
Hello experts, please have a look at the following code:


#include <iostream>

using namespace std;

class Line
{
   public:
      int getLength( void );
      Line( int len );             // simple constructor, headers only
      Line( const Line &obj);      // copy constructor, headers only
      ~Line();                      // destructor

   private:
      int *ptr;
};

Line::Line(int len)
{
    cout << "Normal constructor allocating ptr" << endl;
    // allocate memory for the pointer;
    ptr = new int;
    *ptr = len;
}

Line::Line(const Line &obj)
{
    cout << "Copy constructor allocating ptr." << endl;
    ptr = new int;
   *ptr = *obj.ptr; // copy the value
}

Line::~Line(void)
{
    cout << "Freeing memory!" << endl;
    delete ptr;
}
int Line::getLength( void )
{
    return *ptr;
}

void display(Line obj)
{
   cout << "Length of line : " << obj.getLength() <<endl;
}

// Main function for the program
int main( )
{
   Line line(10);

   display(line);//****** why does it call copy constructor here? ******

   return 0;
}

I do not understand why calling 'display' with 'line' as argument makes a call to constructor here...

Any help?

Thank you

panJames
0
Comment
Question by:panJames
  • 3
3 Comments
 
LVL 22

Accepted Solution

by:
ambience earned 500 total points
ID: 38788153
because

void display(Line obj)

does not take Line by reference. It takes it by value so a copy happens
0
 
LVL 22

Expert Comment

by:ambience
ID: 38788160
void display(Line& obj)

should not invoke the constructor.

Looking at the purpose of display its better to have it like

void display(const Line& obj)

but that wont compile unless you also change

int getLength( void ) const;

int Line::getLength( void ) const
{
    return *ptr;
}
0
 
LVL 22

Expert Comment

by:ambience
ID: 38788176
As a general rule, always consider passing objects as const references unless there is a compelling reason not to do so. Passing it by reference ensures there is no overhead of copying and const ensure there are no side-affects because you can only access const methods and data on the object.
0

Featured Post

Efficient way to get backups off site to Azure

This user guide provides instructions on how to deploy and configure both a StoneFly Scale Out NAS Enterprise Cloud Drive virtual machine and Veeam Cloud Connect in the Microsoft Azure Cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In days of old, returning something by value from a function in C++ was necessarily avoided because it would, invariably, involve one or even two copies of the object being created and potentially costly calls to a copy-constructor and destructor. A…
Many modern programming languages support the concept of a property -- a class member that combines characteristics of both a data member and a method.  These are sometimes called "smart fields" because you can add logic that is applied automaticall‚Ķ
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.
The viewer will learn how to use the return statement in functions in C++. The video will also teach the user how to pass data to a function and have the function return data back for further processing.

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question