Solved

C++, copy constructor

Posted on 2013-01-17
3
441 Views
Last Modified: 2013-01-18
Hello experts, please have a look at the following code:


#include <iostream>

using namespace std;

class Line
{
   public:
      int getLength( void );
      Line( int len );             // simple constructor, headers only
      Line( const Line &obj);      // copy constructor, headers only
      ~Line();                      // destructor

   private:
      int *ptr;
};

Line::Line(int len)
{
    cout << "Normal constructor allocating ptr" << endl;
    // allocate memory for the pointer;
    ptr = new int;
    *ptr = len;
}

Line::Line(const Line &obj)
{
    cout << "Copy constructor allocating ptr." << endl;
    ptr = new int;
   *ptr = *obj.ptr; // copy the value
}

Line::~Line(void)
{
    cout << "Freeing memory!" << endl;
    delete ptr;
}
int Line::getLength( void )
{
    return *ptr;
}

void display(Line obj)
{
   cout << "Length of line : " << obj.getLength() <<endl;
}

// Main function for the program
int main( )
{
   Line line(10);

   display(line);//****** why does it call copy constructor here? ******

   return 0;
}

I do not understand why calling 'display' with 'line' as argument makes a call to constructor here...

Any help?

Thank you

panJames
0
Comment
Question by:panJames
  • 3
3 Comments
 
LVL 22

Accepted Solution

by:
ambience earned 500 total points
ID: 38788153
because

void display(Line obj)

does not take Line by reference. It takes it by value so a copy happens
0
 
LVL 22

Expert Comment

by:ambience
ID: 38788160
void display(Line& obj)

should not invoke the constructor.

Looking at the purpose of display its better to have it like

void display(const Line& obj)

but that wont compile unless you also change

int getLength( void ) const;

int Line::getLength( void ) const
{
    return *ptr;
}
0
 
LVL 22

Expert Comment

by:ambience
ID: 38788176
As a general rule, always consider passing objects as const references unless there is a compelling reason not to do so. Passing it by reference ensures there is no overhead of copying and const ensure there are no side-affects because you can only access const methods and data on the object.
0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Templates For Beginners Or How To Encourage The Compiler To Work For You Introduction This tutorial is targeted at the reader who is, perhaps, familiar with the basics of C++ but would prefer a little slower introduction to the more ad…
IntroductionThis article is the second in a three part article series on the Visual Studio 2008 Debugger.  It provides tips in setting and using breakpoints. If not familiar with this debugger, you can find a basic introduction in the EE article loc…
The goal of the tutorial is to teach the user how to use functions in C++. The video will cover how to define functions, how to call functions and how to create functions prototypes. Microsoft Visual C++ 2010 Express will be used as a text editor an…
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.

713 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question