Solved

insert into sql server vb.net

Posted on 2013-01-18
2
718 Views
Last Modified: 2013-01-18
Hello there. This is my question. After searching the web I found this code for inserting a new record into an SQL Server db, from a control behind VB.NET




            Dim con As New SqlConnection
            Dim cmd As New SqlCommand
            Try
                con.ConnectionString = "Data Source=CDPC1093\CDPC1093;Initial Catalog=tba210;Integrated Security=True"
                con.Open()
                cmd.Connection = con
                cmd.CommandText = "INSERT INTO T_USR(N_USER_NO, S_NAME,S_USER_TYPE,D_REG,D_PERIOD_ST,D_PERIOD_END) VALUES (" & Gedetineerde_systeem_ID.Text & ", '" & Achternaam.Text & "' ,2," & Today & "," & Today & "," & DateAdd(DateInterval.Year, 1, Today)
                cmd.ExecuteNonQuery()

            Catch ex As Exception
                MessageBox.Show("Error while inserting record on table..." & ex.Message, "Insert Records")
            Finally
                con.Close()
            End Try


The fact is that I am always getting back the error message, meaning the insertion was not successful.

Could any of you guys give me a hand on this? What am I doing wrong or letting behind?
0
Comment
Question by:LUISOFO
2 Comments
 
LVL 143

Accepted Solution

by:
Guy Hengel [angelIII / a3] earned 500 total points
ID: 38792956
you would need to post the error message you get, to start the troubleshooting.
I presume you get a syntax error, by inspecting the commandtext you will see that it's not correct.

try:
cmd.CommandText = "INSERT INTO T_USR(N_USER_NO, S_NAME,S_USER_TYPE,D_REG,D_PERIOD_ST,D_PERIOD_END) VALUES (" & Gedetineerde_systeem_ID.Text & ", '" & Achternaam.Text & "' ,2,getdate(),getdate(), dateadd(year,1,getdate()) ) "

Open in new window



first, you where missing the closing ) for the VALUES() part
second, Today will be a "date", but by your " string " & " string" it will be no more a "date" for teh sql (see also this article: http://www.experts-exchange.com/Database/Miscellaneous/A_1499-DATE-and-TIME-don%27t-be-scared-and-do-it-right-the-first-time.html )
finally,  you should read up on how to create a SqlCommand with Parameters to avoid SQL injection
0
 

Author Closing Comment

by:LUISOFO
ID: 38793030
Right to the point. Thanks for your input
0

Featured Post

NAS Cloud Backup Strategies

This article explains backup scenarios when using network storage. We review the so-called “3-2-1 strategy” and summarize the methods you can use to send NAS data to the cloud

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Introduction In this tutorial, I'll explain how to create an animated progress meter in a wireframe prototype developed using Axure RP 7.0 - a leading prototyping tool for designing web sites and software. (For more information about Axure and gett…
The Delta outage: 650 cancelled flights, more than 1200 delayed flights, thousands of frustrated customers, tens of millions of dollars in damages – plus untold reputational damage to one of the world’s most trusted airlines. All due to a catastroph…
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.
Via a live example, show how to shrink a transaction log file down to a reasonable size.

839 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question