Solved

Simple C++ question

Posted on 2013-01-28
2
184 Views
Last Modified: 2013-01-28
Hello experts,

please have a look at the code below:

#include <iostream>
#include <cstring>
using namespace std;

//tworze klase, ktora umozliwi dodawanie stringow oraz
//zapis stringow w postaci zmienna = "jakis string";

class String{
	char * string;

public:
	String(const char* aChar){
		string = new char[????];   how can I determine the length of aChar here?
		strcpy(string, aChar);
		cout<<string<<endl;
	}

	~String(){
		delete string;
		string = 0;
	}

	char * getString(){
		return string;
	}

	void operator = (char * aString){
		strcpy(string, aString);
	}

	friend ostream& operator<< (ostream & aOstream, const String & aString);

};

ostream& operator<< (ostream & aOstream, const String & aString){
	aOstream << aString.string;
	return aOstream;
}

int main(){
	String string1("kdjshfgkljs");
	String string2("skldjhfls");

	cout << string1 << string2;

	return 0;
}

Open in new window


Thank you

panJames
0
Comment
Question by:panJames
  • 2
2 Comments
 
LVL 30

Accepted Solution

by:
Zoppo earned 500 total points
ID: 38827233
Hi panJames,

you can use strlen, i.e.:
string = new char[strlen(aChar)+1]; // need to add 1 for terminating NUL character

Open in new window

Hope that helps,

ZOPPO
0
 
LVL 30

Expert Comment

by:Zoppo
ID: 38830005
BTW, two more points:

1. In the constructor you should check if the passed string is a valid pointer.
2. The assignment operator isn't correctly implemented, it doesn't (re-)allocate the memory needed.

So I would change these two functions to look like this:
	String(const char* aChar){
		if ( aChar != 0)
		{
			string = new char[strlen(aChar)];
			strcpy(string, aChar);
			cout<<string<<endl;
		}
		else
		{
			string = 0;
			cout << "empty string"<< endl;
		}
	}

	void operator = (char * aString)
	{
		delete [] string;
		string = 0;

		if ( aString != 0)
		{
			string = new char[strlen(aString);
			strcpy(string, aString);
		}
	}

Open in new window

0

Featured Post

Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

Join & Write a Comment

  Included as part of the C++ Standard Template Library (STL) is a collection of generic containers. Each of these containers serves a different purpose and has different pros and cons. It is often difficult to decide which container to use and …
Introduction This article is a continuation of the C/C++ Visual Studio Express debugger series. Part 1 provided a quick start guide in using the debugger. Part 2 focused on additional topics in breakpoints. As your assignments become a little more …
The viewer will learn how to pass data into a function in C++. This is one step further in using functions. Instead of only printing text onto the console, the function will be able to perform calculations with argumentents given by the user.
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.

705 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now