Solved

Simple C++ question

Posted on 2013-01-28
2
187 Views
Last Modified: 2013-01-28
Hello experts,

please have a look at the code below:

#include <iostream>
#include <cstring>
using namespace std;

//tworze klase, ktora umozliwi dodawanie stringow oraz
//zapis stringow w postaci zmienna = "jakis string";

class String{
	char * string;

public:
	String(const char* aChar){
		string = new char[????];   how can I determine the length of aChar here?
		strcpy(string, aChar);
		cout<<string<<endl;
	}

	~String(){
		delete string;
		string = 0;
	}

	char * getString(){
		return string;
	}

	void operator = (char * aString){
		strcpy(string, aString);
	}

	friend ostream& operator<< (ostream & aOstream, const String & aString);

};

ostream& operator<< (ostream & aOstream, const String & aString){
	aOstream << aString.string;
	return aOstream;
}

int main(){
	String string1("kdjshfgkljs");
	String string2("skldjhfls");

	cout << string1 << string2;

	return 0;
}

Open in new window


Thank you

panJames
0
Comment
Question by:panJames
  • 2
2 Comments
 
LVL 31

Accepted Solution

by:
Zoppo earned 500 total points
ID: 38827233
Hi panJames,

you can use strlen, i.e.:
string = new char[strlen(aChar)+1]; // need to add 1 for terminating NUL character

Open in new window

Hope that helps,

ZOPPO
0
 
LVL 31

Expert Comment

by:Zoppo
ID: 38830005
BTW, two more points:

1. In the constructor you should check if the passed string is a valid pointer.
2. The assignment operator isn't correctly implemented, it doesn't (re-)allocate the memory needed.

So I would change these two functions to look like this:
	String(const char* aChar){
		if ( aChar != 0)
		{
			string = new char[strlen(aChar)];
			strcpy(string, aChar);
			cout<<string<<endl;
		}
		else
		{
			string = 0;
			cout << "empty string"<< endl;
		}
	}

	void operator = (char * aString)
	{
		delete [] string;
		string = 0;

		if ( aString != 0)
		{
			string = new char[strlen(aString);
			strcpy(string, aString);
		}
	}

Open in new window

0

Featured Post

ScreenConnect 6.0 Free Trial

At ScreenConnect, partner feedback doesn't fall on deaf ears. We collected partner suggestions off of their virtual wish list and transformed them into one game-changing release: ScreenConnect 6.0. Explore all of the extras and enhancements for yourself!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In days of old, returning something by value from a function in C++ was necessarily avoided because it would, invariably, involve one or even two copies of the object being created and potentially costly calls to a copy-constructor and destructor. A…
What is C++ STL?: STL stands for Standard Template Library and is a part of standard C++ libraries. It contains many useful data structures (containers) and algorithms, which can spare you a lot of the time. Today we will look at the STL Vector. …
The viewer will learn how to clear a vector as well as how to detect empty vectors in C++.
The viewer will be introduced to the member functions push_back and pop_back of the vector class. The video will teach the difference between the two as well as how to use each one along with its functionality.

803 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question