Simple C++ question

Hello experts,

please have a look at the code below:

#include <iostream>
#include <cstring>
using namespace std;

//tworze klase, ktora umozliwi dodawanie stringow oraz
//zapis stringow w postaci zmienna = "jakis string";

class String{
	char * string;

public:
	String(const char* aChar){
		string = new char[????];   how can I determine the length of aChar here?
		strcpy(string, aChar);
		cout<<string<<endl;
	}

	~String(){
		delete string;
		string = 0;
	}

	char * getString(){
		return string;
	}

	void operator = (char * aString){
		strcpy(string, aString);
	}

	friend ostream& operator<< (ostream & aOstream, const String & aString);

};

ostream& operator<< (ostream & aOstream, const String & aString){
	aOstream << aString.string;
	return aOstream;
}

int main(){
	String string1("kdjshfgkljs");
	String string2("skldjhfls");

	cout << string1 << string2;

	return 0;
}

Open in new window


Thank you

panJames
panJamesAsked:
Who is Participating?
 
ZoppoConnect With a Mentor Commented:
Hi panJames,

you can use strlen, i.e.:
string = new char[strlen(aChar)+1]; // need to add 1 for terminating NUL character

Open in new window

Hope that helps,

ZOPPO
0
 
ZoppoCommented:
BTW, two more points:

1. In the constructor you should check if the passed string is a valid pointer.
2. The assignment operator isn't correctly implemented, it doesn't (re-)allocate the memory needed.

So I would change these two functions to look like this:
	String(const char* aChar){
		if ( aChar != 0)
		{
			string = new char[strlen(aChar)];
			strcpy(string, aChar);
			cout<<string<<endl;
		}
		else
		{
			string = 0;
			cout << "empty string"<< endl;
		}
	}

	void operator = (char * aString)
	{
		delete [] string;
		string = 0;

		if ( aString != 0)
		{
			string = new char[strlen(aString);
			strcpy(string, aString);
		}
	}

Open in new window

0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.