Solved

Error Check before deleting folder

Posted on 2013-01-31
2
196 Views
Last Modified: 2013-02-01
I have a simple bash script that copies files from the local machine to a remote machine on a monthly basis for the purpose of backing them up. The host is SLES 11 and the remote backup machine is a Windows 2008 Server.

The script is straight forward: mount the remote directory on the Windows Server then copy the contents of a local folder to the remote server.  This works great but I then have to manually delete the local files after I have been verified they were copied.  

So to remove the need to "continually" manually check; I would like to implement some form of error checking into the script to insure the files have been copied and then after verifying, delete the local files.

What would be the easiest way to verify that the copy has run successfully and if the copy did not run at all or did not copy everything then DO NOT delete the local files?

My thoughts are to compare the local and mounted remote directory for size and number of files and if they do not match then do not delete.  I new to bash scripting - I was think maybe the diff command and du could be used to accomplish this?

Is there an easier way to go about this?

#!/bin/bash

todaysdate=$(date +"%Y-%m")
echo $todaydate
umount /mnt/dr
mount -t cifs -o username=xxx,password=xxxx //backupsrv/E /mnt/dr
mkdir /mnt/dr/export/$(hostname)/$todaysdate


echo "Starting copy..."
cd /data/localexport
find . -mtime +30 -exec /usr/local/bin/export-copy {} \;
echo "Finished copying."
echo

cd /
umount /mnt/dr 

Open in new window


export-copy script
#!/bin/bash

todaysdate=$(date +"%Y-%m")

echo "$1"
if [ -d "$1" ]
then
        echo "This is a directory and will not be processed"
else
        echo "Copying file..."
        cp --parents --preserve -a "$1" /mnt/dr/export/$(hostname)/$todaysdate
        #rm "$1"
fi

Open in new window

0
Comment
Question by:jwmcf1
2 Comments
 
LVL 14

Accepted Solution

by:
ThomasMcA2 earned 500 total points
ID: 38840549
Check the return code from the copy, and only delete when there are no errors:

cp --parents --preserve -a "$1" /mnt/dr/export/$(hostname)/$todaysdate

if [ "$?" = "0" ]; then
        rm "$1"
fi
0
 

Author Comment

by:jwmcf1
ID: 38844604
well that was easy! thanks.
0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

Suggested Solutions

Over the years I've spent many an hour playing on hardened, DMZ'd servers, with only a sub-set of the usual GNU toy's to keep me company; frequently I've needed to save and send log or data extracts from these server back to my PC, or to others, and…
Utilizing an array to gracefully append to a list of EmailAddresses
Learn several ways to interact with files and get file information from the bash shell. ls lists the contents of a directory: Using the -a flag displays hidden files: Using the -l flag formats the output in a long list: The file command gives us mor…
Access reports are powerful and flexible. Learn how to create a query and then a grouped report using the wizard. Modify the report design after the wizard is done to make it look better. There will be another video to explain how to put the final p…

758 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now