Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

Second half of Powershell Script Ignored

Posted on 2013-01-31
3
Medium Priority
?
296 Views
Last Modified: 2013-02-01
My script writes the UserName from SQL records to a CSV file where the Disable date is less than my check date by 90 days.

After this portion is complete, I want to update the 'Completed' field to 'True' for these same records. The problem is that it appears that the second SqlQuery that does the update is just being ignored.

1. If I run the same Update statement at the top of the script in place of the Select statement, it works fine.
2. Placing obivous errors in the Update statement when it's at the bottom of the script, such as a fake table name, doesn't even generate an error.
3. I've used write-host to display everything and it's showing the correct info.

Thanks,

JB

$SQLServer = "Server"
$SQLDBName = "database"
$AttachmentPath = "C:\file.csv"

# Select records to CSV that are older than than 90 days and have not been processd

$d = (Get-Date).adddays(-90).ToString('yyyy-MM-dd')
$SqlQuery = "SELECT * from Test WHERE DisableDate < '$d' AND Completed='False'"

$SqlConnection = New-Object System.Data.SqlClient.SqlConnection
$SqlConnection.ConnectionString = "Server = $SQLServer; Database = $SQLDBName; Integrated Security = True"

#Instantiates the Command Object
$SqlCmd = New-Object System.Data.SqlClient.SqlCommand

#Command Text Using Variable
$SqlCmd.CommandText = $SqlQuery

#Create Connection
$SqlCmd.Connection = $SqlConnection

$SqlAdapter = New-Object System.Data.SqlClient.SqlDataAdapter
$SqlAdapter.SelectCommand = $SqlCmd

$DataSet = New-Object System.Data.DataSet
$SqlAdapter.Fill($DataSet) | Out-Null

#Populate Hash Table
$objTable = $DataSet.Tables[0]

#Populate Hash Table, and export to CSV File
#$DataSet.Tables[0] | Export-Csv -NoTypeInformation $AttachmentPath

#Populate Hash Table, export to CSV, and change column headers
$DataSet.Tables[0] | select @{l='Alias'; e={$_.Username}} | Export-Csv -NoTypeInformation $AttachmentPath

$SqlConnection.Close()

$SqlQuery2 = "Update Test SET Completed='True' WHERE DisableDate < '$d' AND Completed='False'"
# Write-Host "SqlQuery2: " $SqlQuery2
# Write-Host "Check Date: " $d

$SqlConnection2 = New-Object System.Data.SqlClient.SqlConnection
$SqlConnection2.ConnectionString = "Server = $SQLServer; Database = $SQLDBName; Integrated Security = True"

# Write-Host "SqlConnection2.ConnectionString: " $SqlConnection2.ConnectionString

#Instantiates the Command Object
$SqlCmd2 = New-Object System.Data.SqlClient.SqlCommand

#Command Text Using Variable
$SqlCmd2.CommandText = $SqlQuery2

#Create Connection
$SqlCmd2.Connection = $SqlConnection2

$SqlAdapter2 = New-Object System.Data.SqlClient.SqlDataAdapter
$SqlAdapter2.SelectCommand = $SqlCmd2

$SqlConnection2.Close()
0
Comment
Question by:JB4375
  • 2
3 Comments
 
LVL 16

Accepted Solution

by:
Rajitha Chimmani earned 2000 total points
ID: 38840511
Try to run the second set of actions to update in a separate script. Run the select script first and then update script. I guess its the problem with SQL connections to the table. I see you are closing the SQL connections. Still try running separately and see how it goes.
0
 
LVL 1

Author Comment

by:JB4375
ID: 38840571
Yeah.... that was my next step. I've got VBScripts that are 500 lines plus with a half dozen sub routines.

Not that it matters since these methods no longer work with exchange mail accounts. Still, it would seem that there would be a more efficient way.

If anyone can elaborate on how do this within the same script, I'd prefer that over having multiple scripts to do one task.

Thanks!!
0
 
LVL 1

Author Closing Comment

by:JB4375
ID: 38843545
Ok... so the answer was that I'd left the following two lines off the second portion of the script because I thought these two line pertained more to the setting up of the hash table.

$DataSet = New-Object System.Data.DataSet
$SqlAdapter.Fill($DataSet) | Out-Null

Thanks Raj!!
0

Featured Post

Ready for your healthcare security check-up?

In the past few years, healthcare organizations have become a prime target for advanced attacks. Does your organization have what it needs to defend itself? Schedule your healthcare security check-up today and download our free Healthcare Security Resource Kit today!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

A brief introduction to what I consider to be the best editor for PowerShell.
Windows 10 came with  a lot of built in applications, Some organisations leave them there, some will control them using GPO's. This Article is useful for those who do not want to have any applications in their image (example:me).
Exchange organizations may use the Journaling Agent of the Transport Service to archive messages going through Exchange. However, if the Transport Service is integrated with some email content management application (such as an anti-spam), the admin…
Loops Section Overview

877 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question