asked on

Query - Need Different Results

Select
LTRIM(RTRIM(UPPER(ISNULL(dbo.Street.Prefix_Full, '')))
+ ' ' + RTRIM(UPPER(ISNULL(dbo.Street.Street_Name, '')))
+ ' ' + RTRIM(UPPER((COALESCE(CASE WHEN dbo.Street.Suffix_Cnty IS NOT NULL THEN Suffix_Full
ELSE dbo.Street.Suffix_Bell
END, ''))))) AS Name
FROM dbo.Segment INNER JOIN dbo.Street ON dbo.Segment.Street_ID = dbo.Street.Street_ID
Order By Name

When Running this Query i get close to the right results but i need to tweak something. I'm stuck at this part.

Description
Suffix_Bell is the abbrviation of Suffix_Full.
Suffix_Cnty is also the abbrviation of Suffix_Full.
When Suffix_Bell is populated ( example: Rd(in Suffix_Bell) = Road(in Suffix_Full) Suffix_Cnty will be Null. and Vise Versa.

Suffix_Bell & Suffix_Cnty connot both be populated, its one or the other or niether.

The wierd part of this request is.

When Suffix_Cnty is not null i need to populate the Name field with
Prefix_Full + Street_Name + Suffix_Full (When Suffix_Cnty IS NOT NULL)

When Suffix_Bell is not null i need to populate the Name field with only
Prefix_Full + Street_Name. The Suffix_Bell Column gets put in the Type Field.
Which reading back i think i explained this part wrong to start. Sorry about that

Lowfatspread

do you mean this?

Select
 Upper(LTRIM(RTRIM(ISNULL(st.Prefix_Full, '')) 
+  ' ' +     RTRIM(ISNULL(st.Street_Name, '')) 
+ ' ' +    ltrim(rtrim(case when st.suffix_cnty is not null then suffix_full else '' end))) as Name
, case when st.suffix_cnty is not null then '' else suffix_bell end as type

      FROM dbo.Segment as seg
     INNER JOIN dbo.Street  as st
           ON seg.Street_ID = st.Street_ID
  Order By Name

Open in new window

if not please explain , with some example data....
and confirm suffix_full already contains the expansion of rd->road that doesn't require another lookup..

ASKER CERTIFIED SOLUTION

Guy Hengel [angelIII / a3]

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

awking00

Sample data and the expected results would be most helpful.

PtboGiser

ASKER

Angel
The results are showing me the attached document.
Line 229 - Allens Alley (This is proper) as Suffix_Cnty is not null
Line 223 -Alexander Street (Wrong) As Suffix _Cnty is null.
I having trouble understanding when its not pick the data properly.

I need Alexander Street to show only as Alexander which is the Prefix_Full + Street_Name Part. I DO NOT WANT THE STREET
Capture.PNG

PtboGiser

ASKER

Example Data Attached
Thx
Street.txt
Segment.txt

Lowfatspread

what does this give?

Select
 Upper(LTRIM(RTRIM(ISNULL(st.Prefix_Full, '')) 
+  ' ' +     RTRIM(ISNULL(st.Street_Name, '')) 
+ ' ' +    ltrim(rtrim(case when nullif(st.suffix_cnty,' ') is not null then suffix_full else '' end))) as Name
, case when st.suffix_cnty is not null then '' else suffix_bell end as type

      FROM dbo.Segment as seg
     INNER JOIN dbo.Street  as st
           ON seg.Street_ID = st.Street_ID
  Order By Name

Open in new window

ps we can't work just from the output you need to show us the actual data rows...
... how do you know what comprises(source data) line 223 as opposed to line 222?

Lowfatspread

ok how are we supposed to read your street and segment files? what is the layout?

PtboGiser

ASKER

It would not let me load them as a dbf. Sorry let me try a Excel file.

PtboGiser

ASKER

Excel Versions
Segment.xlsx
Street.xlsx

Lowfatspread

try this

Select
 Upper(LTRIM(RTRIM(ISNULL(st.Prefix_Full, '')) 
+  ' ' +     RTRIM(ISNULL(st.Street_Name, '')) 
+ ' ' +    ltrim(rtrim(case when st.suffix_cnty is not null then suffix_full when st.suffix_bell is not null then '' else suffix_full end))) as Name
, case when st.suffix_cnty is not null then '' else suffix_bell end as type

      FROM dbo.Segment as seg
     INNER JOIN dbo.Street  as st
           ON seg.Street_ID = st.Street_ID
  Order By Name

Open in new window

please confim that any offending rows do actually contain NULLS or otherwise (i.e could a row actually contain a text N/A?)

PtboGiser

ASKER

Currently rows without a value are null. I would prefer not using n/a if i can help it

PtboGiser

ASKER

Image attached, Sorry Rows are BLANK is it possible they can be blank but not be a NULL value?
Maybe thats my problem.
nulls.PNG

Lowfatspread

Blank is not NULL
try this

Select
 Upper(LTRIM(RTRIM(ISNULL(st.Prefix_Full, '')) 
+  ' ' +     RTRIM(ISNULL(st.Street_Name, '')) 
+ ' ' +    ltrim(rtrim(case when nullif(st.suffix_cnty,'') is not null then suffix_full when nullif(st.suffix_bell,'') is not null then '' else suffix_full end))) as Name
, case when nullif(st.suffix_cnty,'') is not null then '' else suffix_bell end as type

      FROM dbo.Segment as seg
     INNER JOIN dbo.Street  as st
           ON seg.Street_ID = st.Street_ID
  Order By Name

Open in new window

but really you need to police your data better if spaces/blank is not valid then you should force it to null.... maybe you should consider triggers or constraints to enforce your data integrity... otherwise you need excessive use of functions like nullif ,, which will have an impact on query performance..

PtboGiser

ASKER

I am new to SQL Server picking up where someone before me left off and took another job. Thanks for the tips i will look into forcing the values to be a null.

PtboGiser

ASKER

Thx, Problem was my blank Field where not a null value.