[Last Call] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 340
  • Last Modified:

Oracle syntax

I cant figure out what is wrong with this procedure???

CREATE OR REPLACE PROCEDURE ANET.SP_TEST_WARNING

IS

BEGIN
    DECLARE
        nWarning Number;
        nViolation Number;

    BEGIN
        Select (SELECT TO_NUMBER(PROPERTY_VALUE) FROM OMNI_PROPERTIES WHERE PROPERTY_NAME='TPSA_BLANK_WARN_DAYS') INTO nWarning  'Warnings',
        (SELECT TO_NUMBER(PROPERTY_VALUE) FROM OMNI_PROPERTIES WHERE PROPERTY_NAME='TPSA_MUST_RECONCILE_DAYS_BLANK') INTO nViolation 'Violation',
        CREATION_DATE, SYSDATE        
        FROM TPSA_MAIN;
    END;  
   
   EXCEPTION
     WHEN NO_DATA_FOUND THEN
       NULL;
     WHEN OTHERS THEN
       -- Consider logging the error and then re-raise
       RAISE;
END SP_TEST_WARNING;
/


I get this error message
[Warning] ORA-24344: success with compilation error
11/126  PL/SQL: ORA-00923: FROM keyword not found where expected
11/5    PL/SQL: SQL Statement ignored
 (1: 0): Warning: compiled but with compilation errors
0
jknj72
Asked:
jknj72
1 Solution
 
flow01Commented:
DECLARE
        nWarning Number;
        nViolation Number;
       dCreation_date;
 BEGIN
        Select (SELECT TO_NUMBER(PROPERTY_VALUE) FROM OMNI_PROPERTIES WHERE PROPERTY_NAME='TPSA_BLANK_WARN_DAYS') Warnings,
        (SELECT TO_NUMBER(PROPERTY_VALUE) FROM OMNI_PROPERTIES WHERE PROPERTY_NAME='TPSA_MUST_RECONCILE_DAYS_BLANK')  Violation,
        CREATION_DATE --, SYSDATE        
         INTO nWarning , nViolation ,   dCreation_date
        FROM TPSA_MAIN;
    END;  


-- but this will only get you creation date from tpsa_main , the other values are fixed
0
 
awking00Commented:
A number of issues -
declare is not used in a stored procedure and, even if it were, would come before the begin statement, so the beginning of your procedure should look something like

CREATE OR REPLACE PROCEDURE ANET.SP_TEST_WARNING
IS
       nWarning Number;
       nViolation Number;
BEGIN

In PL/SQL all selects must be selected into a variable and the syntax is
SELECT some column(s)
INTO some variable(s)
FROM some table(s)
WHERE some condition(s)

Additionally, the select must only return one value.
Your select statement is also selecting a creation_date and sysdate, which would also need to be inserted into some variable.

I don't know what it is that you want your procedure to accomplish, since there doesn't seem to appear there is any data manipulation. Perhaps you can provide a more detailed description of what you want from the procedure with some sample data and expected results.
0
 
jknj72Author Commented:
Heres what Im trying to do

I need to write a query that has to check to see if there should be a violation or warning being reutrned in a procedure

Here what I have. I have a program that creates permits and when a permit is created you have to reconcile that permit before you receive a violation email. Also, you will be sent a warning email before you violate.  There is a table that holds the numbers that are set for a violation and a number for a warning..

So if warnings are set to 3 and a violation is set to 30 the logic would be
IF SYSDATE > (CREATE_DATE + Violation(30)) send out a violation
IF SYSDATE BETWEEN (CREATE_DATE + (Violation(30) - Warning(3)) AND  (CREATE_DATE + Violation(30)) then send out warnings

Can you help me write this in a view. The view would return all the permits that have Warnings and or Violations
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
awking00Commented:
Can you provide a description of the omni_properties and tpsa_main tables?
0
 
jknj72Author Commented:
I was able to do it with this

SELECT TRUNC(CREATION_DATE) as CREATION_DATE, EMPLOYEE_NUMBER
FROM TPSA_MAIN WHERE
TRUNC(SYSDATE) BETWEEN (TRUNC(CREATION_DATE) + (SELECT TO_NUMBER(PROPERTY_VALUE) FROM OMNI_PROPERTIES WHERE PROPERTY_NAME='TPSA_MUST_RECONCILE_DAYS_BLANK') - (SELECT TO_NUMBER(PROPERTY_VALUE) FROM OMNI_PROPERTIES WHERE PROPERTY_NAME='TPSA_BLANK_WARN_DAYS')) --typically 30-3
AND (TRUNC(CREATION_DATE) + (SELECT TO_NUMBER(PROPERTY_VALUE) FROM OMNI_PROPERTIES WHERE PROPERTY_NAME='TPSA_MUST_RECONCILE_DAYS_BLANK'))--typically 30
AND STATUS IN('INCOMPLETE', 'BLANK');


I was trying to put them in variables for readability and ease of use but I guess this will work fine unless you have any suggestions?

Thanks
0
 
PortletPaulCommented:
Hard to comment, but there are 3 subqueries that you assume will return 1 record (and no more than 1 record) if you get null or more than 1 row in any of these you are in trouble.

SELECT TRUNC(CREATION_DATE) AS CREATION_DATE, EMPLOYEE_NUMBER
FROM   TPSA_MAIN
WHERE  TRUNC(SYSDATE)   BETWEEN (TRUNC(CREATION_DATE) +
                                                       (SELECT TO_NUMBER(PROPERTY_VALUE)
                                                       FROM    OMNI_PROPERTIES
                                                       WHERE   PROPERTY_NAME='TPSA_MUST_RECONCILE_DAYS_BLANK'
                                                       )
                                                       -
                                                       (SELECT TO_NUMBER(PROPERTY_VALUE)
                                                       FROM    OMNI_PROPERTIES
                                                       WHERE   PROPERTY_NAME='TPSA_BLANK_WARN_DAYS'
                                                       )
                                                       ) --typically 30-3
                        AND
                               (
                                  TRUNC(CREATION_DATE) +
                                  (SELECT TO_NUMBER(PROPERTY_VALUE)
                                  FROM    OMNI_PROPERTIES
                                  WHERE   PROPERTY_NAME='TPSA_MUST_RECONCILE_DAYS_BLANK'
                                  )
                               )--typically 30
AND    STATUS IN('INCOMPLETE',
                 'BLANK');

Open in new window

for me: It was interesting to see sysdate being the subject of a between;
keep in mind the "between ... and ..." is the equivalent of:

[info] >= [low boundary] and [info] <= [high boundary]

i.e. both boundary dates ate INCLUDED
0
 
jknj72Author Commented:
that will do it
0

Featured Post

Efficient way to get backups off site to Azure

This user guide provides instructions on how to deploy and configure both a StoneFly Scale Out NAS Enterprise Cloud Drive virtual machine and Veeam Cloud Connect in the Microsoft Azure Cloud.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now