Solved

Telephone and Email form validation, javascript

Posted on 2013-02-04
9
319 Views
Last Modified: 2013-02-08
I have a form that has two fields that I need to validate so the user can't submit if they don't enter the correct information for a telephone and email address.  This is my script that the values get passed to.  I'm not quite sure how to get the telephone and email address validation incorporated in this.
function doCreateUser(edit) {
   var chk = 0;
   chkArray = new Array();
   var chkFNm = document.frmEdit.edtFNm.value;
   var chkLNm = document.frmEdit.edtLNm.value;
   var chkNmExt = document.frmEdit.edtNmExt.value;
   var chkComPhn = document.frmEdit.edtComPhn.value;
   var chkComEml = document.frmEdit.edtComEml.value;
   var chkTZone = document.frmEdit.edtTZone.value;   
   var chkFacID = document.frmEdit.edtFacID.value;
   var chkRole = document.frmEdit.edtRole.value;
   if (chkFNm == "") {
      chk++;
      chkArray[chk] = "A valid 'user first name' is required";}
   if (chkLNm == "") {
      chk++;
      chkArray[chk] = "A valid 'user last name' is required";}
   if (chkComEml == "") {
      chk++;
      chkArray[chk] = "A valid 'email address' is required";}
   if (chkTZone == "") {
      chk++;
      chkArray[chk] = "A valid 'user time zone' selection is required";}	  
   if (chkFacID == "") {
      chk++;
      chkArray[chk] = "A valid 'facility' selection is required";}
   if (chkRole == "") {
      chk++;
      chkArray[chk] = "A valid 'role' selection is required";}
   if (chk > 0) {
      var chk_txt = "Errror! The form cannot be submitted due to the following:\n\n";
      for (c = 1; c <= chk; c++) {
         chk_txt = chk_txt + c + ") " + chkArray[c] + "\n";}
      alert(chk_txt);}
   else {
      document.frmAddUser.fldNewEdit.value = edit;
      document.frmAddUser.fldNewFNm.value = chkFNm;
      document.frmAddUser.fldNewLNm.value = chkLNm;
      document.frmAddUser.fldNewNmExt.value = chkNmExt;
      document.frmAddUser.fldNewComPhn.value = chkComPhn;
      document.frmAddUser.fldNewComEml.value = chkComEml;
      document.frmAddUser.fldNewTZone.value = chkTZone;	  
      document.frmAddUser.fldNewFacID.value = chkFacID;
      document.frmAddUser.fldNewRole.value = chkRole;	
      document.frmAddUser.cmdSubmit.click();}}

Open in new window

0
Comment
Question by:Lee R Liddick Jr
  • 6
  • 2
9 Comments
 
LVL 6

Expert Comment

by:manch
Comment Utility
Include these javascript functions to your code.
Remember : Replace the ToDo parts correctly in your code.
Also, for valid phone number format you may have to search for a correct Phone Number regular expression (here i have included expression for a 3-4 number format).

Suppose your web page collects a customer's seven-digit phone number and you want to verify that the phone number is in the correct format, "xxx-xxxx", where each "x" is a digit. The following expression will search through text looking for such a string:

/* Regular Expression to validate the Phone Number format. */
        var validPhoneNumber = \b\d{3}-\d{4};

Open in new window


<script language="javascript" type="text/javascript">

    /*Javascript function validating a Text Box input for a valid E-Mail address. */
    function IsValidEMail() 
    {
        /* ToDo : Please replace the name of your EMail Control with txtEMail here.*/
        var email = document.getElementById("<%=txtEMail.ClientID %>").value;
        
        /* Regular Expression to validate the EMail address format. */
        var validEMail = /^[\w\-\.\+]+\@[a-zA-Z0-9\.\-]+\.[a-zA-z0-9]{2,4}$/;

        var gotItCorrect = email.match(validEMail);

        /* If the EMail is not correct */
        if (!gotItCorrect) {

            alert("Please enter a valid E-Mail (of format xxx@yyy.zzz).");

            /* ToDo : Please replace the name of your EMail Control with txtEMail here.*/
            document.getElementById("<%=txtEMail.ClientID %>").focus();
            return false;
        }
        else {
            return true;
        }
    }

    /*Javascript function validating a Text Box input for a valid Phone Number. */
    function IsValidPhoneNumber () {
        /* ToDo : Please replace the name of your PhoneNumber Control with txtPhoneNumber here.*/
        var phoneNumber = document.getElementById("<%=txtPhoneNumber.ClientID %>").value;

        /* ToDo : Regular Expression to validate the Phone Number format. */
        var validPhoneNumber = \b\d{3}-\d{4};

        var gotItCorrect = phoneNumber.match(validPhoneNumber);

        /* If the EMail is not correct */
        if (!gotItCorrect) {

            alert("Please enter a valid Phone Number.");

            /* ToDo : Please replace the name of your EMail Control with txtEMail here.*/
            document.getElementById("<%=txtPhoneNumber.ClientID %>").focus();
            return false;
        }
        else {
            return true;
        }
    }

</script>

Open in new window

0
 
LVL 75

Expert Comment

by:Michel Plungjan
Comment Utility
Please use the CODE button or [ code ] tags.

code button
I have edited your posts to wrap the code in [ code] [/ code]
0
 
LVL 75

Expert Comment

by:Michel Plungjan
Comment Utility
manch: I suggest you do not alert in your function and instead change

var gotItCorrect = email.match(validEMail);

        /* If the EMail is not correct */
        if (!gotItCorrect) {

            alert("Please enter a valid E-Mail (of format xxx@yyy.zzz).");

            /* ToDo : Please replace the name of your EMail Control with txtEMail here.*/
            document.getElementById("<%=txtEMail.ClientID %>").focus();
            return false;
        }
        else {
            return true;
        }

Open in new window

to
  return email.match(validEMail);

Open in new window

and have the calling function take care of display

Also your phone number RegEx is not valid
0
 
LVL 75

Accepted Solution

by:
Michel Plungjan earned 500 total points
Comment Utility
Here is my suggestion

regexes are from http://regexlib.com/DisplayPatterns.aspx?categoryId=7

function isValidEmail(str)  {
  // Email
   return  /^([0-9a-zA-Z]([-.\w]*[0-9a-zA-Z])*@([0-9a-zA-Z][-\w]*[0-9a-zA-Z]\.)+[a-zA-Z]{2,9})$/.match(str);
}

function isValidPhone(str)  {
 // US telephone number 
   return /^[\\(]{0,1}([0-9]){3}[\\)]{0,1}[ ]?([^0-1]){1}([0-9]){2}[ ]?[-]?[ ]?([0-9]){4}[ ]*((x){0,1}([0-9]){1,5}){0,1}$/.match(str); 
}

function doCreateUser(edit) {
   chkArray = [];
   var chkFNm     = document.frmEdit.edtFNm.value;
   var chkLNm     = document.frmEdit.edtLNm.value;
   var chkNmExt   = document.frmEdit.edtNmExt.value;
   var chkComPhn  = document.frmEdit.edtComPhn.value;
   var chkComEml  = document.frmEdit.edtComEml.value;
   var chkTZone   = document.frmEdit.edtTZone.value;   
   var chkFacID   = document.frmEdit.edtFacID.value;
   var chkRole    = document.frmEdit.edtRole.value;
   if (chkFNm == "") {
      chkArray.push("A valid 'user first name' is required");
   }
   if (chkLNm == "") {
      chkArray.push("A valid 'user last name' is required");
   }
   if (chkComPhn == "" || !isValidPhone(chkComPhn)) {
      chkArray.push("A valid 'email address' is required");
   }
   if (chkComEml == "" || !isValidEmail(chkComEml)) {
      chkArray.push("A valid 'email address' is required");
   }
   if (chkTZone == "") {
      chkArray.push("A valid 'user time zone' selection is required");
   }	  
   if (chkFacID == "") {
      chkArray.push("A valid 'facility' selection is required");
   }
   if (chkRole == "") {
      chkArray.push("A valid 'role' selection is required");
   }
   if (chkArray.length> 0) {
      var chk_txt = "Errror! The form cannot be submitted due to the following:\n";
      for (var i=0, n=chkArray.length;i<n;i++) {
         chk_txt += "\n"+(i+1) + ") " + chkArray[i];
      }
      alert(chk_txt);
      return false;
   }
  document.frmAddUser.fldNewEdit.value    = edit;
  document.frmAddUser.fldNewFNm.value     = chkFNm;
  document.frmAddUser.fldNewLNm.value     = chkLNm;
  document.frmAddUser.fldNewNmExt.value   = chkNmExt;
  document.frmAddUser.fldNewComPhn.value  = chkComPhn;
  document.frmAddUser.fldNewComEml.value  = chkComEml;
  document.frmAddUser.fldNewTZone.value   = chkTZone;	  
  document.frmAddUser.fldNewFacID.value   = chkFacID;
  document.frmAddUser.fldNewRole.value    = chkRole;	
  document.frmAddUser.cmdSubmit.click();
  return true;
}

Open in new window

0
Do You Know the 4 Main Threat Actor Types?

Do you know the main threat actor types? Most attackers fall into one of four categories, each with their own favored tactics, techniques, and procedures.

 

Author Comment

by:Lee R Liddick Jr
Comment Utility
Thank you mplungjan, very detailed and helpful to follow.  I am getting a script error though stating that TypeError: (intermediate value).match is not a function.
0
 
LVL 75

Expert Comment

by:Michel Plungjan
Comment Utility
I'll test in jsfiddle tomorrow
0
 
LVL 75

Assisted Solution

by:Michel Plungjan
Michel Plungjan earned 500 total points
Comment Utility
Sorry, I swapped the string and the regex

DEMO

function isValidEmail(str)  {
  // Email
   return  str.match(/^([0-9a-zA-Z]([-.\w]*[0-9a-zA-Z])*@([0-9a-zA-Z][-\w]*[0-9a-zA-Z]\.)+[a-zA-Z]{2,9})$/);
}

function isValidPhone(str)  {
 // US telephone number 
   return str.match(/^[\\(]{0,1}([0-9]){3}[\\)]{0,1}[ ]?([^0-1]){1}([0-9]){2}[ ]?[-]?[ ]?([0-9]){4}[ ]*((x){0,1}([0-9]){1,5}){0,1}$/);
}

Open in new window

0
 

Author Comment

by:Lee R Liddick Jr
Comment Utility
Okay, that works.  But I am trying to get the Phone number to not be required but still be validated.  Everything I am trying is not working.  This was my last attempt...

   if (chkFNm == "") {
      chk++;
      chkArray[chk] = "A valid 'user first name' is required";}
   if (chkLNm == "") {
      chk++;
      chkArray[chk] = "A valid 'user last name' is required";}
   if (chkComPhn == !isValidPhone(chkComPhn)) {
      chk++;
      chkArray[chk] = "A valid 'telephone' is required";}
   if (chkComEml == "" || !isValidEmail(chkComEml)) {
      chk++;
      chkArray[chk] = "A valid 'email address' is required";}
   if (chkTZone == "") {
      chk++;
      chkArray[chk] = "A valid 'user time zone' selection is required";}	  
   if (chkFacID == "") {
      chk++;
      chkArray[chk] = "A valid 'facility' selection is required";}
   if (chkRole == "") {
      chk++;
      chkArray[chk] = "A valid 'role' selection is required";}
   if (chk > 0) {
      var chk_txt = "Errror! The form cannot be submitted due to the following:\n\n";
      for (c = 1; c <= chk; c++) {
         chk_txt = chk_txt + c + ") " + chkArray[c] + "\n";}
      alert(chk_txt);}

Open in new window

0
 
LVL 75

Assisted Solution

by:Michel Plungjan
Michel Plungjan earned 500 total points
Comment Utility
if (chkComPhn != "" && !isValidPhone(chkComPhn)) {
      chkArray.push("A valid 'email address' is required");
 }
if (chkComEml != "" && !isValidEmail(chkComEml)) {
     chkArray.push("A valid 'email address' is required");
}
0

Featured Post

Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

Join & Write a Comment

In Part 1 (http://www.experts-exchange.com/Programming/Languages/Scripting/JavaScript/A_7849-Hex-Maze.html) we covered the hexagonal maze basics -- how the cells are represented in a JavaScript array and how the maze is displayed.  In this part, we'…
Active Directory replication delay is the cause to many problems.  Here is a super easy script to force Active Directory replication to all sites with by using an elevated PowerShell command prompt, and a tool to verify your changes.
Learn the basics of if, else, and elif statements in Python 2.7. Use "if" statements to test a specified condition.: The structure of an if statement is as follows: (CODE) Use "else" statements to allow the execution of an alternative, if the …
Learn how to match and substitute tagged data using PHP regular expressions. Demonstrated on Windows 7, but also applies to other operating systems. Demonstrated technique applies to PHP (all versions) and Firefox, but very similar techniques will w…

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

15 Experts available now in Live!

Get 1:1 Help Now