Avatar of isnoend2001
isnoend2001
Flag for United States of America asked on

Need feedback on switching my old html site to css

i have created a header that i plan on using on many pages. It validates wc3 for html5
but before I put it onto many pages I would like to get feedback from EE experts
Any feed back is appreciated.
http://roofgenius.com/AllPageHeader/AllPageHeader.htm

<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>Not needed</title>
<link rel="stylesheet" type="text/css" href="../RGcss.css">
<style type="text/css" media="screen">
 .headwrapper { width:960px; margin: 0px auto;}
 
.headleft{float: left; width: 120px; margin-top: 155px;}

.headcenter{float: left; width: 680px;}

.headright {float: left; width: 160px; margin-top: 60px;}
.centertext { text-align: center; }
</style>
</head>
<body>
<div class="headwrapper">
<div class="headleft"><!-- Left Column -->
<a href="../index.htm"><img src="../images/rglogo105x54.jpg" alt="Roofing estimates fast" width="105" height="54">
            </a>
</div>
     <div class="headcenter"><!-- Center Column -->
<p class="boldblue12">                      
                       Put a roofing estimate together in under 2 minutes and get a complete roof material list !<br>
                        <span class="roofcalculator">Roof Calculator Software </span> <p> 
                       <div class="xcenter">
                                     <span class="Bfont12">                            
                Instant Bids for Comp Shingles, Shakes, Tile, Metal and all others !
              </span></div>  
                 <br>
               <div class="xcenter"><!-- xcenter {text-align:center;}-->
                                   <script type="text/javascript"><!--
google_ad_client = "ca-pub-5860242097775343";
/* Banner468x60 */
google_ad_slot = "6605322965";
google_ad_width = 468;
google_ad_height = 60;
//-->
</script>
<script type="text/javascript"
src="http://pagead2.googlesyndication.com/pagead/show_ads.js">
</script>
 </div><br>
 <div class="xcenter"><!--xcenter {text-align:center;} -->
 <span class="sMedBoldBlue"> How to determine or calculate roof pitch or roof slope</span> 
 </div>  
</div>
<div class="headright"><!--xcenter {text-align:center;} -->
<a href="../Roof-Pitch-Examples.asp">
<img src="../images/Pitch12_12.jpg" alt="Roof pitch 12/12" width="148" height="123"></a>
            <div style="text-align: center">
            Visual Roof Pitch Examples<br>
      <a href="../Roof-Pitch-Examples.asp">Here</a>
            </div>          
            </div>            
            </div>
    <div class="clear"></div>
    <br>                                              
                  <div class="hr"></div>
</body>
</html>

Open in new window

CSS

Avatar of undefined
Last Comment
isnoend2001

8/22/2022 - Mon
SOLUTION
AwesomeMachine

Log in or sign up to see answer
Become an EE member today7-DAY FREE TRIAL
Members can start a 7-Day Free trial then enjoy unlimited access to the platform
Sign up - Free for 7 days
or
Learn why we charge membership fees
We get it - no one likes a content blocker. Take one extra minute and find out why we block content.
Not exactly the question you had in mind?
Sign up for an EE membership and get your own personalized solution. With an EE membership, you can ask unlimited troubleshooting, research, or opinion questions.
ask a question
ASKER CERTIFIED SOLUTION
Dave Baldwin

Log in or sign up to see answer
Become an EE member today7-DAY FREE TRIAL
Members can start a 7-Day Free trial then enjoy unlimited access to the platform
Sign up - Free for 7 days
or
Learn why we charge membership fees
We get it - no one likes a content blocker. Take one extra minute and find out why we block content.
Not exactly the question you had in mind?
Sign up for an EE membership and get your own personalized solution. With an EE membership, you can ask unlimited troubleshooting, research, or opinion questions.
ask a question
isnoend2001

ASKER
Thanks for the feedback for experienced coders like the one here my pages are a joke.
Many i made 10 yrs ago. I am rewriting them in css once i get a good template. I wiil do them one at a time. Just want to be sure I have a good template. to start with.
SOLUTION
Log in to continue reading
Log In
Sign up - Free for 7 days
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.
SOLUTION
Log in to continue reading
Log In
Sign up - Free for 7 days
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.
isnoend2001

ASKER
You mentioned placing the adds at the top and i just moved them after I received this from adsense
Move your highest 728x90 ad unit closer to your unique content on roofgenius.com
Optimize
   
36%
   
of your impressions

Hi,

We analyzed your site and have reason to believe that you're missing out on AdSense revenue since your users may be overlooking your ads. Did you know that, on average, ad units placed at the absolute top of the page have a 61% lower clickthrough rate? Users tend to focus their attention on the headline and the main content below that, so they often don't see ads far up on a page.

We've noticed that approximately 36% of your AdSense ad impressions are appearing from a 728x90 ad unit which is placed at the very top of your pages.

To increase your revenue, try moving the 728x90 ad unit which appears for example on roofgenius.com/roofangle.htm closer to the rest of your content, yet still "above the fold" (= the part of a web page that users can see without scrolling down).
I will change those <br> tags:
Is this a typo: div div {
      margin-bottom: 10px;
}
2 divs side by side ?
SOLUTION
Log in to continue reading
Log In
Sign up - Free for 7 days
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.
SOLUTION
Log in to continue reading
Log In
Sign up - Free for 7 days
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.
isnoend2001

ASKER
Thanks you guys sure  have given me a lot to think about. I keep running into things i never knew. To you guys it some of the simplists things. I made most of my pages 10 yrs ago and never used h1,h2,h3 or know how far they go. my thinking is there a h9. Some things I have discovered lately. The <div> tag creates a line break,, but not as much space as the <p> tag
My thinking to replace the <br> maybe i could do <div> </div>

Another thing I do not know:
Can i put comments in my external css file. I have been trying to use the same external css file my site is currently using and being careful not not change any of the styles, Why ? i do not know. I am just going to create a new one. This font thing I am glad it was mentioned.. Don't remember how I arrived those fonts.

As far as google adds go my revenue has increased since i moved them from the top,
But it could be I received more traffic, have not checked lately, but I do know roofing traffic
increases towards summer. I think I will have an include file for the add at the top and change to a lower add layout later  and maybe determine the best layout. The 149 asp pages would be changed and after I determine the best I will change the headers in the 49 htm files one by one if need be.
I do appreciate all the help you guys have taken the time to give.
Just wish i knew 1/10th the css as I know about roofing for 35 yrs. 17 as a roofing contractor. if you guys have any roofing questions I could put you straight

 I have been getting anxious to get to changing the 198 pages i have, but now see i need to slow down and just do it right and understand more of proper way it gets done.
Experts Exchange is like having an extremely knowledgeable team sitting and waiting for your call. Couldn't do my job half as well as I do without it!
James Murphy
SOLUTION
Log in to continue reading
Log In
Sign up - Free for 7 days
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.
SOLUTION
Log in to continue reading
Log In
Sign up - Free for 7 days
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.
isnoend2001

ASKER
nanharbison, thanks for adding that. I will probably go that route, but right now still trying to learn how to make a css site. Then i will be able to make slight modifications
nanharbison

You are welcome. Wordpress is much easier for novice CMS users, although Drupal can be customized better, but the learning curve is steep.
isnoend2001

ASKER
Thanks everyone
Get an unlimited membership to EE for less than $4 a week.
Unlimited question asking, solutions, articles and more.