Solved

Cell color

Posted on 2013-05-09
10
314 Views
Last Modified: 2013-05-14
I need to be able to highlight a cell if it contains a hyphen or dash "-".  This is what I have, but does not work. Thanks in advance!

Sheets("View").Activate
 
   Range(Range("I1"), Range("I1").End(xlDown)).Select
   For Each cell In Selection
      If cell = "-" Then cell.EntireRow.Interior.ColorIndex = 4
   Next cell
0
Comment
Question by:leezac
  • 4
  • 3
  • 2
  • +1
10 Comments
 
LVL 46

Assisted Solution

by:Martin Liss
Martin Liss earned 250 total points
ID: 39153886
If Instr(1, cell, "-") Then cell.EntireRow.Interior.ColorIndex = 4
0
 
LVL 46

Accepted Solution

by:
Martin Liss earned 250 total points
ID: 39153891
Actually I guess I should ask what you mean when you say it doesn't work? Does anything happen? Do you want to color the row if the cell contains something like "blah-blah"?
0
 
LVL 81

Assisted Solution

by:byundt
byundt earned 125 total points
ID: 39154009
Are the hyphens appearing in the cell as a result of formatting? If so, you need to specify Cell.Text in your macro. If they are manually entered, your existing code should work as desired.

The following modification of your code tests Cell.Text and uses InStr as suggested by MartinLiss.
Sub test()
Dim cell As Range, rg As Range
With Sheets("View")
   Set rg = Range(.Range("I1"), .Range("I1").End(xlDown))
   For Each cell In rg.Cells
      If InStr(1, cell.Text, "-") > 0 Then cell.EntireRow.Interior.ColorIndex = 4
   Next
End With
End Sub

Open in new window

0
Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
LVL 33

Assisted Solution

by:Rob Henson
Rob Henson earned 125 total points
ID: 39155118
You could also achieve the formatting with Conditional Formatting with a custom CF with formula:

Select the required cells (assuming column I) and choose the Conditional Formatting wizard and enter the following as a formula condition:

=FIND("-",I1,1)>0

Thanks
Rob H
0
 
LVL 33

Expert Comment

by:Rob Henson
ID: 39155127
Just realised you wanted the whole row coloured, so slight change.

Select the whole area and the CF formula would then be:

=FIND("-",$I1,1)>0

Only change being the addition of the $ in front of I to ensure that CF in all columns are looking at Column I.

Thanks
Rob H
0
 

Author Comment

by:leezac
ID: 39155619
No nothing works.  I entered the hypen manually to test but it is entered via a macro if the cell is null.  I tried conditional formating but it is deleted somehow when the file is updated.
0
 
LVL 46

Expert Comment

by:Martin Liss
ID: 39155681
Can you attach your workbook and describe the steps to take to reproduce the problem?
0
 

Author Comment

by:leezac
ID: 39155763
I also do not want row colored - just cell
0
 
LVL 46

Expert Comment

by:Martin Liss
ID: 39159906
Can you attach your workbook and describe the steps to take to reproduce the problem?
0
 

Author Comment

by:leezac
ID: 39166334
Decided to use a "0' instead of '-" and it works now with conditional formatting.
0

Featured Post

Free Tool: Subnet Calculator

The subnet calculator helps you design networks by taking an IP address and network mask and returning information such as network, broadcast address, and host range.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Some code to ensure data integrity when using macros within Excel. Also included code that helps secure your data within an Excel workbook.
Do you use a spreadsheet like Microsoft's Excel?  Have you ever wanted to link out to a non excel file on your computer or network drive?  This is the way I found to do it!
This Micro Tutorial demonstrates how to create Excel charts: column, area, line, bar, and scatter charts. Formatting tips are provided as well.
This Micro Tutorial will demonstrate how to use longer labels with horizontal bar charts instead of the vertical column chart.

828 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question