Solved

VB6 - Count records based on 2 column issue

Posted on 2013-05-12
9
342 Views
Last Modified: 2013-05-12
Hello all

I have this code bellow that looks at 2 columns in my grid and based on 3 criteria, it counts the number of records.

But my problem is that it takes about 5 minutes to count when i only have 14 rows in my grid.
That should take seconds to count.

Would you know why?

Can i improve that code to run faster?

Thanks again



 Dim lngRow1 As Long
    Dim lngRow2 As Long

    ' MSHFlexGrid1.WordWrap = True
    LockWindowUpdate Me.hWnd


    For lngRow1 = 1 To MSHFlexGrid1.Rows - 1
        'PO planned without a personnal rate
        If MSHFlexGrid1.TextMatrix(lngRow1, 7) = "S" And MSHFlexGrid1.TextMatrix(lngRow1, 20) = "0" Then
            po_plan_without_rate = po_plan_without_rate + 1
        End If

        'PO not planned with rate
        If MSHFlexGrid1.TextMatrix(lngRow1, 7) <> "S" And MSHFlexGrid1.TextMatrix(lngRow1, 20) <> "0" Then
            Text3 = po_plan_without_rate + 1
        End If

        'PO not planned with no rates
        If MSHFlexGrid1.TextMatrix(lngRow1, 7) <> "S" And MSHFlexGrid1.TextMatrix(lngRow1, 20) = "0" Then
            Text4 = po_plan_without_rate + 1
        End If
    Next

Open in new window

0
Comment
Question by:Wilder1626
  • 5
  • 4
9 Comments
 
LVL 45

Expert Comment

by:Martin Liss
Comment Utility
Is that all the code in the procedure? I ask because that shouldn't even take 1 second with just 14 records.
0
 
LVL 11

Author Comment

by:Wilder1626
Comment Utility
Hi MartinLiss

Yes, just that code.

That's what is strange.
0
 
LVL 45

Expert Comment

by:Martin Liss
Comment Utility
Is this new code or a new problem? By that I mean did it ever run faster? If it did then try rebooting.
0
 
LVL 11

Author Comment

by:Wilder1626
Comment Utility
no, this is a new code. I have other code, bigger and it run faster that the one that cause me issue.

Pretty weird i would say.
0
Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

 
LVL 45

Expert Comment

by:Martin Liss
Comment Utility
Yes I agree. Can you attach your project and tell me how to trigger that code?

Also I assume that po_plan_without_rate is a variable and not a Function or Private Property, right?
0
 
LVL 11

Author Comment

by:Wilder1626
Comment Utility
So weird

Just removed LockWindowUpdate Me.hWnd and it takes a second to run.
0
 
LVL 45

Accepted Solution

by:
Martin Liss earned 500 total points
Comment Utility
That's good. Try this which should be faster.

    Dim lngRow1 As Long
    Dim lngRow2 As Long

    ' MSHFlexGrid1.WordWrap = True
    LockWindowUpdate Me.hWnd


    For lngRow1 = 1 To MSHFlexGrid1.Rows - 1
        Select Case True
            'PO planned without a personnal rate
            Case MSHFlexGrid1.TextMatrix(lngRow1, 7) = "S" And MSHFlexGrid1.TextMatrix(lngRow1, 20) = "0"
                po_plan_without_rate = po_plan_without_rate + 1
            'PO not planned with rate
            Case MSHFlexGrid1.TextMatrix(lngRow1, 7) <> "S" And MSHFlexGrid1.TextMatrix(lngRow1, 20) <> "0"
                Text3 = po_plan_without_rate + 1
            'PO not planned with no rates
            Case MSHFlexGrid1.TextMatrix(lngRow1, 7) <> "S" And MSHFlexGrid1.TextMatrix(lngRow1, 20) = "0"
                Text4 = po_plan_without_rate + 1
        End Select
    Next

Open in new window


Try putting the LockwindowUpdate back in and adding this at the end

LockWindowUpdate &0
0
 
LVL 11

Author Closing Comment

by:Wilder1626
Comment Utility
Yes!!!
This is good now.

It take a second to run

Thanks again for your help
0
 
LVL 45

Expert Comment

by:Martin Liss
Comment Utility
You're welcome and I'm glad I was able to help.

Select the 'About Me' tab in my profile and you'll find links to some articles I've written that may interest you.
Marty - MVP 2009 to 2013
0

Featured Post

How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

Join & Write a Comment

Have you ever wanted to restrict the users input in a textbox to numbers, and while doing that make sure that they can't 'cheat' by pasting in non-numeric text? Of course you can do that with code you write yourself but it's tedious and error-prone …
Most everyone who has done any programming in VB6 knows that you can do something in code like Debug.Print MyVar and that when the program runs from the IDE, the value of MyVar will be displayed in the Immediate Window. Less well known is Debug.Asse…
As developers, we are not limited to the functions provided by the VBA language. In addition, we can call the functions that are part of the Windows operating system. These functions are part of the Windows API (Application Programming Interface). U…
Show developers how to use a criteria form to limit the data that appears on an Access report. It is a common requirement that users can specify the criteria for a report at runtime. The easiest way to accomplish this is using a criteria form that a…

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now