Solved

MS Access VBA to copy Workbook Worksheet to another Workbook

Posted on 2013-05-15
9
2,179 Views
Last Modified: 2013-05-21
Hello Experts,

Please provide assistance to include a MS Access table field that displays the Path and the File Name along with the Tab name as I am receiving a Run Time Error 1004 that displays " Output 1.xlsx could not be found".  I first tried the Spreadsheet Name then entered the Spreadsheet Tab inside the boded below statement – this is where the code stops. The Access table looks like:
ID      SpreadsheetName                                                                            SpreadsheetTab
1      X:\2013 reports\cfi consol nod 0313.xlsm                                       Output 1
2      X:\2013 reports\cfmi consol 0313.xlsm                                           Output 1
3      X:\Reports Close\CFMI Pre_Close_w_filters_RiskNEW.xlsm        Output 1 (100.100.T05)

and the VBA:
Private Sub WorksheetsCopy_Click()
Dim CopyFrom As Object
Dim CopyTo As Object
Dim CopyThis As Object
Dim xl As Object
Dim SpreadsheetName As String
Dim SpreadsheetTab As String
Dim ID As Field
Dim rs As Recordset
Dim sh As Worksheet
Dim oldPath As String, newPath As String
''Late binding
Set xl = CreateObject("Excel.Application")
xl.Visible = True
newPath = "H:\PDF"
Set rs = CurrentDb.OpenRecordset("TblReports")
Do While Not (rs.EOF)
Dim wkbSource As Excel.workbook
Dim wkbDest As Excel.workbook
Set wkbSource = Workbooks.Open(xl.Workbooks.Open(rs("SpreadsheetTab")))
Set wkbDest = Workbooks.Open("H:\PDF\MasterReport.xlsx")
    'Opens workbook
   Workbooks.Open "wkbSource"
   'Makes a copy of "Sheet1"
    ActiveWorkbook.Sheets("Sheet1").Copy _
       after:=ActiveWorkbook.Sheets("Sheet1")
       'Copies that copy to "wkbDest" workbook
        ActiveSheet.Move Before:=Workbooks("wkbDest").Sheets(1)
        ActiveSheet.Next.Select
       'Closes "wkbDest" workbook and saves the copied sheeet
       ActiveWorkbook.Close SaveChanges:=True
  rs.MoveNext
CopyFrom.Close False
Loop
rs.Close
End Sub

Thanks,
Bob
0
Comment
Question by:CFMI
  • 5
  • 4
9 Comments
 
LVL 92

Expert Comment

by:Patrick Matthews
ID: 39168045
Always, always, always qualify your references to external objects.



Private Sub WorksheetsCopy_Click()
Dim CopyFrom As Object
Dim CopyTo As Object
Dim CopyThis As Object
Dim xl As Object
Dim SpreadsheetName As String
Dim SpreadsheetTab As String
Dim ID As Field
Dim rs As Recordset
Dim sh As Worksheet
Dim oldPath As String, newPath As String
Dim wkbSource As Excel.workbook
Dim wkbDest As Excel.workbook
''Late binding
Set xl = CreateObject("Excel.Application")
xl.Visible = True
newPath = "H:\PDF"
Set rs = CurrentDb.OpenRecordset("TblReports")
Set wkbSource = xl.Workbooks.Open(xl.Workbooks.Open(rs("SpreadsheetTab")))
Do While Not (rs.EOF)
Set wkbDest = xl.Workbooks.Open("H:\PDF\MasterReport.xlsx")
   'Makes a copy of "Sheet1"
    wkbSource.Sheets("Sheet1").Copy _
       Before:=wkbDest.Sheets(1)
       'Closes "wkbDest" workbook and saves the copied sheeet
       wkbDest.Close SaveChanges:=True
  rs.MoveNext
Loop
wkbSource.Close False
rs.Close
Set wkbSource = Nothing
Set wkbDest = Nothing
xl.Quit
Set xl = Nothing
End Sub

Open in new window

0
 
LVL 1

Author Comment

by:CFMI
ID: 39168164
Using the above code received the same error message, "Run Time Error 1004 as Output 1.xlsx could not be found" - this points to Line #19; please help.
0
 
LVL 92

Expert Comment

by:Patrick Matthews
ID: 39168539
Private Sub WorksheetsCopy_Click()

    Dim xl As Object
    Dim rs As DAO.Recordset
    Dim wkbSource As Excel.workbook
    Dim wkbDest As Excel.workbook

    ''Late binding
    Set xl = CreateObject("Excel.Application")
    xl.Visible = True
    newPath = "H:\PDF"
    Set rs = CurrentDb.OpenRecordset("TblReports")
    Set wkbDest = xl.Workbooks.Open("H:\PDF\MasterReport.xlsx")

    Do While Not (rs.EOF)
        Set wkbSource = xl.Workbooks.Open(rs("SpreadsheetName"))
        'Makes a copy of "Sheet1"
        wkbSource.Worksheets(rs("SpreadsheetName")).Copy _
            Before:=wkbDest.Sheets(1)
        wkbSource.Close False
        rs.MoveNext
    Loop

    'Closes "wkbDest" workbook and saves the copied sheeet
    wkbDest.Close SaveChanges:=True

    rs.Close
    Set wkbSource = Nothing
    Set wkbDest = Nothing
    xl.Quit
    Set xl = Nothing

End Sub
0
Ransomware: The New Cyber Threat & How to Stop It

This infographic explains ransomware, type of malware that blocks access to your files or your systems and holds them hostage until a ransom is paid. It also examines the different types of ransomware and explains what you can do to thwart this sinister online threat.  

 
LVL 1

Author Comment

by:CFMI
ID: 39168636
The above code receives a "Type Mismatched" error message and points to:
    wkbSource.Worksheets(rs("SpreadsheetName")).Copy _
        Before:=wkbDest.Sheets(1)

My guess is the Worsheet name is "Output 1" and it expects "Sheet 1".  The destination is to a Workbook with a worksheet named, "Sheet 1".
0
 
LVL 92

Expert Comment

by:Patrick Matthews
ID: 39168822
Sorry, that should be:

        wkbSource.Worksheets(rs("SpreadsheetTab")).Copy _
            Before:=wkbDest.Sheets(1)

Now, that places the copied worksheet before the first sheet overall.  To place it before "Sheet 1"...

        wkbSource.Worksheets(rs("SpreadsheetTab")).Copy _
            Before:=wkbDest.Sheets("Sheet 1")
0
 
LVL 1

Author Comment

by:CFMI
ID: 39168994
We now have anther error message stating, "Subscript out of range" using:
    wkbSource.Worksheets(rs("SpreadsheetTab")).Copy _
            Before:=wkbDest.Sheets("Sheet 1")
0
 
LVL 92

Accepted Solution

by:
Patrick Matthews earned 500 total points
ID: 39169127
That tells me that either the worksheet we are trying to copy does not exist, and/or the worksheet we are referencing in the Before argument does not exist.

So:

1) Are you positive that the destination workbook has a sheet named "Sheet 1"?  Is it possible that it is named "Sheet1" (note the lack of a space)?

2) If the above checks out, if this happens again, type this in the Immediate window and hit Enter:

?"wb: " & wkbSource.Name & "; ws: " & rs("SpreadsheetTab")

Check to make sure that the indicated workbook does in fact have a worksheet with the indicated name.
0
 
LVL 1

Author Comment

by:CFMI
ID: 39169287
Both workbooks open, then I see the error message and the workbooks remain opened and are the correct workbooks but nothing is copied.  The error message states, "Subscript out of range" and debugging points to:
    wkbSource.Worksheets(rs("SpreadsheetTab")).Copy _
        Before:=wkbDest.Sheets("Sheet 1")")

Then I changed it to: Before:=wkbDest.Sheets("Sheet1")")  and I received Type mismatch.


Overall, I am reading in 53 specific Workbook, worksheets and coping them to a Master Workbook with 53 worksheets; perhaps I do not already need a spreadsheet with 53 worksheets especially since it doesn’t even seem to be copying?

Current code:
Private Sub TestCopy_Click()
Dim CopyFrom As Object
Dim CopyTo As Object
Dim CopyThis As Object
Dim xl As Object
Dim SpreadsheetName As String
Dim SpreadsheetTab As String
Dim ID As Field
Dim rs As Recordset
Dim sh As Worksheet
Dim oldPath As String, newPath As String
Dim wkbSource As Excel.Workbook
Dim wkbDest As Excel.Workbook
    ''Late binding
Set xl = CreateObject("Excel.Application")
xl.Visible = True
newPath = "H:\PDF"
Set rs = CurrentDb.OpenRecordset("TblReports")
'Set wkbSource = xl.Workbooks.Open(xl.Workbooks.Open(rs("SpreadsheetTab")))
Set wkbSource = xl.Workbooks.Open(rs("SpreadsheetName"))
Set wkbDest = xl.Workbooks.Open("H:\PDF\MasterReport.xlsx")
Do While Not (rs.EOF)
    Set wkbSource = xl.Workbooks.Open(rs("SpreadsheetName"))
    Set wkbDest = xl.Workbooks.Open("H:\PDF\MasterReport.xlsx")
        'Makes a copy of "Sheet1"
   wkbSource.Worksheets(rs("SpreadsheetTab")).Copy _
            Before:=wkbDest.Sheets("Sheet 1")    
       'Closes "wkbDest" workbook and saves the copied sheeet
    wkbSource.Close False
  rs.MoveNext
Loop
    'Closes "wkbDest" workbook and saves the copied sheet
wkbDest.Close SaveChanges:=True
wkbSource.Close False
rs.Close
Set wkbSource = Nothing
Set wkbDest = Nothing
xl.Quit
Set xl = Nothing

End Sub
MasterReport.xlsx
0
 
LVL 1

Author Closing Comment

by:CFMI
ID: 39184804
The code worked well but I was provided an incorrect worksheet title and this creates an out of sequence error so my learning, verify all input FIRST - Thanks!
0

Featured Post

Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Freeze panes is an option within all variants of Excel to enable parts of a sheet to remain stationary when the cursor is in another part of the sheet. This is a very useful feature which is overlooked or under used.
It’s the first day of March, the weather is starting to warm up and the excitement of the upcoming St. Patrick’s Day holiday can be felt throughout the world.
This Micro Tutorial demonstrates in Microsoft Excel how to consolidate your marketing data by creating an interactive charts using form controls. This creates cool drop-downs for viewers of your chart to choose from.
Many functions in Excel can make decisions. The most simple of these is the IF function: it returns a value depending on whether a condition you describe is true or false. Once you get the hang of using the IF function, you will find it easier to us…

860 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question