Solved

C# foreach iteration

Posted on 2013-05-20
5
318 Views
Last Modified: 2013-05-20
Good day all,

I am not the worlds most experienced C# developer so please bear with me :)
Recently started to move projects over to .NET C#.

I have a very simple issue which I do not seem to understand.

I have a method that creates buttons and also another method that disposes them off.
But in the disposing method my foreach iteration seems to miss the last control everytime.

I am not sure as to why this would happen.
Two buttons gets created in dynamically no problem.
When running the DisposeButtons() method all except one button gets removed.

Please see my code - been on loooong day so perhaps I am overlooking something here.

Thanks in advance :)

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;

namespace WindowsFormsApplication1
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
            LoadButtons();
        }

        private void LoadButtons()
        {
            var top = 20;
            var verticalspace = 5;

            for (int x = 0; x < 2; x++)
            {
                top += top + verticalspace;

                Button b = new Button();
                b.Text = "button_" + x.ToString();
                b.Top = top;
                b.Left = 20;
                b.Name = "button_" + x.ToString();
                this.Controls.Add(b);
            }
        }

        private void DisposeButtons()
        {
            foreach (Control c in this.Controls)
            {
                if (c is Button) {
                    this.Controls.Remove(c);
                }
            }
        }

        private void checkBox1_CheckedChanged(object sender, EventArgs e)
        {
            if (checkBox1.Checked)
            {
                LoadButtons();
            }
            else
            {
                DisposeButtons();
            }
        }
    }
}

Open in new window

0
Comment
Question by:Marius0188
  • 2
  • 2
5 Comments
 
LVL 29

Expert Comment

by:QPR
ID: 39182580
Could it be you have nested controls?
Have a look here

http://stackoverflow.com/questions/5794699/change-all-buttons-on-a-form
0
 

Author Comment

by:Marius0188
ID: 39182611
Hi QPR,

Thanks for the reply.
If I understand correctly nest control = controls within controls?

Nope - well not according to me.
All the buttons are explicitly added to the form this().

:)
0
 
LVL 85

Accepted Solution

by:
Mike Tomlinson earned 500 total points
ID: 39182640
When you remove the buttons you are modifying the Controls() collection, which messes up the for loop.

One solution is to iterate backwards:
        private void DisposeButtons()
        {
            int count = this.Controls.Count -1;
            for (int i = count; i >= 0; i--)
            {
                if (this.Controls[i] is Button)
                {
                    this.Controls.RemoveAt(i);
                }
            }
        }

Open in new window

0
 
LVL 85

Expert Comment

by:Mike Tomlinson
ID: 39182645
You could also add those dynamic buttons to a class level List<Button>, then iterate over that and work with them that way.
0
 

Author Comment

by:Marius0188
ID: 39182661
Aaaah - I know it.
Something so simple. How would I have not thought about it.

Great Idle_Mind and thanks a lot for this.
I need sleep :)

Points awarded to you....
0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In order to hide the "ugly" records selectors (triangles) in the rowheaders, here are some suggestions. Microsoft doesn't have a direct method/property to do it. You can only hide the rowheader column. First solution, the easy way The first sol…
It was really hard time for me to get the understanding of Delegates in C#. I went through many websites and articles but I found them very clumsy. After going through those sites, I noted down the points in a easy way so here I am sharing that unde…
Established in 1997, Technology Architects has become one of the most reputable technology solutions companies in the country. TA have been providing businesses with cost effective state-of-the-art solutions and unparalleled service that is designed…
In an interesting question (https://www.experts-exchange.com/questions/29008360/) here at Experts Exchange, a member asked how to split a single image into multiple images. The primary usage for this is to place many photographs on a flatbed scanner…

860 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question