• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 264
  • Last Modified:

eloquent javascript

What is the best (i.e. most elegant, concise, readable, beautiful, meaningful, expressive, 31337, etc) way of doing error checking on a long string of functions where each one depends on the one before it?

For example, I have a function called findShift(id) which returns an object if the object isn't found, it returns null. I want to access one of the parts of that object.

var worker = findshift(id).worker.lastname;

Open in new window


The problem is that if findshift() returns null, then I get a javascript error about how it can't get the .worker property of null. The same goes if the worker property is null and lastname is null. What I really want is for the whole thing to just assign null if any part of the chain is null. One option is the following:

var worker = finshift(id) && findshift(id).worker && findshift(id).worker.lastname;

Open in new window


but that requires me to run the findshift() function three times, which might be expensive. Another option is this:

var lastname = null;
var worker = null;
var shift = findshift(id);
if (shift) {
    worker = shift.worker;
    if (worker) {
        lastname = worker.lastname;
    }
}

Open in new window


but I find that to verbose and klunky. Is there a better way to do this? Is Try/Catch the solution?
0
mankowitz
Asked:
mankowitz
  • 3
1 Solution
 
MajorBigDealCommented:
if (shift  = findshift(id) == null) return;
if (worker = shift.worker == null) return;
if (lastname = worker.lastname == null) return;
// All data available here
0
 
MajorBigDealCommented:
if (shift = findshift(id)) {
   if (worker = shift.worker) {
      if (lastname = worker.lastname) {
         // All data available here
      }
   }
}
0
 
MajorBigDealCommented:
I don't know that this is the most elegant way but I think it is readable!
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Cloud Class® Course: Microsoft Office 2010

This course will introduce you to the interfaces and features of Microsoft Office 2010 Word, Excel, PowerPoint, Outlook, and Access. You will learn about the features that are shared between all products in the Office suite, as well as the new features that are product specific.

  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now