Go Premium for a chance to win a PS4. Enter to Win

x
?
Solved

eloquent javascript

Posted on 2013-06-03
3
Medium Priority
?
251 Views
Last Modified: 2013-06-06
What is the best (i.e. most elegant, concise, readable, beautiful, meaningful, expressive, 31337, etc) way of doing error checking on a long string of functions where each one depends on the one before it?

For example, I have a function called findShift(id) which returns an object if the object isn't found, it returns null. I want to access one of the parts of that object.

var worker = findshift(id).worker.lastname;

Open in new window


The problem is that if findshift() returns null, then I get a javascript error about how it can't get the .worker property of null. The same goes if the worker property is null and lastname is null. What I really want is for the whole thing to just assign null if any part of the chain is null. One option is the following:

var worker = finshift(id) && findshift(id).worker && findshift(id).worker.lastname;

Open in new window


but that requires me to run the findshift() function three times, which might be expensive. Another option is this:

var lastname = null;
var worker = null;
var shift = findshift(id);
if (shift) {
    worker = shift.worker;
    if (worker) {
        lastname = worker.lastname;
    }
}

Open in new window


but I find that to verbose and klunky. Is there a better way to do this? Is Try/Catch the solution?
0
Comment
Question by:mankowitz
  • 3
3 Comments
 
LVL 11

Expert Comment

by:MajorBigDeal
ID: 39217764
if (shift  = findshift(id) == null) return;
if (worker = shift.worker == null) return;
if (lastname = worker.lastname == null) return;
// All data available here
0
 
LVL 11

Accepted Solution

by:
MajorBigDeal earned 2000 total points
ID: 39217769
if (shift = findshift(id)) {
   if (worker = shift.worker) {
      if (lastname = worker.lastname) {
         // All data available here
      }
   }
}
0
 
LVL 11

Expert Comment

by:MajorBigDeal
ID: 39226601
I don't know that this is the most elegant way but I think it is readable!
0

Featured Post

[Webinar] Cloud and Mobile-First Strategy

Maybe you’ve fully adopted the cloud since the beginning. Or maybe you started with on-prem resources but are pursuing a “cloud and mobile first” strategy. Getting to that end state has its challenges. Discover how to build out a 100% cloud and mobile IT strategy in this webinar.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article discusses how to implement server side field validation and display customized error messages to the client.
In this blog, we’ll look at how improvements to Percona XtraDB Cluster improved IST performance.
The viewer will learn the basics of jQuery, including how to invoke it on a web page. Reference your jQuery libraries: (CODE) Include your new external js/jQuery file: (CODE) Write your first lines of code to setup your site for jQuery.: (CODE)
The viewer will learn the basics of jQuery including how to code hide show and toggles. Reference your jQuery libraries: (CODE) Include your new external js/jQuery file: (CODE) Write your first lines of code to setup your site for jQuery…
Suggested Courses

927 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question