VB Script does not run

Posted on 2013-06-10
Last Modified: 2013-06-13
My vb script is supposed to list all filenames in a folder as defined by Path. Please help me figure out why the script isn't running.

Here's the script:
Option Explicit
Sub Main
   Dim Path
 Path = "\\\dfs$\care-one\users\care-one_nanthony\desktop\Report"
   Select Case WScript.Arguments.Count
      Case 0: Path = "*.*"             ' list current directory
      Case 1: Path = WScript.Arguments(0)
      Case Else: WScript.Echo "Invalid number of arguments.": Exit Sub
      End Select
   Dim a: a = ListDir(Path)
   If UBound(a) = -1 then
      WScript.Echo "No files found."
      Exit Sub
      End If
   Dim FileName
   For Each FileName In a
      WScript.Echo list.txt
 MsgBox "All Done!"
   End Sub
Question by:janthonyn
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 4
  • 3
LVL 42

Expert Comment

ID: 39235778
Do u get error or script simply does not outputs files?
LVL 54

Expert Comment

by:Bill Prew
ID: 39235799
Well, there seem to be a number of issues with that.

First, and a main issue, all your code is in the Main subroutine that is never executed.  Try removing the "Sub Main" and "End Sub" lines.

Also, you set Path to a long network drive location, but then never will use that, since you change Path to either "*.*" or the parm from the command line later.

Also, the Wscript.Echo should probably be displaying FileName, not list.txt.

LVL 54

Assisted Solution

by:Bill Prew
Bill Prew earned 500 total points
ID: 39235899
Here's a working example that seems to do what you were looking for.

Option Explicit

Dim objFSO
Dim objFolder
Dim objFiles
Dim objFile
Dim strPath

strPath = "C:\EE"
Select Case WScript.Arguments.Count
   Case 0: 
      strPath = "."             ' list current directory
   Case 1: 
      strPath = WScript.Arguments(0)
   Case Else: 
      WScript.Echo "Invalid number of arguments."
End Select

Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objFolder = objFSO.GetFolder(strPath)
Set objFiles = objFolder.Files
If objFiles.Count = 0 Then
   WScript.Echo "No files found."
   For Each objFile in objFolder.Files
      Wscript.Echo objFile.Name
End If

Open in new window

Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!


Author Comment

ID: 39240968

I tested the script you provided and it didn't work. No list was output. What I get is a series of popup screens with the title bar as - Windows Script Host. Each screen lists one filename in the body of the screen and an OK button. Press the OK button and you get the next screen with the name of another file in the folder. This loops until all the filenames in a folder are shown. I'm attaching one screen example.
LVL 54

Accepted Solution

Bill Prew earned 500 total points
ID: 39243276
Run from the command line as:

cscript yourname.vbs


Author Comment

ID: 39245712
Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:\Windows\system32>cd ..

C:\Windows>cd ..

C:\>cd Reports

C:\Reports>cscript files.vbs
'cscript' is not recognized as an internal or external command,
operable program or batch file.

C:\Reports>cd ..

C:\>cscript Reports/files.vbs
'cscript' is not recognized as an internal or external command,
operable program or batch file.

Author Comment

ID: 39245928
it seems that the command prompt exe on my laptop isn't working correctly. I tried running the prompt as an administrator, but got the same results. I had someone else run the command on their laptop and the command was recognized. Thanks for your help on this. I need to find a better script, one that includes both folder path and output file path as set variables. That way I can save the script file anywhere. I ran the command with the script file in the same folder as the files I wanted listed.

Author Closing Comment

ID: 39245938
I still don't have the final solution. I want to be able to run the script from the vbs file and list the target folder path as a set variable in the script and have the output file created in a path also set in the script.


Featured Post

[Webinar] Code, Load, and Grow

Managing multiple websites, servers, applications, and security on a daily basis? Join us for a webinar on May 25th to learn how to simplify administration and management of virtual hosts for IT admins, create a secure environment, and deploy code more effectively and frequently.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Welcome back!  My apologies for taking so long to write part two of this series; it's been a long time coming!  As I promised in Part 1, this article will focus on how to locate those elusive AD properties that you are searching for.  Why is this us…
This article is the result of a quest to better understand Task Scheduler 2.0 and all the newer objects available in vbscript in this version over  the limited options we had scripting in Task Scheduler 1.0.  As I started my journey of knowledge I f…
In a recent question ( here at Experts Exchange, a member asked how to run an AutoHotkey script (.AHK) directly from Notepad++ (aka NPP). This video…
Finding and deleting duplicate (picture) files can be a time consuming task. My wife and I, our three kids and their families all share one dilemma: Managing our pictures. Between desktops, laptops, phones, tablets, and cameras; over the last decade…

751 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question