janthonyn
asked on
VB Script does not run
My vb script is supposed to list all filenames in a folder as defined by Path. Please help me figure out why the script isn't running.
Here's the script:
Option Explicit
Sub Main
Dim Path
Path = "\\domain-01.com\dfs$\care
Select Case WScript.Arguments.Count
Case 0: Path = "*.*" ' list current directory
Case 1: Path = WScript.Arguments(0)
Case Else: WScript.Echo "Invalid number of arguments.": Exit Sub
End Select
Dim a: a = ListDir(Path)
If UBound(a) = -1 then
WScript.Echo "No files found."
Exit Sub
End If
Dim FileName
For Each FileName In a
WScript.Echo list.txt
Next
MsgBox "All Done!"
End Sub
Here's the script:
Option Explicit
Sub Main
Dim Path
Path = "\\domain-01.com\dfs$\care
Select Case WScript.Arguments.Count
Case 0: Path = "*.*" ' list current directory
Case 1: Path = WScript.Arguments(0)
Case Else: WScript.Echo "Invalid number of arguments.": Exit Sub
End Select
Dim a: a = ListDir(Path)
If UBound(a) = -1 then
WScript.Echo "No files found."
Exit Sub
End If
Dim FileName
For Each FileName In a
WScript.Echo list.txt
Next
MsgBox "All Done!"
End Sub
Meir Rivkin
Do u get error or script simply does not outputs files?
Well, there seem to be a number of issues with that.
First, and a main issue, all your code is in the Main subroutine that is never executed. Try removing the "Sub Main" and "End Sub" lines.
Also, you set Path to a long network drive location, but then never will use that, since you change Path to either "*.*" or the parm from the command line later.
Also, the Wscript.Echo should probably be displaying FileName, not list.txt.
~bp
First, and a main issue, all your code is in the Main subroutine that is never executed. Try removing the "Sub Main" and "End Sub" lines.
Also, you set Path to a long network drive location, but then never will use that, since you change Path to either "*.*" or the parm from the command line later.
Also, the Wscript.Echo should probably be displaying FileName, not list.txt.
~bp
SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
billprew,
I tested the script you provided and it didn't work. No list was output. What I get is a series of popup screens with the title bar as - Windows Script Host. Each screen lists one filename in the body of the screen and an OK button. Press the OK button and you get the next screen with the name of another file in the folder. This loops until all the filenames in a folder are shown. I'm attaching one screen example.
Screen-example.PNG
I tested the script you provided and it didn't work. No list was output. What I get is a series of popup screens with the title bar as - Windows Script Host. Each screen lists one filename in the body of the screen and an OK button. Press the OK button and you get the next screen with the name of another file in the folder. This loops until all the filenames in a folder are shown. I'm attaching one screen example.
Screen-example.PNG
ASKER CERTIFIED SOLUTION
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
ASKER
Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.
C:\Windows\system32>cd ..
C:\Windows>cd ..
C:\>cd Reports
C:\Reports>cscript files.vbs
'cscript' is not recognized as an internal or external command,
operable program or batch file.
C:\Reports>cd ..
C:\>cscript Reports/files.vbs
'cscript' is not recognized as an internal or external command,
operable program or batch file.
Copyright (c) 2009 Microsoft Corporation. All rights reserved.
C:\Windows\system32>cd ..
C:\Windows>cd ..
C:\>cd Reports
C:\Reports>cscript files.vbs
'cscript' is not recognized as an internal or external command,
operable program or batch file.
C:\Reports>cd ..
C:\>cscript Reports/files.vbs
'cscript' is not recognized as an internal or external command,
operable program or batch file.
ASKER
it seems that the command prompt exe on my laptop isn't working correctly. I tried running the prompt as an administrator, but got the same results. I had someone else run the command on their laptop and the command was recognized. Thanks for your help on this. I need to find a better script, one that includes both folder path and output file path as set variables. That way I can save the script file anywhere. I ran the command with the script file in the same folder as the files I wanted listed.
ASKER
I still don't have the final solution. I want to be able to run the script from the vbs file and list the target folder path as a set variable in the script and have the output file created in a path also set in the script.
Nels
Nels