Solved

Problem with WorksheetFunction in Worksheet Module

Posted on 2013-06-11
9
194 Views
Last Modified: 2013-06-19
Hi

I noticed that two of my WorksheetFunction formulae do not work if they are in a worksheet module. Is there a reason why I cannot create code with WorksheetFunction in such modules or is it a bug?

Massimo

Option Explicit


Private Sub Worksheet_Activate()
UpdateValues
'UpdateStatisticsValues
End Sub




Sub UpdateValues()
Dim ws As Worksheet
Set ws = ThisWorkbook.Worksheets("Statistics")

Dim shpTotalOrders As ShapeRange
Dim shpTotalCustomers As ShapeRange

Set shpTotalOrders = ws.Shapes.Range(Array("TotalOrders"))
Set shpTotalCustomers = ws.Shapes.Range(Array("TotalCustomers"))

Dim lngOrders As Long
Dim intCustomers As Integer

'Doesn't work?
On Error GoTo Hell

lngOrders = Application.WorksheetFunction.Count(Range("Orders[ID]"))
intCustomers = Application.WorksheetFunction.CountIf(Range("Customers[Orders]"), ">0")

shpTotalOrders.TextFrame2.TextRange.Characters.Text = lngOrders
shpTotalCustomers.TextFrame2.TextRange.Characters.Text = intCustomers

Set ws = Nothing
Set shpTotalOrders = Nothing
Set shpTotalCustomers = Nothing

Hell:

MsgBox "There was a problem."

End Sub

Open in new window

ExampleWorksheet.xlsm
0
Comment
Question by:mscola
  • 6
  • 3
9 Comments
 
LVL 45

Expert Comment

by:Martin Liss
ID: 39238116
Change line 12 to

Public Sub UpdateValues()
0
 

Author Comment

by:mscola
ID: 39238156
I tried it with Public Sub but it doesn't work.
0
 
LVL 45

Expert Comment

by:Martin Liss
ID: 39238167
What do you mean when you say "it doesn't work"? Do you get an error? Does nothing happen?
0
 
LVL 45

Expert Comment

by:Martin Liss
ID: 39238190
Is the problem that you always get the "There was a problem message"? If so add Exit Sub following line 37.
0
How your wiki can always stay up-to-date

Quip doubles as a “living” wiki and a project management tool that evolves with your organization. As you finish projects in Quip, the work remains, easily accessible to all team members, new and old.
- Increase transparency
- Onboard new hires faster
- Access from mobile/offline

 

Author Comment

by:mscola
ID: 39241646
I get a run-time error 1004: "Method 'Range' of of Object _Worksheet failed.

I don't get any error messages of the code is put in a regular module.

Do I need to change something on my code or does it work properly on your computer?

error message
0
 
LVL 45

Accepted Solution

by:
Martin Liss earned 500 total points
ID: 39241733
Try this. Change lines 28 and 29 to

With ws
    lngOrders = Application.WorksheetFunction.Count(.Range("Orders[ID]"))
    intCustomers = Application.WorksheetFunction.CountIf(.Range("Customers[Orders]"), ">0")
End With

Open in new window


Note that there is a dot before "Range" in both lines.

If that doesn't work, please post your workbook and list the steps to take to reproduce the error.
0
 
LVL 45

Expert Comment

by:Martin Liss
ID: 39251466
Did my last post help you?
0
 

Author Closing Comment

by:mscola
ID: 39259482
Hello Martin

Yes, it worked very well.

Thanks a lot

Massimo
0
 
LVL 45

Expert Comment

by:Martin Liss
ID: 39259613
You're welcome and I'm glad I was able to help.

Marty - MVP 2009 to 2013
0

Featured Post

Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

Workbook link problems after copying tabs to a new workbook? David Miller (dlmille) Intro Have you either copied sheets to a new workbook, and after having saved and opened that workbook, you find that there are links back to the original sou…
This article descibes how to create a connection between Excel and SAP and how to move data from Excel to SAP or the other way around.
The viewer will learn how to simulate a series of coin tosses with the rand() function and learn how to make these “tosses” depend on a predetermined probability. Flipping Coins in Excel: Enter =RAND() into cell A2: Recalculate the random variable…
This Micro Tutorial will demonstrate in Google Sheets how to use the HYPERLINK function to create live links inside your spreadsheet.

747 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now