Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 339
  • Last Modified:

Previous month date calculations

Why following works for Feburary but not for april dates?  When @StarteDate is 4/15/13 and @EndDate is 4/30/13, @LPEndDate returns as '3/30/13' (it should return '3/31/13')? Any ideas?

declare       @NoOfMonths int,
             @LPStartDate datetime,
             @LPEndDate datetime,
             @StartDate datetime = '2/15/13',
             @EndDate datetime = '2/28/13'
             
set @NoOfMonths=DATEDIFF(M,@StartDate,@EndDate)+1

set @LPEndDate=DATEADD(m,-1,@EndDate)
set @LPStartDate =DATEADD(m,@NoOfMonths*-1,@StartDate)
if datepart(d,@LPEndDate) >15 and datepart(d,@LPEndDate) <29
begin
set @LPEndDate=DATEADD(ms,-3,DATEADD(mm,0,DATEADD(mm,DATEDIFF(mm,0,@EndDate),0)))
end
select @LPStartDate, @LPEndDate
0
theone1
Asked:
theone1
  • 2
  • 2
  • 2
1 Solution
 
Surendra NathTechnology LeadCommented:
I already have a solution for you in my blog post here, check it out
http://everysolution.wordpress.com/2011/08/25/how-to-find-the-last-day-of-the-month/
0
 
Surendra NathTechnology LeadCommented:
the only flaw in your logic over here is.. you are checking if the date is  < 29, if that is corrected then the expected comes out ...

declare       @NoOfMonths int,
             @LPStartDate datetime,
             @LPEndDate datetime,
             @StartDate datetime = '2/15/13',
             @EndDate datetime = '2/28/13'
             
--set @StartDate = '4/15/13'
--set @EndDate = '4/30/13'

set @StartDate = '3/15/13'
set @EndDate = '3/31/13'

set @NoOfMonths=DATEDIFF(M,@StartDate,@EndDate)+1

set @LPEndDate=DATEADD(m,-1,@EndDate)
set @LPStartDate =DATEADD(m,@NoOfMonths*-1,@StartDate)

if datepart(d,@LPEndDate) >15 and datepart(d,@LPEndDate) <=31
begin
set @LPEndDate=DATEADD(ms,-3,DATEADD(mm,0,DATEADD(mm,DATEDIFF(mm,0,@EndDate),0)))
end
select @LPStartDate, @LPEndDate 

Open in new window

0
 
theone1Author Commented:
Strange when I first had @LPEndDate <=30 it didnt work,,,,, but hey,,,, you are the one to solve it for me,,,, THANK YOU!!!
0
Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

 
PaulCommented:
my only contribution here will be - why look for the last day of a month?

this is a guess, but what this often stems from is someone using this date arithmetic for use in a date range filter
e.g.
select <<whatever>>
from <<whereever>>
where some_date between {first day of period} and {last day of period}

while this can be workable, often a simpler - AND more reliable method is to avoid using 'between', like so:

select <<whatever>>
from <<whereever>>
where some_date >= {first day of period}
    and some_date <   {first day of next period}

i.e. it's quite easy to get the first day of any month (it's always 1)
and by using <   {first day of next period}
we don't have to concern ourselves with times during the {last day of month}

forgive me if this is utterly irrelevant here - it's a topic of interest to me.
0
 
theone1Author Commented:
hey P Paul, thank you for explanation.... makes much sense :) you are good teacher sir!
0
 
PaulCommented:
:) too kind

if you need more on this topic please see: "Beware of Between"
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 2
  • 2
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now