Still celebrating National IT Professionals Day with 3 months of free Premium Membership. Use Code ITDAY17

x
?
Solved

String Concat problem, not working

Posted on 2013-06-22
3
Medium Priority
?
360 Views
Last Modified: 2013-06-23
I am trying to concat 9 edit controls. I don't see why this code is not working. Can anyone help me get this working?

    char szCombo1[2], szCombo2[2],szCombo3[2],
         szCombo4[2],szCombo5[2],szCombo6[2],
         szCombo7[2],szCombo8[2],szCombo9[2];
     
    GetDlgItemText(gl_hWnd, IDC_COMBO1, szCombo1, strlen(szCombo1));
    GetDlgItemText(gl_hWnd, IDC_COMBO2, szCombo2, strlen(szCombo2));
    GetDlgItemText(gl_hWnd, IDC_COMBO3, szCombo3, strlen(szCombo3));
    GetDlgItemText(gl_hWnd, IDC_COMBO4, szCombo4, strlen(szCombo4));
    GetDlgItemText(gl_hWnd, IDC_COMBO5, szCombo5, strlen(szCombo5));
    GetDlgItemText(gl_hWnd, IDC_COMBO6, szCombo6, strlen(szCombo6));
    GetDlgItemText(gl_hWnd, IDC_COMBO7, szCombo7, strlen(szCombo7));
    GetDlgItemText(gl_hWnd, IDC_COMBO8, szCombo8, strlen(szCombo8));
    GetDlgItemText(gl_hWnd, IDC_COMBO9, szCombo9, strlen(szCombo9));
              
    std::string strCombo1(szCombo1);
    std::string strCombo2(szCombo2);
    std::string strCombo3(szCombo3);
    std::string strCombo4(szCombo4);
    std::string strCombo5(szCombo5);
    std::string strCombo6(szCombo6);
    std::string strCombo7(szCombo7);
    std::string strCombo8(szCombo8);
    std::string strCombo9(szCombo9);
    std:string strUserCombo;
    strUserCombo = strCombo1+strCombo2+strCombo3+strCombo4+strCombo5+strCombo6+strCombo7+strCombo8+strCombo9;
    MessageBox(NULL,strUserCombo.c_str(),"DEBUG",NULL);

Open in new window


Thanks!
0
Comment
Question by:edvinson
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
3 Comments
 
LVL 86

Expert Comment

by:jkr
ID: 39268181
In the above, 'strlen()' will return 0 or an undefined value, that's why that won't work. You need to provide the actual size of the buffer as the last argument. Are you sure that should be two bytes?
0
 
LVL 1

Author Comment

by:edvinson
ID: 39268385
I am not sure it should be two bytes, I am expecting the user to enter two digits, thats why i chose 2 bytes. should I only use 1? Or something different? What if I dont know how many characters they entered?
0
 
LVL 86

Accepted Solution

by:
jkr earned 2000 total points
ID: 39268638
If you are expecting two digits, make that at least 3 bytes (the two digits plus the terminating NULL byte). However, a larger buffer won't hurt ;o)
Anyway, 'strlen()' is the wrong way, since it will report the lenght of the string stored in that buffer - and since there is none prior to your call, that's bound to fail.
0

Featured Post

On Demand Webinar: Networking for the Cloud Era

Did you know SD-WANs can improve network connectivity? Check out this webinar to learn how an SD-WAN simplified, one-click tool can help you migrate and manage data in the cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Article by: SunnyDark
This article's goal is to present you with an easy to use XML wrapper for C++ and also present some interesting techniques that you might use with MS C++. The reason I built this class is to ease the pain of using XML files with C++, since there is…
What is C++ STL?: STL stands for Standard Template Library and is a part of standard C++ libraries. It contains many useful data structures (containers) and algorithms, which can spare you a lot of the time. Today we will look at the STL Vector. …
The goal of the video will be to teach the user the difference and consequence of passing data by value vs passing data by reference in C++. An example of passing data by value as well as an example of passing data by reference will be be given. Bot…
The viewer will learn additional member functions of the vector class. Specifically, the capacity and swap member functions will be introduced.

705 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question