[Webinar] Streamline your web hosting managementRegister Today

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 592
  • Last Modified:

php login security

Hi,

I have a login for mysql with php that I tweaked and it works.
Apart from password is readable (just testing it ) what else would I need to do for security?

<?php
 

ob_start();
$host="localhost"; // Host name
$username=""; // Mysql username
$password=""; // Mysql password
$db_name="db_jagguy"; // Database name
$tbl_name="tblogin"; // Table name

// Connect to server and select databse.
mysql_connect($host, 'root') or die("cannot connect");
mysql_select_db($db_name)or die("cannot select DB");

// Define $myusername and $mypassword
$myusername=$_POST['myusername'];
$mypassword=$_POST['mypassword'];

// To protect MySQL injection (more detail about MySQL injection)
$myusername = stripslashes($myusername);
$mypassword = stripslashes($mypassword);
$myusername = mysql_real_escape_string($myusername);
$mypassword = mysql_real_escape_string($mypassword);

$sql="SELECT * FROM " . $tbl_name . " WHERE login='" . $myusername . "' and password='" . $mypassword . "'";
$result=mysql_query($sql);

// Mysql_num_row is counting table row
$count=mysql_num_rows($result);

// If result matched $myusername and $mypassword, table row must be 1 row

if($count==1){

// Register $myusername, $mypassword and redirect to file "login_success.php"
session_start();
$_SESSION['myusername']=$myusername;
$_SESSION['mypassword']=$mypassword ;

header("location:login_success.php");
}
else {
echo "Wrong Username or Password";
}

ob_end_flush();
 	

?>

//////////////////////
<?php
// Check if session is not registered, redirect back to main page.
// Put this code in first line of web page.

session_start();

if(!isset($_SESSION['myusername'])) {
header("location:login.html");
//echo "helloe";
}

?>

Open in new window

0
jagguy
Asked:
jagguy
  • 6
  • 3
  • 2
  • +1
1 Solution
 
Jagadishwor DulalBraces MediaCommented:
You are using mysql_real_escape_string and stripslashes yo prevent from sql injection see wikihow site for further works:
http://www.wikihow.com/Create-a-Secure-Login-Script-in-PHP-and-MySQL
0
 
GaryCommented:
Stop using mysql_query
http://php.net/manual/en/function.mysql-query.php

http://net.tutsplus.com/tutorials/php/php-database-access-are-you-doing-it-correctly/
And follow the practises in the link
And of course have the login over SSL
0
 
Ray PaseurCommented:
Add error_reporting(E_ALL) to the top of all your PHP scripts.  This will help you avoid common errors like relying on an undefined variable or constant.

This article shows how to get started in PHP.
http://www.experts-exchange.com/Web_Development/Web_Languages-Standards/PHP/A_11769-And-by-the-way-I-am-new-to-PHP.html

This article tells the design pattern for PHP client authentication.
http://www.experts-exchange.com/Web_Development/Web_Languages-Standards/PHP/A_2391-PHP-login-logout-and-easy-access-control.html

This article tells why and how to get off the MySQL extension.
http://www.experts-exchange.com/Web_Development/Web_Languages-Standards/PHP/PHP_Databases/A_11177-PHP-MySQL-Deprecated-as-of-PHP-5-5-0.html

Make a Google search for PHP + MySQL security and read the links you find on the first page.  Then join the OWASP project, to keep up-to-date on security.  It's a moving target.  If you think about it carefully, the mantra should be "accept only known good values."
0
The new generation of project management tools

With monday.com’s project management tool, you can see what everyone on your team is working in a single glance. Its intuitive dashboards are customizable, so you can create systems that work for you.

 
jagguyAuthor Commented:
My question was about the code I posted which I understand and I have done some php before. Worrying about  newer versions of php/mysql can be looked at in due time and the host server wont move to a newer version anytime soon as this will be bad for business.

Also my code does work which and I did research on security which is why I got the code in the first place.

 I will remove all non alpha numeric chars from a input string .

I dont believe my question has been answered as I did research and I would like to know what exactly is the security issue I am facing.
0
 
GaryCommented:
I cannot see any security issues with your code. I pointed to the PDO version because it is a more secure way of running queries - it will automatically take care of sql injection formats.
You say the security issue I am facing - what security issue?
0
 
jagguyAuthor Commented:
Yes I will look at PDO version in time. I thought there was a security issue but it looks like it is ok. Another issue is that php 5.5 hasnt  even been released officially ? The idea that all the ecommerce websites will suddenly not work as host servers will update to php 5 is just not going to happen anytime soon. This migration will take YEARS.
0
 
GaryCommented:
PDO is available now as standard not just in 5.5
0
 
GaryCommented:
That mysql_query will become unsupported means you should be writing your queries future proof i.e. do not be using old technologies for new code.
0
 
jagguyAuthor Commented:
how much work is involved in updating my code? I dont think it really matters for now but i see your point.
0
 
GaryCommented:
The main difference is using prepared statements - its slightly different than mysql_query but no more work (probably less work/code)

Setup the db connection, pass in host, db name, username and password or hardcode them
$conn = new PDO('mysql:host=localhost;dbname='.$database_name, $username, $password);
$conn->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);


Prepare your sql
     $stmt = $conn->prepare("SELECT column1,column2 FROM table WHERE comparison1=:mydata1 AND comparison2=:mydata2");
      $stmt->execute(array(
            ':mydata1' => $_POST['mydata1']),
            ':mydata2' => $_POST['mydata2'])
      );

$myresults= $stmt->fetch(PDO::FETCH_ASSOC);


And that basically is it, except for accessing the data - no escaping anything or worrying about injection.
PDO seperates the logic of the sql when passing it to MySQL removing any problem of sql injection - basically it tells MySQL here I am selecting something from a table based on this column and then it passes the information to base the select on
0
 
Ray PaseurCommented:
We write answers here for the purpose of helping you.  If you read the answers and they point you to an article, it's to save you from having to ask a million little questions.
how much work is involved in updating my code?
Here is the answer:
http://www.experts-exchange.com/Web_Development/Web_Languages-Standards/PHP/PHP_Databases/A_11177-PHP-MySQL-Deprecated-as-of-PHP-5-5-0.html
I dont think it really matters for now...
If you worked for me, that statement just got you fired.  We told you it matters now!  I need developers who can see the future and avoid future shock.  Especially if the future is written into the documentation of the online man pages!

Best of luck with your project, ~Ray
0
 
GaryCommented:
Even though you have accepted my answer I will again (in that I have pointed to it in the past) point you to Ray's great article - a lengthy thing but well worth reading.
What I gave you is a condensed version of writing future proof code (though that in 5 years may well be deprecated)
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

  • 6
  • 3
  • 2
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now