Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 463
  • Last Modified:

switch

Experts, I have the switch statement below.  It doesnt seem to pick up on the bolded part "Offshore".  The [BusinessUnit] does say Offshore but the switch does not return
"OFF"...only a blank and not a "?".  The Switch does work correctly for all others though.  Offshore is the only issue.

Do you see something wrong with it?  notice the bold.  It is not a spelling mistake. I dont know if there is a limit the criteris switch can handle (I have 8).   thank you

=Switch([BusinessUnit]="Onshore Houston","OH",[BusinessUnit]="Onshore Clarement","OC",[BusinessUnit] Like "*PT*","TSW",[BusinessUnit] Like "*Mexico*","MX",[BusinessUnit] Like "*Genesis*","GEN",[BusinessUnit]="TOF","TOF",[BusinessUnit]="Subsea","SUB",[BusinessUnit]="Offshore","OFF",1=1,"?")
0
pdvsa
Asked:
pdvsa
  • 8
  • 3
  • 2
  • +1
2 Solutions
 
Dale FyeCommented:
It works for me, as written.  Are you sure that you have a record which should match that criteria that doesn't also match one of the previous criteria?

What version of Access are you using?

Is this in a control source, or as a computed field in a query?
0
 
pdvsaAuthor Commented:
Hey fyed.... Yes j am sure there is a record.  Its a computed field in a query.  I am using 2007.  Let me get my computer out & make sure it is a computed field in query.
0
 
pdvsaAuthor Commented:
fyed:  it is actually in the control source.

I have attached the data returned from the query (on the left) and the report (the right).

Any idea why it returns blank in the report for only Offshore?  

thank you

 Offshore_is_blank
0
What is SQL Server and how does it work?

The purpose of this paper is to provide you background on SQL Server. It’s your self-study guide for learning fundamentals. It includes both the history of SQL and its technical basics. Concepts and definitions will form the solid foundation of your future DBA expertise.

 
Jeffrey CoachmanCommented:
1. I don't work with the switch function all that often, ...but what is that last expression doing: :
    1=1,"?"
...If you remove it, does this all work?

2. Does it work for Offshore if you just create  a switch function just of Offshore:
=switch([BusinessUnit]="Offshore","OFF")

3. I have seen some links that say that there is a 7 expression limit for the switch function... ...but fyed states it works ok for him...
...and just by looking at it, I see nothing wrong either...

4. Try swapping the first and last expressions and see what happens:

=Switch([BusinessUnit]="Offshore","OFF",[BusinessUnit]="Onshore Clarement","OC",[BusinessUnit] Like "*PT*","TSW",[BusinessUnit] Like "*Mexico*","MX",[BusinessUnit] Like "*Genesis*","GEN",[BusinessUnit]="TOF","TOF",[BusinessUnit]="Subsea","SUB",[BusinessUnit]="Onshore Houston","OH",1=1,"?")

5. Consider using a more normalized approach where the Switch function would not be needed.

6. Try going "old-School" and using an If/Then/Else, ...in a public function, in code.
Something roughly like this:

'--------------------------------------------------------------------------------
Public Function GetBizUnit(BizUnit as string) as string
If BizUnit="Onshore Houston"Then
    GetBizUnit="OH"
ElseIf BizUnit="Onshore Clarement" Then
    GetBizUnit="OC"
...
...
ElseIf BizUnit="Offshore" Then
    GetBizUnit="OFF"
End if
'--------------------------------------------------------------------------------

...Then call it like this: =GetBizUnit([BusinessUnit])

Hope some of this helps as well

;-)

JeffCoachman
0
 
pdvsaAuthor Commented:
Jeff:  thanks for the response.  

1.  1=1,"?"
...If you remove it, does this all work?
answer===>I tried and it did not work still

2. Does it work for Offshore if you just create  a switch function just of Offshore:
=switch([BusinessUnit]="Offshore","OFF")
===>It did not

3.  Try swapping it
===>that didnt work either



I made the Function hoping that would work but it didnt either :(.  It returned the same results as the switch inside the control source as I initially had it.  

here is my Function:
maybe I have something wrong with it.  If you could let me know would appreciate.  

Public Function GetBizUnit(BizUnit As String) As String

    If BizUnit = "Onshore Houston" Then
        GetBizUnit = "OH"
    ElseIf BizUnit = "Onshore Clarement" Then
        GetBizUnit = "OC"
    ElseIf BizUnit Like "*Process Tech*" Then
        GetBizUnit = "PT"
    ElseIf BizUnit = "Mexico*" Then
        GetBizUnit = "MX"
    ElseIf BizUnit Like "*Genesis*" Then
        GetBizUnit = "GEN"
    ElseIf BizUnit = "TOF" Then
        GetBizUnit = "TOF"
    ElseIf BizUnit = "Subsea" Then
        GetBizUnit = "SUB"
    ElseIf BizUnit = "Offshore and Subsea" Then
        GetBizUnit = "OH"
    ElseIf BizUnit = "Offshore" Then
        GetBizUnit = "OFF"
        
    End If
    

Open in new window



How could I modify the function to return a "?" if it is not in the list?  I had this in the switch statement.  Maybe if it returned a ? then might have some direction.  

thank you
0
 
Dale FyeCommented:
@Jeff,

I generally put the last expression of the SWITCH as something that returns true (I actually use a -1 and "Other"), but 1=1 is true, so if none of the other criteria are met, the final expression should result in the SWITCH( ) function returning the "?"

@Tony,

Based on your responses to the other questions (mine and Jeff's), I would guess that field containing the word "Offshore" has a space in it somewhere.

To modify the function, insert an ELSE statement just before the end if

ELSE
      GetBizUnit = "?"
End IF

If you call your function and pass it the "Offshore" value from the immediate window, what does it return?

?GetBizUnit("Offshore")
0
 
pdvsaAuthor Commented:
Fyed:

I thought there was certainly a space too but I checked and there is not.  

I attached the table in excel format.  It is an export directly from the db.

Maybe either of you guys can see a mistake somewhere.  

fyed:
It did return OFF in the immediate window.
here are the results:
?getBizUnit("Offshore")
OFF
tblBusinessUnit.xlsx
0
 
pdvsaAuthor Commented:
I see that it does work when I remove the switch from the control source and put BU: GetBizUnit([tblBusinessUnit].[BusinessUnit])  in the query

?
0
 
pdvsaAuthor Commented:
it is because the control source was a combo box with a row source query on it.  I changed it to a text box and it works.  

I shall split points on this one.  Any objects let me know.
0
 
aikimarkCommented:
Does the case and spelling of "Offshore" match the case and spelling in the [BusinessUnit] field?
0
 
pdvsaAuthor Commented:
aikimark:  yes.  Both are spelled "Offshore" with a capital "O" and there is not a space.  I think the issue was with the field as being a combo box and not a text box.
0
 
Dale FyeCommented:
Tony,

"I think the issue was with the field as being a combo box and not a text box. "

Don't confuse "fields" with "controls".
0
 
pdvsaAuthor Commented:
oopps....I have to stop that.
0
 
aikimarkCommented:
Don't forget trailing blanks
0

Featured Post

Free Tool: Path Explorer

An intuitive utility to help find the CSS path to UI elements on a webpage. These paths are used frequently in a variety of front-end development and QA automation tasks.

One of a set of tools we're offering as a way of saying thank you for being a part of the community.

  • 8
  • 3
  • 2
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now