Solved

dynamically creating view in a stored procedure

Posted on 2013-07-01
5
416 Views
Last Modified: 2013-07-22
How do I create a view in a stored procedure.  The stored procedure is passed a parameter, for example an id,  I will need to create the view name from this id and create the select statement using the id as a parameter in the where clause.  How is this done?


create replace sp_create_view(p_id number)

as

string = 'create view dyn' + p_id ' as
               select col1,
                          col2

               from table where table.id = p_id;'
0
Comment
Question by:cookiejar
  • 2
  • 2
5 Comments
 
LVL 76

Expert Comment

by:slightwv (䄆 Netminder)
ID: 39291297
First, I strongly encourage you to not do DDL in a procedure.

What is the view supposed to save you?

That said, given the example above (you have a typo):

string := 'create view dyn' + p_id ' as
               select col1,
                          col2

               from table where table.id = ' || p_id;

--after you build the string
execute immediate string;
0
 
LVL 35

Accepted Solution

by:
YZlat earned 500 total points
ID: 39291501
Try something like that:

PROCEDURE usp_create_view(p_id NUMBER) IS
   v_sql LONG;
BEGIN
   v_sql := 'CREATE VIEW dyn'||p_id ||' AS SELECT col1, col2, FROM TABLE WHERE TABLE.id='||p_id||';'
   DBMS_OUTPUT.PUT_LINE('v_sql: ' || v_sql);
   EXECUTE IMMEDIATE v_sql;
END; 

Open in new window

0
 
LVL 76

Expert Comment

by:slightwv (䄆 Netminder)
ID: 39291657
>>v_sql LONG;

NEVER use LONG's.  Use a CLOB.

>>id='||p_id||';'

I believe adding the semi-colon as part of the actual statement will generate a:
ORA-00911: invalid character



All that said, isn't that pretty much what I posted?
0
 
LVL 48

Expert Comment

by:PortletPaul
ID: 39292245
>>I will need to create the view name from this id and create the select statement using the id as a parameter in the where clause.
WHY?

what do you possibly gain by building a view, then using that view as part of a select?

just go to the select and bypass the create/replace of the view

seems to me you have the impression that this will (somehow) be more efficient - it won't be
also seems to me you feel that a parameter is a necessary part of efficiency - it isn't
(a 'where clause' on a STATIC view could be just as efficient, perhaps more so)

Would you describe what it is you are trying to achieve please?

and although I really don't like the sound of this, if you are going to proceed down this path, use:
CREATE OR REPLACE VIEW ...
0
 
LVL 35

Expert Comment

by:YZlat
ID: 39294243
slightwv, you posted

string := 'create view dyn' + p_id ' as
               select col1,
                          col2

               from table where table.id = ' || p_id;
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
Dataware house query tuning 9 78
Determine Who is Runnig my Bash Shell Script 4 79
PL SQL Developer 7 32
Oracle Query - Return results based on minimum value 8 30
This article started out as an Experts-Exchange question, which then grew into a quick tip to go along with an IOUG presentation for the Collaborate confernce and then later grew again into a full blown article with expanded functionality and legacy…
Cursors in Oracle: A cursor is used to process individual rows returned by database system for a query. In oracle every SQL statement executed by the oracle server has a private area. This area contains information about the SQL statement and the…
This video shows setup options and the basic steps and syntax for duplicating (cloning) a database from one instance to another. Examples are given for duplicating to the same machine and to different machines
This video shows how to set up a shell script to accept a positional parameter when called, pass that to a SQL script, accept the output from the statement back and then manipulate it in the Shell.

785 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question